Merge branch 'main' into crdtp

Author: bartlomieju

.github/workflows/ci.yml

@@ -143,7 +143,9 @@ jobs:
         uses: cargo-bins/cargo-binstall@main
 
       - name: Install nextest
-        run: cargo binstall cargo-nextest --secure
+        run: cargo binstall cargo-nextest --secure --locked --no-confirm
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Install python
         uses: actions/setup-python@v5
@@ -291,7 +293,7 @@ jobs:
         uses: cargo-bins/cargo-binstall@main
 
       - name: Install nextest
-        run: cargo binstall cargo-nextest --secure
+        run: cargo binstall cargo-nextest --secure --locked
 
       - name: Install python
         uses: actions/setup-python@v5

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "v8"
-version = "145.0.0"
+version = "146.3.0"
 description = "Rust bindings to V8"
 readme = "README.md"
 authors = ["the Deno authors"]

Cargo.toml

@@ -1,6 +1,6 @@
 # Rusty V8 Binding
 
-V8 Version: 14.5.201.4
+V8 Version: 14.6.202.9
 
 [![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions)
 [![crates](https://img.shields.io/crates/v/v8.svg)](https://crates.io/crates/v8)

README.md

@@ -222,12 +222,14 @@ fn build_binding() {
     .generate_cstr(true)
     .rustified_enum(".*UseCounterFeature")
     .rustified_enum(".*ModuleImportPhase")
+    .rustified_enum(".*Intercepted")
     .bitfield_enum(".*GCType")
     .bitfield_enum(".*GCCallbackFlags")
     .allowlist_item("v8__.*")
     .allowlist_item("cppgc__.*")
     .allowlist_item("RustObj")
     .allowlist_item("memory_span_t")
+    .allowlist_item("const_memory_span_t")
     .allowlist_item("ExternalConstOneByteStringResource")
     .generate()
     .expect("Unable to generate bindings");
@@ -636,32 +638,60 @@ fn download_file(url: &str, filename: &Path) {
     fs::remove_file(&tmpfile).unwrap();
   }
 
-  // Try downloading with python first. Python is a V8 build dependency,
+  // Try downloading with deno first, then python, then curl.
+  println!("Downloading {url}");
+  let status = which("deno").ok().and_then(|deno| {
+    println!("Trying with Deno...");
+    Command::new(deno)
+      .arg("eval")
+      .arg(
+        "const [url, path] = Deno.args; \
+         const resp = await fetch(url); \
+         if (!resp.ok) Deno.exit(1); \
+         const file = await Deno.open(path, { write: true, create: true }); \
+         await resp.body.pipeTo(file.writable);",
+      )
+      .arg("--allow-net")
+      .arg("--allow-write")
+      .arg("--")
+      .arg(url)
+      .arg(&tmpfile)
+      .status()
+      .ok()
+      .filter(|s| s.success())
+  });
+
+  // Try downloading with python. Python is a V8 build dependency,
   // so this saves us from adding a Rust HTTP client dependency.
-  println!("Downloading (using Python) {url}");
-  let status = Command::new(python())
-    .arg("./tools/download_file.py")
-    .arg("--url")
-    .arg(url)
-    .arg("--filename")
-    .arg(&tmpfile)
-    .status();
-
-  // Python is only a required dependency for `V8_FROM_SOURCE` builds.
-  // If python is not available, try falling back to curl.
   let status = match status {
-    Ok(status) if status.success() => status,
+    Some(status) => status,
     _ => {
-      println!("Python downloader failed, trying with curl.");
-      Command::new("curl")
-        .arg("-L")
-        .arg("-f")
-        .arg("-s")
-        .arg("-o")
-        .arg(&tmpfile)
+      println!("Trying with Python...");
+      let python_status = Command::new(python())
+        .arg("./tools/download_file.py")
+        .arg("--url")
         .arg(url)
-        .status()
-        .unwrap()
+        .arg("--filename")
+        .arg(&tmpfile)
+        .status();
+
+      // Python is only a required dependency for `V8_FROM_SOURCE` builds.
+      // If python is not available, try falling back to curl.
+      match python_status {
+        Ok(status) if status.success() => status,
+        _ => {
+          println!("Python downloader failed, trying with curl.");
+          Command::new("curl")
+            .arg("-L")
+            .arg("-f")
+            .arg("-s")
+            .arg("-o")
+            .arg(&tmpfile)
+            .arg(url)
+            .status()
+            .unwrap()
+        }
+      }
     }
   };
 

build

@@ -295,8 +295,8 @@ impl<'scope, 'obj, 'isolate> JsHttpRequestProcessor<'scope, 'obj, 'isolate> {
     args: v8::PropertyCallbackArguments,
     mut rv: v8::ReturnValue,
   ) {
-    let this = args.this();
-    let external = Self::unwrap_request(scope, this);
+    let holder = args.holder();
+    let external = Self::unwrap_request(scope, holder);
 
     assert!(
       !external.is_null(),

build.rs

@@ -1,5 +1,5 @@
 [toolchain]
-channel = "1.89.0"
+channel = "1.91.0"
 components = ["rustfmt", "clippy"]
 targets = [
     "x86_64-apple-darwin",