Rolling to V8 14.6.202.2 (#1906)

Author: denobot

README.md

@@ -1,6 +1,6 @@
 # Rusty V8 Binding
 
-V8 Version: 14.5.201.5
+V8 Version: 14.6.202.2
 
 [![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions)
 [![crates](https://img.shields.io/crates/v/v8.svg)](https://crates.io/crates/v8)

build

@@ -222,12 +222,14 @@ fn build_binding() {
     .generate_cstr(true)
     .rustified_enum(".*UseCounterFeature")
     .rustified_enum(".*ModuleImportPhase")
+    .rustified_enum(".*Intercepted")
     .bitfield_enum(".*GCType")
     .bitfield_enum(".*GCCallbackFlags")
     .allowlist_item("v8__.*")
     .allowlist_item("cppgc__.*")
     .allowlist_item("RustObj")
     .allowlist_item("memory_span_t")
+    .allowlist_item("const_memory_span_t")
     .allowlist_item("ExternalConstOneByteStringResource")
     .generate()
     .expect("Unable to generate bindings");

build.rs

@@ -295,8 +295,8 @@ impl<'scope, 'obj, 'isolate> JsHttpRequestProcessor<'scope, 'obj, 'isolate> {
     args: v8::PropertyCallbackArguments,
     mut rv: v8::ReturnValue,
   ) {
-    let this = args.this();
-    let external = Self::unwrap_request(scope, this);
+    let holder = args.holder();
+    let external = Self::unwrap_request(scope, holder);
 
     assert!(
       !external.is_null(),

buildtools

@@ -948,9 +948,8 @@ const v8::Boolean* v8__Boolean__New(v8::Isolate* isolate, bool value) {
 
 int v8__FixedArray__Length(const v8::FixedArray& self) { return self.Length(); }
 
-const v8::Data* v8__FixedArray__Get(const v8::FixedArray& self,
-                                    const v8::Context& context, int index) {
-  return local_to_ptr(ptr_to_local(&self)->Get(ptr_to_local(&context), index));
+const v8::Data* v8__FixedArray__Get(const v8::FixedArray& self, int index) {
+  return local_to_ptr(ptr_to_local(&self)->Get(index));
 }
 
 const v8::PrimitiveArray* v8__PrimitiveArray__New(v8::Isolate* isolate,
@@ -1456,14 +1455,15 @@ const v8::Value* v8__Object__GetIndex(const v8::Object& self,
       ptr_to_local(&self)->Get(ptr_to_local(&context), index));
 }
 
-void* v8__Object__GetAlignedPointerFromInternalField(const v8::Object& self,
-                                                     int index) {
-  return ptr_to_local(&self)->GetAlignedPointerFromInternalField(index);
+void* v8__Object__GetAlignedPointerFromInternalField(
+    const v8::Object& self, int index, v8::EmbedderDataTypeTag tag) {
+  return ptr_to_local(&self)->GetAlignedPointerFromInternalField(index, tag);
 }
 
 void v8__Object__SetAlignedPointerInInternalField(const v8::Object& self,
-                                                  int index, void* value) {
-  ptr_to_local(&self)->SetAlignedPointerInInternalField(index, value);
+                                                  int index, void* value,
+                                                  v8::EmbedderDataTypeTag tag) {
+  ptr_to_local(&self)->SetAlignedPointerInInternalField(index, value, tag);
 }
 
 bool v8__Object__IsApiWrapper(const v8::Object& self) {
@@ -1997,12 +1997,14 @@ void DeserializeInternalFields(v8::Local<v8::Object> holder, int index,
                                v8::StartupData payload, void* data) {
   assert(data == nullptr);
   if (payload.raw_size == 0) {
-    holder->SetAlignedPointerInInternalField(index, nullptr);
+    holder->SetAlignedPointerInInternalField(index, nullptr,
+                                             v8::kEmbedderDataTypeTagDefault);
     return;
   }
   InternalFieldData* embedder_field = new InternalFieldData{0};
   memcpy(embedder_field, payload.data, payload.raw_size);
-  holder->SetAlignedPointerInInternalField(index, embedder_field);
+  holder->SetAlignedPointerInInternalField(index, embedder_field,
+                                           v8::kEmbedderDataTypeTagDefault);
   deserialized_data.push_back(embedder_field);
 }
 
@@ -2406,11 +2408,6 @@ const v8::Value* v8__PropertyCallbackInfo__Data(
   return local_to_ptr(self.Data());
 }
 
-const v8::Object* v8__PropertyCallbackInfo__This(
-    const v8::PropertyCallbackInfo<v8::Value>& self) {
-  return local_to_ptr(self.This());
-}
-
 const v8::Object* v8__PropertyCallbackInfo__Holder(
     const v8::PropertyCallbackInfo<v8::Value>& self) {
   return local_to_ptr(self.HolderV2());
@@ -2907,7 +2904,8 @@ v8::StartupData SerializeInternalFields(v8::Local<v8::Object> holder, int index,
                                         void* data) {
   assert(data == nullptr);
   InternalFieldData* embedder_field = static_cast<InternalFieldData*>(
-      holder->GetAlignedPointerFromInternalField(index));
+      holder->GetAlignedPointerFromInternalField(
+          index, v8::kEmbedderDataTypeTagDefault));
   if (embedder_field == nullptr) return {nullptr, 0};
   int size = sizeof(*embedder_field);
   char* payload = new char[size];
@@ -3438,13 +3436,20 @@ void v8__WasmStreaming__shared_ptr_DESTRUCT(WasmStreamingSharedPtr* self) {
   self->~WasmStreamingSharedPtr();
 }
 
+void v8__WasmStreaming__SetHasCompiledModuleBytes(
+    WasmStreamingSharedPtr* self) {
+  self->inner->SetHasCompiledModuleBytes();
+}
+
 void v8__WasmStreaming__OnBytesReceived(WasmStreamingSharedPtr* self,
                                         const uint8_t* data, size_t len) {
   self->inner->OnBytesReceived(data, len);
 }
 
-void v8__WasmStreaming__Finish(WasmStreamingSharedPtr* self) {
-  self->inner->Finish();
+void v8__WasmStreaming__Finish(
+    WasmStreamingSharedPtr* self,
+    void (*callback)(v8::WasmStreaming::ModuleCachingInterface&)) {
+  self->inner->Finish(callback);
 }
 
 void v8__WasmStreaming__Abort(WasmStreamingSharedPtr* self,
@@ -3457,6 +3462,19 @@ void v8__WasmStreaming__SetUrl(WasmStreamingSharedPtr* self, const char* url,
   self->inner->SetUrl(url, len);
 }
 
+const_memory_span_t v8__ModuleCachingInterface__GetWireBytes(
+    const v8::WasmStreaming::ModuleCachingInterface& self) {
+  v8::MemorySpan<const uint8_t> span = self.GetWireBytes();
+  return {span.data(), span.size()};
+}
+
+bool v8__ModuleCachingInterface__SetCachedCompiledModuleBytes(
+    v8::WasmStreaming::ModuleCachingInterface& self,
+    const_memory_span_t bytes) {
+  v8::MemorySpan<const uint8_t> bytes_span{bytes.data, bytes.size};
+  return self.SetCachedCompiledModuleBytes(bytes_span);
+}
+
 const v8::ArrayBuffer* v8__WasmMemoryObject__Buffer(
     const v8::WasmMemoryObject& self) {
   return local_to_ptr(ptr_to_local(&self)->Buffer());

examples/process.rs

@@ -44,6 +44,7 @@ using v8__HeapStatistics = v8::HeapStatistics;
 using v8__HeapSpaceStatistics = v8::HeapSpaceStatistics;
 using v8__GCType = v8::GCType;
 using v8__GCCallbackFlags = v8::GCCallbackFlags;
+using v8__Intercepted = v8::Intercepted;
 
 static uint32_t v8__MAJOR_VERSION = V8_MAJOR_VERSION;
 static uint32_t v8__MINOR_VERSION = V8_MINOR_VERSION;

src/binding.cc

@@ -1,19 +1,15 @@
-use crate::scope::PinScope;
 // Copyright 2019-2021 the Deno authors. All rights reserved. MIT license.
-use crate::Context;
+
 use crate::Data;
 use crate::FixedArray;
 use crate::Local;
+use crate::scope::PinScope;
 use crate::support::int;
 
 unsafe extern "C" {
   fn v8__FixedArray__Length(this: *const FixedArray) -> int;
 
-  fn v8__FixedArray__Get(
-    this: *const FixedArray,
-    context: *const Context,
-    index: int,
-  ) -> *const Data;
+  fn v8__FixedArray__Get(this: *const FixedArray, index: int) -> *const Data;
 }
 
 impl FixedArray {
@@ -32,10 +28,6 @@ impl FixedArray {
       return None;
     }
 
-    unsafe {
-      scope.cast_local(|sd| {
-        v8__FixedArray__Get(self, &*sd.get_current_context(), index as int)
-      })
-    }
+    unsafe { scope.cast_local(|_| v8__FixedArray__Get(self, index as int)) }
   }
 }

src/binding.hpp

@@ -97,9 +97,6 @@ unsafe extern "C" {
   fn v8__PropertyCallbackInfo__Data(
     this: *const RawPropertyCallbackInfo,
   ) -> *const Value;
-  fn v8__PropertyCallbackInfo__This(
-    this: *const RawPropertyCallbackInfo,
-  ) -> *const Object;
   fn v8__PropertyCallbackInfo__Holder(
     this: *const RawPropertyCallbackInfo,
   ) -> *const Object;
@@ -406,52 +403,6 @@ impl<'s> PropertyCallbackArguments<'s> {
     }
   }
 
-  /// Returns the receiver. In many cases, this is the object on which the
-  /// property access was intercepted. When using
-  /// `Reflect.get`, `Function.prototype.call`, or similar functions, it is the
-  /// object passed in as receiver or thisArg.
-  ///
-  /// ```c++
-  ///   void GetterCallback(Local<Name> name,
-  ///                       const v8::PropertyCallbackInfo<v8::Value>& info) {
-  ///      auto context = info.GetIsolate()->GetCurrentContext();
-  ///
-  ///      v8::Local<v8::Value> a_this =
-  ///          info.This()
-  ///              ->GetRealNamedProperty(context, v8_str("a"))
-  ///              .ToLocalChecked();
-  ///      v8::Local<v8::Value> a_holder =
-  ///          info.Holder()
-  ///              ->GetRealNamedProperty(context, v8_str("a"))
-  ///              .ToLocalChecked();
-  ///
-  ///     CHECK(v8_str("r")->Equals(context, a_this).FromJust());
-  ///     CHECK(v8_str("obj")->Equals(context, a_holder).FromJust());
-  ///
-  ///     info.GetReturnValue().Set(name);
-  ///   }
-  ///
-  ///   v8::Local<v8::FunctionTemplate> templ =
-  ///   v8::FunctionTemplate::New(isolate);
-  ///   templ->InstanceTemplate()->SetHandler(
-  ///       v8::NamedPropertyHandlerConfiguration(GetterCallback));
-  ///   LocalContext env;
-  ///   env->Global()
-  ///       ->Set(env.local(), v8_str("obj"), templ->GetFunction(env.local())
-  ///                                            .ToLocalChecked()
-  ///                                            ->NewInstance(env.local())
-  ///                                            .ToLocalChecked())
-  ///       .FromJust();
-  ///
-  ///   CompileRun("obj.a = 'obj'; var r = {a: 'r'}; Reflect.get(obj, 'x', r)");
-  /// ```
-  #[inline(always)]
-  pub fn this(&self) -> Local<'s, Object> {
-    unsafe {
-      Local::from_raw(v8__PropertyCallbackInfo__This(self.0)).unwrap_unchecked()
-    }
-  }
-
   /// Returns the data set in the configuration, i.e., in
   /// `NamedPropertyHandlerConfiguration` or
   /// `IndexedPropertyHandlerConfiguration.`

src/fixed_array.rs

@@ -1676,7 +1676,7 @@ impl Isolate {
       + for<'a, 'b, 'c> Fn(
         &'c mut PinScope<'a, 'b>,
         Local<'a, Value>,
-        WasmStreaming,
+        WasmStreaming<false>,
       ),
   {
     unsafe {