Conversation
0d478d9 to
bb314fe
Compare
bb314fe to
fc55a6a
Compare
| $basename = "sccache-$version-$platform" | ||
| $url = "https://github.com/mozilla/sccache/releases/download/" + | ||
| "$version/$basename.tar.gz" | ||
| $url = "https://github.com/mozilla/sccache/releases/download/$version/$basename.tar.gz" |
There was a problem hiding this comment.
hi, can you help me understand, why use pwsh scripts to manually download sccache, instead of using the sccache-action ?
There was a problem hiding this comment.
This all was written before that existed. Glad to know about it!
There was a problem hiding this comment.
I tested with sccache-action in my fork repo: https://github.com/linrongbin16/rusty_v8/pull/2
The ci job failed on windows: https://github.com/linrongbin16/rusty_v8/actions/runs/14051568959
The error says 'sccahce' cannot compile 'syn' lib, and I search such kind of error, found this issue: mozilla/sccache#2196
So the conclusion is: sccache has a different behavior for rustc_wrapper and server/client. So maybe keep it this way.
There was a problem hiding this comment.
I submit PR #1748 to simplify the installtion of sccache.
There was a problem hiding this comment.
Thanks - happy to land that patch if you can get it to work
There was a problem hiding this comment.
I already finished the PR (and test many times), would you take a look?
we have a native linux aarch64 runner now, so we can use that instead of qemu :D