feat: add toggles for organize imports and symbols (#1350)

Author: birgersp

README.md

@@ -206,6 +206,15 @@ extension has the following configuration options:
   by the Deno Language Server to host its TS server.
 - `deno.lint`: Controls if linting information will be provided by the Deno
   Language Server. _boolean, default `true`_
+- `deno.organizeImports.enabled`: Controls if the Deno language server
+  contributes organize imports code actions. Disable to rely on VS Code's
+  built-in TypeScript/JavaScript organizer. _boolean, default `true`_
+- `deno.symbols.document.enabled`: Controls if the Deno language server
+  contributes document symbols. Disable to rely on VS Code's built-in provider.
+  _boolean, default `true`_
+- `deno.symbols.workspace.enabled`: Controls if the Deno language server
+  contributes workspace symbols. Disable to rely on VS Code's built-in
+  provider. _boolean, default `true`_
 - `deno.maxTsServerMemory`: Maximum amount of memory the TypeScript isolate can
   use. Defaults to 3072 (3GB).
 - `deno.suggest.imports.hosts`: A map of domain hosts (origins) that are used

client/src/commands.ts

@@ -168,6 +168,14 @@ export function startLanguageServer(
     }
     env["DENO_V8_FLAGS"] = getV8Flags();
 
+    const isProvideSettingEnabled = (
+      setting: string,
+      resource?: vscode.Uri,
+    ) =>
+      vscode.workspace.getConfiguration(EXTENSION_NS, resource).get<boolean>(
+        setting,
+      ) ?? true;
+
     const shell = process.platform === "win32" &&
       /\.([Cc][Mm][Dd]|[Bb][Aa][Tt])$/.test(command);
     const serverOptions: ServerOptions = {
@@ -203,6 +211,37 @@ export function startLanguageServer(
               return response;
             },
           },
+          provideCodeActions: async (
+            document,
+            range,
+            context,
+            token,
+            next,
+          ) => {
+            const actions = await next(document, range, context, token);
+            if (
+              actions == null || !Array.isArray(actions) ||
+              isProvideSettingEnabled("organizeImports.enabled", document.uri)
+            ) {
+              return actions;
+            }
+            return actions.filter((action) => {
+              const kind = (action as vscode.CodeAction).kind;
+              return !kind?.contains(vscode.CodeActionKind.SourceOrganizeImports);
+            });
+          },
+          provideDocumentSymbols: (document, token, next) => {
+            if (!isProvideSettingEnabled("symbols.document.enabled", document.uri)) {
+              return [];
+            }
+            return next(document, token);
+          },
+          provideWorkspaceSymbols: (query, token, next) => {
+            if (!isProvideSettingEnabled("symbols.workspace.enabled")) {
+              return [];
+            }
+            return next(query, token);
+          },
         },
         ...extensionContext.clientOptions,
       },

package.json

@@ -557,6 +557,36 @@
             false
           ]
         },
+        "deno.organizeImports.enabled": {
+          "type": "boolean",
+          "default": true,
+          "markdownDescription": "Controls if the Deno language server contributes organize imports code actions. Disable to rely on VS Code's built-in TypeScript/JavaScript organize imports instead.",
+          "scope": "resource",
+          "examples": [
+            true,
+            false
+          ]
+        },
+        "deno.symbols.document.enabled": {
+          "type": "boolean",
+          "default": true,
+          "markdownDescription": "Controls if the Deno language server provides document symbols. Disable to rely on VS Code's built-in providers instead.",
+          "scope": "resource",
+          "examples": [
+            true,
+            false
+          ]
+        },
+        "deno.symbols.workspace.enabled": {
+          "type": "boolean",
+          "default": true,
+          "markdownDescription": "Controls if the Deno language server provides workspace symbols. Disable to rely on VS Code's built-in providers instead.",
+          "scope": "resource",
+          "examples": [
+            true,
+            false
+          ]
+        },
         "deno.internalDebug": {
           "type": "boolean",
           "default": false,