Jupyter kernel on vscode gives error about variables declared on above cells

[ceifa]

To Reproduce

1. Open deno kernel on vscode
2. Create a variable in the first cell
3. Use it on the second one

Expected behavior

None errors

Screenshots

Versions

vscode: 1.82.2 deno: 1.37 extension: v3.23.1

@bartlomieju

[bartlomieju]

@nayeemrmn could you take a look what's going on here?

[amunger]

This will happen in the deno language server isn't being used - try adding "deno.enable": true to your settings and see if the error goes away.

It looks like you can also put your notebooks in a specific directory and add that directory to deno.enablePaths as recommended in the setting description.

[amunger]

But I would say it should be safe for the extension to always use the deno language server for a notebook that has a deno kernel selected.

[ceifa]

But I would say it should be safe for the extension to always use the deno language server for a notebook that has a deno kernel selected.

I agree. Specifically because I don't want deno to be enabled on the global settings and I also don't want to save the notebook file sometimes.

[ghing]

I'm also seeing this issue and have "deno.enable": true in my .vscode/settings.json.

[scarf005]

i'm wondering how this could be solved implementation-wise. my naive first impression was:

1. join all typescript cells
2. send the joined cell into tsc
3. parse tsc diagnostics and re-map line numbers into splitted cells

[nayeemrmn]

I forgot to give an update here, this is blocked by gluon-lang/lsp-types#268 which implements this API in the protocol https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notebookDocument_synchronization. This provides the minimum of getting the accurate order of the cells etc.

After that it's still going to be difficult and we'd likely have to do what @scarf005 proposed above. On the surface this isn't a problem with VSCode's built-in node TS server because it has notebook cells in script mode, where all vars are global. We might alternatively end up doing something similar.

[bartlomieju]

Would this PR help somehow? denoland/deno#21518

[pekam]

I'm also seeing this issue and have "deno.enable": true in my .vscode/settings.json.

Same here. The Deno APIs are enabled as shown by this screenshot:

Jupyter support is the only reason why I started using Deno, and this issue is a blocker for me.