Should not use set_exception_handler

[jarbey]

php-bitcoinrpc/src/functions.php

Line 121 in 172c184

set_exception_handler([ExceptionHandler::getInstance(), 'handle']);

Using set_exception_handler can override existings handler and can be a big problem for application that already use it.
For it has shutdown the NewRelic error reporting !

I suggest either to not use it or, to use it right before a call and call restore_exception_handler after the call (a successfull call or an error one).

I will have to find a way to change that. If i can will propose you a pullrequest

[denpamusic]

Thank you for the feedback!

I'll see what I can do to change exception handling on the weekends.
PR would be awesome too!

Sorry for inconvenience that it caused.

[jarbey]

Don't be worry for the inconvenience ! I should thank you for the job you have done and to share it with everyone !

I was asking myself "Why an handler is needed ?"

• As for sync call you already have a try / catch :

  php-bitcoinrpc/src/Client.php

  Lines 152 to 164 in 172c184

  	try {
  	$response = $this->client
  	->post($this->path, $this->makeJson($method, $params));
  	if ($response->hasError()) {
  	// throw exception on error
  	throw new BadRemoteCallException($response);
  	}
  	return $response;
  	} catch (Throwable $exception) {
  	throw exception()->handle($exception);
  	}

• For Async call you manage error on the promise :

  php-bitcoinrpc/src/Client.php

  Lines 191 to 195 in 172c184

  	try {
  	exception()->handle($exception);
  	} catch (Throwable $exception) {
  	$this->onError($exception, $rejected);
  	}

Maybe it's not usefull to use a global PHP Exception handler, and we can locally trap exception, if there is any missing ?

[jarbey]

Any update on that please ?