autoflake not working?

[ubaldot]

I am pretty sure that I am doing something very silly, but i cannot sort out my issue.
I am running on Unbuntu 20.04 and everything works but the fixers do not seem to work.

This is my .vimrc

let g:ale_linters = {'c': ['clangd','cppcheck','gcc'],'python':['flake8']}
let g:ale_fixers = {
            \ '*':['remove_trailing_lines', 'trim_whitespace'],
            \ 'c':['clang-format'],
            \ 'python':['autoflake','add_blank_lines_for_python_control_statements','reorder-python-imports']
            \}

I created a simple test file where I triggered the following error

E231 missing whitespace after ','

plus, I added some white lines at the end of my file.
I expected autoflake, trim_whitespace and the remove_trailing_lines fixers to kick-in upon a call to :ALEFix but nothing happened.
I have it installed with pip install autoflake. Python version is 3.8.

This is the output of ALEInfo

 Current Filetype: python
Available Linters: ['bandit', 'cspell', 'flake8', 'flakehell', 'jedils', 'mypy', 'prospector', 'pycodestyle', 'pydocstyle', 'pyflakes', 'pylama', 'pylint', 'pylsp', 'pyre', 'pyright', 'vulture']
  Enabled Linters: ['flake8']
  Ignored Linters: []
 Suggested Fixers: 
  'add_blank_lines_for_python_control_statements' - Add blank lines before control statements.
  'autoflake' - Fix flake issues with autoflake.
  'autoimport' - Fix import issues with autoimport.
  'autopep8' - Fix PEP8 issues with autopep8.
  'black' - Fix PEP8 issues with black.
  'isort' - Sort Python imports with isort.
  'remove_trailing_lines' - Remove all blank lines at the end of a file.
  'reorder-python-imports' - Sort Python imports with reorder-python-imports.
  'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
  'yapf' - Fix Python files with yapf.
 Linter Variables:

let g:ale_python_auto_pipenv = 0
let g:ale_python_auto_poetry = 0
let g:ale_python_autoflake_executable = 'autoflake'
let g:ale_python_autoflake_options = ''
let g:ale_python_autoflake_use_global = 0
let g:ale_python_flake8_auto_pipenv = 0
let g:ale_python_flake8_auto_poetry = 0
let g:ale_python_flake8_change_directory = 'project'
let g:ale_python_flake8_executable = 'flake8'
let g:ale_python_flake8_options = ''
let g:ale_python_flake8_use_global = 0
let g:ale_python_reorder_python_imports_executable = 'reorder-python-imports'
let g:ale_python_reorder_python_imports_options = ''
let g:ale_python_reorder_python_imports_use_global = 0
 Global Variables:

let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_disable_lsp = 0
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {'c': ['clang-format'], '*': ['remove_trailing_lines', 'trim_whitespace'], 'python': ['autoflake', 'add_blank_lines_for_python_control_statements', 'reorder-python-imports']}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_insert_leave = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'normal'
let g:ale_linter_aliases = {}
let g:ale_linters = {'c': ['clangd', 'cppcheck', 'gcc'], 'python': ['python-lsp-server', 'flake8']}
let g:ale_linters_explicit = 0
let g:ale_linters_ignore = {}
let g:ale_list_vertical = 0
let g:ale_list_window_size = 10
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = v:null
let g:ale_open_list = 0
let g:ale_pattern_options = v:null
let g:ale_pattern_options_enabled = v:null
let g:ale_root = {}
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_info = '--'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = '--'
let g:ale_sign_warning = '--'
let g:ale_sign_highlight_linenrs = 0
let g:ale_statusline_format = v:null
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_virtualtext_cursor = 0
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

(executable check - success) flake8
(finished - exit code 0) ['/bin/bash', '-c', 'cd ''/home/yt75534/python_tutorial/plot_training'' && ''flake8'' --version']

<<<OUTPUT STARTS>>>
4.0.1 (mccabe: 0.6.1, pycodestyle: 2.8.0, pyflakes: 2.4.0) CPython 3.8.10 on Linux
<<<OUTPUT ENDS>>>

(finished - exit code 1) ['/bin/bash', '-c', 'cd ''/home/yt75534/python_tutorial/plot_training'' && ''flake8'' --format=default --stdin-display-name ''/home/yt75534/python_tutorial/plot_training/some_random_plots.py'' - < ''/tmp/v2MS6UX/1/some_random_plots.py''']

<<<OUTPUT STARTS>>>
/home/yt75534/python_tutorial/plot_training/some_random_plots.py:4:18: E231 missing whitespace after ','
/home/yt75534/python_tutorial/plot_training/some_random_plots.py:4:21: E231 missing whitespace after ','
/home/yt75534/python_tutorial/plot_training/some_random_plots.py:14:5: W291 trailing whitespace
<<<OUTPUT ENDS>>>
(finished - exit code 0) ['/bin/bash', '-c', '''autoflake'' --in-place  ''/tmp/v2MS6UX/2/some_random_plots.py''']

[ubaldot]

I can self-answer my question: autoflake is meant to be used for removing unused imports and unused variables from Python code.
Nevertheless I set

let g:ale_python_autoflake_options = ['--remove-unused-variables','--remove-all-unused-imports']

which results in E730: using List as a String. Perhaps there is a syntax error in the way I defined the autoflake options.
Any hints?

[hsanson]

Options is set as as string ,not an array. Try setting it like this and see if it works for you:

let g:ale_python_autoflake_options = '--remove-unused-variables --remove-all-unused-imports'

[ubaldot]

That worked! Thanks!