Skip to content

Commit 31a8346

Browse files
committed
use filter params constant to bypass versioning
1 parent 3ef2686 commit 31a8346

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

app/controllers/v1/lcpe/lacs_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def list
4343
def index_params
4444
return @index_params if defined?(@index_params)
4545

46-
@index_params = params.permit(:edu_lac_type_nm, :state, :lac_nm, :page, :per_page)
46+
@index_params = params.permit(*FILTER_PARAMS)
4747
end
4848

4949
def page

app/controllers/v1/lcpe_base_controller.rb

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ class PreloadVersionStaleError < StandardError; end
66

77
rescue_from PreloadVersionStaleError, with: :version_invalid
88

9+
FILTER_PARAMS = %i[edu_lac_type_nm state lac_nm page per_page].freeze
10+
911
private
1012

1113
def validate_preload_version
@@ -35,11 +37,7 @@ def set_headers(preload_version)
3537

3638
# If additional filter params present, bypass versioning
3739
def bypass_versioning?
38-
scrubbed_params.present?
39-
end
40-
41-
def scrubbed_params
42-
params.except(:format, :controller, :action, controller_name.singularize.to_sym)
40+
params.keys.map(&:to_sym).intersect?(FILTER_PARAMS)
4341
end
4442

4543
def version_invalid

0 commit comments

Comments
 (0)