diff --git a/app/controllers/v1/lcpe/lacs_controller.rb b/app/controllers/v1/lcpe/lacs_controller.rb index f3afd1a2c..97e26df81 100644 --- a/app/controllers/v1/lcpe/lacs_controller.rb +++ b/app/controllers/v1/lcpe/lacs_controller.rb @@ -43,7 +43,7 @@ def list def index_params return @index_params if defined?(@index_params) - @index_params = params.permit(:edu_lac_type_nm, :state, :lac_nm, :page, :per_page) + @index_params = params.permit(*FILTER_PARAMS) end def page diff --git a/app/controllers/v1/lcpe_base_controller.rb b/app/controllers/v1/lcpe_base_controller.rb index c829efc23..3f54e4159 100644 --- a/app/controllers/v1/lcpe_base_controller.rb +++ b/app/controllers/v1/lcpe_base_controller.rb @@ -6,6 +6,8 @@ class PreloadVersionStaleError < StandardError; end rescue_from PreloadVersionStaleError, with: :version_invalid + FILTER_PARAMS = %i[edu_lac_type_nm state lac_nm page per_page].freeze + private def validate_preload_version @@ -35,11 +37,7 @@ def set_headers(preload_version) # If additional filter params present, bypass versioning def bypass_versioning? - scrubbed_params.present? - end - - def scrubbed_params - params.except(:format, :controller, :action, controller_name.singularize.to_sym) + params.keys.map(&:to_sym).intersect?(FILTER_PARAMS) end def version_invalid