Skip to content

Upgrade marshmallow-sqlalchemy #2284

Open
@kalbfled

Description

@kalbfled

User Story - Business Need

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a Notify developer,
I want to use the latest version of marshmallow-sqlalchemy
So that we avoid bit rot.

Additional Info and Resources

During the routine upgrades for #2243, upgrading marshmallow-sqlalchemy from v1.1.1 to v1.4.x caused 6 unit test failures. They all failed with a traceback indicating that "communication_item_item" was not found on the template schema instance. That package is now pinned at ~1.1.1 in pyproject.toml.

Acceptance Criteria

  • marshmallow-sqlalchemy upgraded to the newest version with all tests passing
  • hardcoded value in pyproject.toml removed
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

Potential Dependencies

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions