QA: manual validation of legacy v2 sms routes

[cris-oddball]

User Story - Business Need

Manual validation of Pydantic models and route validation for the POST /legacy/v2/notifications/sms and GET /legacy/v2/notifications/:notification_idroutes was deferred because not everything is connected at the time of this writing to properly validate the responses. This ticket aims to manually validate that the routes return the same responses as the notification-api routes.

• Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a Developer working on ENP
I want to ensure that the ENP legacy sms routes return the same responses as the notification-api
So that I can ensure parity between the two services.

Additional Info and Resources

QA-245 and QA-246depend on the manual validation that happens in this ticket.

Also note that GET route needs to be under automation, which can either be folded into the above tickets or a new ticket created if needed.

Acceptance Criteria

• POST /v2/notifications/sms request model is exactly the same as it is in the notification-api
• POST /v2/notifications/sms response model is exactly the same as it is in the notification-api
• POST /legacy/v2/notifications/sms request model is exactly the same as it is in the notification-api
• POST /legacy/v2/notifications/sms response model is exactly the same as it is in the notification-api
• This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

• Determine what, if anything, needs to be changed in the QA regression to be able to support this work
• Update the QA tickets linked above with the relevant information.
• Create a GET legacy/v2/notifications/:notification_id ticket for QA automation if needed

Potential Dependencies

#117 added the Pydantic models for the legacy v2 sms routes
#112 added route validation for the legacy v2 sms routes
#114 connects ENP to the notification-api database

All three tickets need to be complete before any work can begin on this ticket.

Out of Scope

• Automation of the above, which is covered in a different ticket.