Skip to content

Incorporate Design System Icon Component into the Flagship App - Health & Benefits #7694

Open
@kellylein

Description

@kellylein

Developer Notes

  • VAIcon has been renamed to Icon in the component library
  • Box props have been removed since they were not used much. Any VAIcons that have Box properties (mt, pt, etc) should instead be surrounded with a <Box> component and set margin/padding on the Box instead. Instances of VAIcon with Box props are as follows:
    • BackButton
    • DescriptiveBackButton
    • LabelTag
    • LargeNavButton
    • SelectionList
  • All other props remain the same

Important links

Definition of Done

  • @department-of-veterans-affairs/mobile-component-library has been updated to 0.4.0
  • VAIcon has been replaced with new Icon component
  • Remove VAIcon component and SVGs from the app
  • Remove react-native-svg, react-native-svg-transformer from package.json
  • Remove declare module '*.svg'... block from global.d.ts
  • Remove babelTransformerPath and resolver from metro.config.js
  • The Mobile apps have been released to their respective app stores with the component installed
  • Flagship devs relay any DS feedback to the DS team (ex: if anything was difficult to work with - tools or process, if anything didn't work as we intended or the Flagship team needs any additional support for the DS team to implement the component.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    HealthTickets are tied to the Health Product Team PmsQA 3QA work sized as a 3benefitsTicket has work related to MHV Benefits Features or Benefit Mobile Features

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions