Skip to content

Discovery: Not all table cells in a tablefield table should be required.  #1171

Open
@swirtSJW

Description

@swirtSJW

Describe the defect

Using the tablefield module, the current setting of the field being required on the paragraph makes it so that no cells can be empty. This should not be the intention of "required". It should count the fact that one or more cell have data should be enough to pass the requirement of being required.

To Reproduce
Steps to reproduce the behavior:

  1. Create or edit an existing "Benefits detail page"
  2. Scroll down to Main Content and add a paragraph table,
  3. Populate all the cells but one.
  4. Save the node
  5. See error that table field can not be empty and behold all the redness.

Expected behavior
As long as one cell is populated, it should count as not empty. Should not have to use the workaround of putting a space in every cell.

Screenshots
image

**Background investigation Done **
It is unrelated to our use of this patch https://www.drupal.org/project/tablefield/issues/3100109 I have removed the patch and get the same behaviour.

Options

Option 1, a workaround that we've already implemented: make table field optional.
Option 2: Patch the module based on this issue that I created https://www.drupal.org/project/tablefield/issues/3117855 Part of that solution may need to incorporate a rework of this ticket too https://www.drupal.org/project/tablefield/issues/3100109 which we created the patch for, but needs some rework.

Acceptance Criteria

  • Determine if there are table cells that are empty and document them

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    All productsCMS managed productCMS TeamCMS Product team that manages both editor exp and devopsDefectSomething isn't working (issue type)Drupal engineeringCMS team practice areaIceboxDeprioritized for nowTechnical debt

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions