Description
Status
[2024-12-06] The PR for this work has unresolved change suggestions, and unit tests are not passing (though that could just be a tugboat issue rather than actual regressions), which means that more dev work will be needed and this isn't a simple case of approving the PR and releasing. Moving it back to Ready to be picked up in future.
[2024-11-26] PR in flight (#19882 ) needs revisions from code review and is failing tests. #19945 has been opened to address the missing required field indicator on other CLP fields. If we decide to take a not-CSS approach for those, we may opt to close the existing PR and address all fields via the same method.
Describe the defect
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
- Go to staging.cms.va.gov (or a Tugboat)
- Create a new Campaign Landing Page
- Fill out the required fields in the sections Hero banner, Why this matters, What you can do, VA Benefits
- Save the node
- Edit the node and click the "enable this page segment" box in the Spotlight section
- Notice that while the first two fields have the red asterisk indicating they are required, there is nothing indicating the List of links with summaries field is required.
- Fill in the Heading and Introduction fields, but do not add a Link teaser to Links with summaries
- Save the node
- Notice the error message at the top of the page. Notice that the link doesn't work
- Scroll down to the Spotlight section and note that there is no error message
- Add a link teaser
- Save the node
AC / Expected behavior
- When creating / editing Campaign Landing Pages, clicking the link 'Links with summaries' that displays in the error message at the top of the page should take the user to the "Links with summaries' section.
- When creating / editing Campaign Landing Pages Required fields should have a red asterisk
- When creating / editing Campaign Landing Pages Fields with validation errors, there should be visual indicators to make them easier to find, along with a validation message indicating the issue.
Additional context
The downloadable resources section has a similar sub field that doesn't have a required asterisk, but does get an validation error message.
The VA gov backend module governs the logic of making this field required, but it doesn't seem to be properly making that visible
Activity