lang attribute on Download button sometimes empty on Form detail pages

[laflannery]

Description

Martha sent this over from the latest AMP scans:

On the Download buttons on form detail pages, sometimes there is an empty lang attribute and it's being flagged in AMP. This is the tool VA looks at to determine their accessibility so it would be good to get this cleaned up.

Examples of pages we found where the lang is empty:

• https://www.va.gov/find-forms/about-form-10-493a/
• https://www.va.gov/find-forms/about-form-21p-10196/

Screenshot:

Pages we found where the lang is en:

• https://www.va.gov/find-forms/about-form-20-10207/
• https://www.va.gov/find-forms/about-form-10-10ez/

Screenshot:

Additional information

• lang didn't used to be required (although it now is).
• This should encompass English, Spanish, and Tagalog
• Kevin Reid confirmed today that the Forms DB does not have a field for form language. So adding form info will be manual data entry in Drupal.

Acceptance criteria

• Download buttons do not have an empty 'lang' attribute
  • Note that the two in the Description are examples and not an exhaustive list
• Accessibility review

[FranECross]

@laflannery Just to confirm, this ticket is just to correct the 'lang' element for the download buttons specifically on the two form detail pages you provided?

[laflannery]

No, those were examples, I had put the necessary AC in the ticket originally:

• Download buttons do not have an empty 'lang' attribute

[jilladams]

@artsymartha68 @laflannery is the Amp report comprehensive of all VA.gov forms pages? If so, could we get a copy that would show us how many pages have this issue?

From refinement:

• Forms DB data does not always include the language on a Form. We can't control that, so sometimes we will not have the data to properly populate this attribute.
• Shamia's take: it's better to have an empty lang attribute than no lang attribute at all.
• We don't know the scale of how many forms don't have an assigned language. That data is in Drupal, but not exposed yet.
  • If Laura / Martha can provide us the AMP report and it's comprehensive, we can tabulate which forms fail this way.
  • If not: we can expose the Language option on the VA Forms drupal audit view (https://prod.cms.va.gov/admin/content/va-forms/audit), and get that data there. (I'd actually prefer this route, cuz it would be useful for future. I'm gonna stub the ticket as a nice to have.)
  • Once we know how many forms are affected, we can reach out to Forms Managers with the list of forms where language isn't populated, to ask them to do so. (This would be an opportunity to also talk to them about standardizing how Spanish / English forms are indicated, in service of [BLOCKED] [SPIKE: Find Form: group English and Spanish variants of the same form in search results #19621 )

[laflannery]

There isn't a way to get this report. I remember meeting with them about this a long time ago and it was complicated. I didn't even 100% understand it at the time but the issue is:

• I typically can run a report for something like /boston-health-care and get a report for everything with that in the URL, so I get all child pages
• I unfortunately can't run a report for /find-forms and then get all child pages. All I get is the main landing page

It's something about this being a search situation if I remember correctly? But ultimately I would have to check every page individually, which means AMP is of no use here.

[jilladams]

Ok - I went ahead and stubbed a ticket to add a filter on the Forms audit view: #20358. Christian took a look and said it's a very light lift, so that should help.