Discrepancy in revision logs on right side bar and Revision tab

[laflannery]

Description

An editor contacted the Help desk (Ticket) because they saw a note in the right hand revision history that they made a change to one of their Stories today (2/6) however that was not correct:

• Story node: https://prod.cms.va.gov/saginaw-health-care/stories/national-salute-to-veteran-patients-february-9-15-2025
• Screen shot of right side bar revision history
  
• However, in the actual revision history tab, there is no record of any change on 2/6:
  

Looking at both logs together, it looks like the 2/6 log on the right somehow changed the date and time accidentally, because there are only 3 revisions and the log messages match up:

Tim noted that the Last saved by editor still says the previous date:

Which is evidence that an automated process could be updating revisions rather than creating new revisions. This, or something similar happened before on Sitewide:

• Ticket explaining the issue on Facilities products
  
• PR to resolve it

Acceptance Criteria

• Determine if an automated process is overwriting Revision logs or is there is another cause of the Discrepancy
• Resolve the issue

[smarithaponnala]

Assigned to Curtis Hayes

[omahane]

I have been able to replicate this error. It happens because we've got this clever bit of code that is too clever by half:

• _va_gov_backend_feature_bump() in docroot/modules/custom/va_gov_backend/va_gov_backend.module

For any node using the field_featured, such as Story and Events, it checks to see if the node being saved has Featured set to true and looks up the the other nodes of the same bundle in the VAMC System that are featured. Then, it sets field_featured on those nodes to false and saves the node. But ... it doesn't seem to know about revisions at all. So it just persists the last revision information into the new revision. As long as we save a new revision and add a relevant revision message from the "CMS Migrator (perhaps)", then the log information would be a lot clearer and accurate.