Skip to content

Update deprecated code in va_gov_migrate Commands.php #20671

Open
@omahane

Description

@omahane

User Story or Problem Statement

According to Drupal:
docroot/core/lib/Drupal/Core/Entity/EntityStorageInterface.php:

/**
   * Delete a specific entity revision.
   *
   * A revision can only be deleted if it's not the currently active one.
   *
   * @param int $revision_id
   *   The revision id.
   *
   * @deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use
   * \Drupal\Core\Entity\RevisionableStorageInterface::deleteRevision instead.
   *
   * @see https://www.drupal.org/node/2926958
   * @see https://www.drupal.org/node/2927226
   * @see https://www.drupal.org/node/3294237
   */
  public function deleteRevision($revision_id);

We are using this function in va_gov_migrate/src/Commands/Commands.php, line 127
$this->entityTypeManager->getStorage('node')->deleteRevision($vid);

Description or Additional Context

It's unclear when we're moving to Drupal 11 or what the plan is for that.

The last time this code was updated was for the Drupal 9 upgrade.

Steps for Implementation

Use the replacement function in the Commands.php file.

Acceptance Criteria

  • va_gov_migrate should not present any issues with an upgrade to Drupal 11 in the Upgrade Status report.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions