Skip to content

Staging Review finding: Link has unnecessary aria-label. #101288

Open
@shiragoodman

Description

@shiragoodman

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Identity
Product: Login
Feature: Guardian Access

Findings details

VA.gov Experience Standard - issue: User encounters components and patterns that meet best practices.
VA.gov Experience Standard - category: Consistency
Launch-blocking: No
Design System review: No
Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

On the sign-in page and modal, the link "The My HealtheVet sign-in option is no loner available" has an aria-label of "The My HealtheVet sign-in option is no longer available."

There's a typo that means there's a mismatch between visible text and what's announced to screen reader users. But even if there wasn't, I don't think the aria-label adds any value here and introduces the potential for future unintended mismatches if/when the page changes later on. Mismatches like that can also pose problems for voice command software users, since many voice tools match against the aria-label rather than the visible text --- so if a sighted voice user speaks what they're reading, they might not be able to follow the link.

Link, screenshot or steps to recreate

Currently coded as:

<va-link text="The My HealtheVet sign-in option is no loner available" label="The My HealtheVet sign-in option is no longer available" href="/" classname="vads-u-margin-top--3" class="hydrated"></va-link>

Recommended action

I think the label prop (which maps to aria-label) can be removed entirely without any negative impact.

References


Next Steps for the VFS Team

How did this touchpoint go? Give feedback on the Collaboration Cycle at any time.

  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members with any questions or to get help validating the issue.
  • Ticket ownership: If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag @platform-governance-team-members on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.
  • Close this ticket when the issue has been resolved or validated by your Product Owner.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions