Fix Rubocop/Layout (#20259)

* Fix Rubocop/Layout

* Codeowners

Author: ryan-mcneil

.github/CODEOWNERS

@@ -1355,6 +1355,9 @@ spec/sidekiq/central_mail/submit_career_counseling_job_spec.rb @department-of-ve
 spec/sidekiq/central_mail/submit_form4142_job_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/central_mail/submit_central_form686c_job_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-dependents-management
 spec/sidekiq/copay_notifications @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/cypress_viewport_updater/cypress_config_js_file_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/cypress_viewport_updater/github_service_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/cypress_viewport_updater/viewport_preset_js_file_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/decision_review @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/education_form @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/education_form/create_daily_spool_files.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/govcio-vfep-codereviewers

.rubocop_todo.yml

@@ -6,52 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLinesAroundExceptionHandlingKeywords:
-  Exclude:
-    - 'spec/controllers/v0/virtual_agent/virtual_agent_claim_spec.rb'
-
-# Offense count: 200
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/LineContinuationSpacing:
-  Exclude:
-    - 'app/controllers/v1/sessions_controller.rb'
-    - 'app/models/in_progress_form.rb'
-    - 'app/sidekiq/cypress_viewport_updater/viewport.rb'
-    - 'app/sidekiq/form1095/new1095_bs_job.rb'
-    - 'app/swagger/swagger/requests/health_care_applications.rb'
-    - 'app/swagger/swagger/requests/profile.rb'
-    - 'app/swagger/swagger/requests/user.rb'
-    - 'lib/evss/disability_compensation_form/data_translation_all_claim.rb'
-    - 'lib/generators/module_component/module_component_generator.rb'
-    - 'modules/appeals_api/app/swagger/appeals_api/v1/notice_of_disagreements_controller_swagger.rb'
-    - 'modules/appeals_api/spec/docs/decision_reviews/higher_level_reviews_spec.rb'
-    - 'modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb'
-    - 'modules/claims_api/app/controllers/concerns/claims_api/poa_verification.rb'
-    - 'modules/claims_api/app/sidekiq/claims_api/poa_vbms_updater.rb'
-    - 'modules/mobile/spec/services/lighthouse_health_service_spec.rb'
-    - 'modules/vba_documents/lib/vba_documents/upload_validator.rb'
-    - 'spec/controllers/v1/sessions_controller_spec.rb'
-    - 'spec/factories/saml_attributes.rb'
-    - 'spec/lib/bgs/form686c_spec.rb'
-    - 'spec/lib/evss/disability_compensation_form/data_translation_all_claim_spec.rb'
-    - 'spec/lib/iam_ssoe_oauth/service_spec.rb'
-    - 'spec/lib/saml/post_url_service_spec.rb'
-    - 'spec/lib/saml/responses/login_spec.rb'
-    - 'spec/lib/saml/ssoe_user_spec.rb'
-    - 'spec/lib/saml/url_service_spec.rb'
-    - 'spec/mailers/direct_deposit_mailer_spec.rb'
-    - 'spec/models/async_transaction/va_profile/base_spec.rb'
-    - 'spec/models/user_session_form_spec.rb'
-    - 'spec/rakelib/vet360_spec.rb'
-    - 'spec/sidekiq/cypress_viewport_updater/cypress_config_js_file_spec.rb'
-    - 'spec/sidekiq/cypress_viewport_updater/github_service_spec.rb'
-    - 'spec/sidekiq/cypress_viewport_updater/viewport_preset_js_file_spec.rb'
-    - 'spec/support/saml/response_builder.rb'
-
 # Offense count: 38
 # This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousOperatorPrecedence:

app/controllers/v1/sessions_controller.rb

@@ -307,10 +307,10 @@ def user_logout(saml_response)
       logout_request = SingleLogoutRequest.find(saml_response&.in_response_to)
       if logout_request.present?
         logout_request.destroy
-        Rails.logger.info("SLO callback response to '#{saml_response&.in_response_to}' for originating_request_id "\
+        Rails.logger.info("SLO callback response to '#{saml_response&.in_response_to}' for originating_request_id " \
                           "'#{originating_request_id}'")
       else
-        Rails.logger.info('SLO callback response could not resolve logout request for originating_request_id '\
+        Rails.logger.info('SLO callback response could not resolve logout request for originating_request_id ' \
                           "'#{originating_request_id}'")
       end
     end

app/models/in_progress_form.rb

@@ -25,13 +25,13 @@ def cast(value)
   scope :submission_pending, -> { where(status: [nil, 'pending']) } # override to include nil
 
   scope :has_attempted_submit, lambda {
-                                 where("(metadata -> 'submission' ->> 'hasAttemptedSubmit')::boolean or "\
+                                 where("(metadata -> 'submission' ->> 'hasAttemptedSubmit')::boolean or " \
                                        "(metadata -> 'submission' ->> 'has_attempted_submit')::boolean")
                                }
   scope :has_errors,           -> { where("(metadata -> 'submission' -> 'errors') IS NOT NULL") }
   scope :has_no_errors,        -> { where.not("(metadata -> 'submission' -> 'errors') IS NOT NULL") }
   scope :has_error_message,    lambda {
-                                 where("(metadata -> 'submission' -> 'errorMessage')::text !='false' or "\
+                                 where("(metadata -> 'submission' -> 'errorMessage')::text !='false' or " \
                                        "(metadata -> 'submission' -> 'error_message')::text !='false' ")
                                }
   # the double quotes in return_url are part of the value

app/sidekiq/cypress_viewport_updater/viewport.rb

@@ -5,20 +5,20 @@ class Viewport
     DEVICES = {
       '1920x1080' => 'Microsoft Windows RT Tablet',
       '1280x720' => 'Microsoft Windows RT Tablet',
-      '1024x1366' => 'iPad Pro (1st gen 12.9"), '\
-                     'iPad Pro (2nd gen 12.9"), '\
+      '1024x1366' => 'iPad Pro (1st gen 12.9"), ' \
+                     'iPad Pro (2nd gen 12.9"), ' \
                      'iPad Pro (3rd gen 12.9"), iPad Pro (4th gen 12.9")',
       '834x1194' => 'iPad Pro (3rd gen 11"), iPad Pro (4th gen 11")',
       '810x1080' => 'iPad 7th gen',
-      '800x1280' => 'Amazon KSFUWI Fire HD 10 (2017), '\
-                    'Amazon KFMAWI Fire HD 10 (2019), '\
-                    'Samsung SM-T580 Galaxy Tab A 10.1, '\
-                    'Samsung SM-T510 Galaxy Tab A 10.1 (2019), '\
+      '800x1280' => 'Amazon KSFUWI Fire HD 10 (2017), ' \
+                    'Amazon KFMAWI Fire HD 10 (2019), ' \
+                    'Samsung SM-T580 Galaxy Tab A 10.1, ' \
+                    'Samsung SM-T510 Galaxy Tab A 10.1 (2019), ' \
                     'Samsung SM-T560NU Galaxy Tab E',
       '768x1024' => 'iPad 1-6, iPad mini, iPad Air 1-2, iPad Pro (1st gen 9.7")',
-      '601x962' => 'Amazon KFGIWI Kindle Fire HD 8 2016, '\
-                   'Amazon KFDOWI Kindle Fire HD 8 (2017), '\
-                   'Amazon KFKAWI Fire HD 8 (2018), '\
+      '601x962' => 'Amazon KFGIWI Kindle Fire HD 8 2016, ' \
+                   'Amazon KFDOWI Kindle Fire HD 8 (2017), ' \
+                   'Amazon KFKAWI Fire HD 8 (2018), ' \
                    'Amazon KFKAWI Fire HD 8 (2018)',
       '428x926' => 'iPhone 12 Pro Max',
       '414x896' => 'iPhone XS Max, iPhone XR, iPhone 11, iPhone 11 Pro Max',
@@ -70,7 +70,7 @@ def device_list(device:, resolution:)
       return 'This property is not set for desktops.' if device == 'desktop'
 
       DEVICES[resolution] ||
-        'This viewport is missing from the devices lookup table. '\
+        'This viewport is missing from the devices lookup table. ' \
         'Please contact the Testing Tools Team to have it added.'
     end
 

app/sidekiq/form1095/new1095_bs_job.rb

@@ -211,7 +211,7 @@ def perform
           Rails.logger.info "Successfully read #{@form_count} 1095B forms from #{file_name}, deleting file from S3"
           bucket.delete_objects(delete: { objects: [{ key: file_name }] })
         else
-          Rails.logger.error  "failed to save #{@error_count} forms from file: #{file_name};"\
+          Rails.logger.error  "failed to save #{@error_count} forms from file: #{file_name};" \
                               " successfully saved #{@form_count} forms"
         end
       end

app/swagger/swagger/requests/health_care_applications.rb

@@ -101,8 +101,8 @@ class HealthCareApplications
 
       swagger_path '/v0/health_care_applications/enrollment_status' do
         operation :get do
-          key :description, 'Check the status of a health care application.'\
-                            ' Non-logged in users must pass query parameters with user attributes.'\
+          key :description, 'Check the status of a health care application.' \
+                            ' Non-logged in users must pass query parameters with user attributes.' \
                             ' No parameters needed for logged in loa3 users.'
           key :operationId, 'enrollmentStatusHealthCareApplication'
           key :tags, %w[benefits_forms]

app/swagger/swagger/requests/profile.rb

@@ -997,11 +997,11 @@ class Profile
         operation :get do
           extend Swagger::Responses::AuthenticationError
 
-          key :description, 'Gets the most recent transactions for a user.'\
-                            ' Response will include an array of transactions that are still in progress,'\
-                            ' or that were just updated to COMPLETED during the course of this request.'\
-                            ' The array will be empty if no transactions are pending or updated.'\
-                            ' Only the most recent transaction for each profile field will be included'\
+          key :description, 'Gets the most recent transactions for a user.' \
+                            ' Response will include an array of transactions that are still in progress,' \
+                            ' or that were just updated to COMPLETED during the course of this request.' \
+                            ' The array will be empty if no transactions are pending or updated.' \
+                            ' Only the most recent transaction for each profile field will be included' \
                             ' so there may be up to 4 (Address, Email, Telephone, Permission).'
           key :operationId, 'getTransactionStatusesByUser'
           key :tags, %w[profile]

app/swagger/swagger/requests/user.rb

@@ -104,9 +104,9 @@ class User
                            type: :string,
                            enum: %w[OK DEACTIVATED MULTIPLE NONE],
                            example: 'OK',
-                           description: 'DEACTIVATED: user has at least one MHV id that is not active; '\
-                                        'NONE: user has no active MHV ids; '\
-                                        'MULTIPLE: user has multiple active MHV ids; '\
+                           description: 'DEACTIVATED: user has at least one MHV id that is not active; ' \
+                                        'NONE: user has no active MHV ids; ' \
+                                        'MULTIPLE: user has multiple active MHV ids; ' \
                                         'OK: user has one MHV id and its active'
                 end
                 property :veteran_status, type: :object do

lib/evss/disability_compensation_form/data_translation_all_claim.rb

@@ -629,7 +629,7 @@ def map_new(input_disability)
           'classificationCode' => input_disability['classificationCode'],
           'disabilityActionType' => 'NEW',
           'specialIssues' => input_disability['specialIssues'].presence,
-          'serviceRelevance' => "Caused by an in-service event, injury, or exposure\n"\
+          'serviceRelevance' => "Caused by an in-service event, injury, or exposure\n" \
                                 "#{input_disability['primaryDescription']}"
         }.compact
       end
@@ -649,7 +649,7 @@ def map_worsened(input_disability)
           'classificationCode' => input_disability['classificationCode'],
           'disabilityActionType' => 'NEW',
           'specialIssues' => input_disability['specialIssues'].presence,
-          'serviceRelevance' => "Worsened because of military service\n"\
+          'serviceRelevance' => "Worsened because of military service\n" \
                                 "#{input_disability['worsenedDescription']}: #{input_disability['worsenedEffects']}"
         }.compact
       end
@@ -670,9 +670,9 @@ def map_va(input_disability)
           'classificationCode' => input_disability['classificationCode'],
           'disabilityActionType' => 'NEW',
           'specialIssues' => input_disability['specialIssues'].presence,
-          'serviceRelevance' => "Caused by VA care\n"\
-                                "Event: #{input_disability['vaMistreatmentDescription']}\n"\
-                                "Location: #{input_disability['vaMistreatmentLocation']}\n"\
+          'serviceRelevance' => "Caused by VA care\n" \
+                                "Event: #{input_disability['vaMistreatmentDescription']}\n" \
+                                "Location: #{input_disability['vaMistreatmentLocation']}\n" \
                                 "TimeFrame: #{input_disability['vaMistreatmentDate']}"
         }.compact
       end
@@ -692,7 +692,7 @@ def map_secondary(input_disability, disabilities)
           'classificationCode' => input_disability['classificationCode'],
           'disabilityActionType' => 'SECONDARY',
           'specialIssues' => input_disability['specialIssues'].presence,
-          'serviceRelevance' => "Caused by a service-connected disability\n"\
+          'serviceRelevance' => "Caused by a service-connected disability\n" \
                                 "#{input_disability['causedByDisabilityDescription']}"
         }.compact
 

lib/generators/module_component/module_component_generator.rb

@@ -32,7 +32,7 @@ def create_component
                  File.join(path, method.pluralize.to_s, file_name, 'v0', 'configuration.rb'), comp_name
       end
     else
-      $stdout.puts "\n#{method} is not a known generator command."\
+      $stdout.puts "\n#{method} is not a known generator command." \
                    "Commands allowed are controller, model, serializer and service\n"
     end
   end

modules/appeals_api/app/swagger/appeals_api/v1/notice_of_disagreements_controller_swagger.rb

@@ -583,7 +583,7 @@ class AppealsApi::V1::NoticeOfDisagreementsControllerSwagger
             property :Message do
               key :type, :string
               key :description, 'Error detail'
-              key :example, 'A client error (InvalidDigest) occurred when calling the PutObject operation -'\
+              key :example, 'A client error (InvalidDigest) occurred when calling the PutObject operation -' \
                             'The Content-MD5 you specified was invalid.'
             end
 

modules/appeals_api/spec/docs/decision_reviews/higher_level_reviews_spec.rb

@@ -164,7 +164,7 @@ def openapi_spec
       tags 'Higher-Level Reviews'
       operationId 'hlrContestableIssues'
       description = 'Returns all issues associated with a Veteran that have been decided by a ' \
-                    'Higher-Level Review as of the receiptDate and bound by benefitType. Not all issues returned are guaranteed '\
+                    'Higher-Level Review as of the receiptDate and bound by benefitType. Not all issues returned are guaranteed ' \
                     'to be eligible for appeal. Associate these results when creating a new Higher-Level Review.'
       description description
       security DocHelpers.decision_reviews_security_config

modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb

@@ -236,21 +236,21 @@ def confinements_dont_overlap?(confinements)
     def validate_form_526_veteran_homelessness!
       if too_many_homelessness_attributes_provided?
         raise ::Common::Exceptions::UnprocessableEntity.new(
-          detail: "Must define only one of 'veteran.homelessness.currentlyHomeless' or "\
+          detail: "Must define only one of 'veteran.homelessness.currentlyHomeless' or " \
                   "'veteran.homelessness.homelessnessRisk'"
         )
       end
 
       if unnecessary_homelessness_point_of_contact_provided?
         raise ::Common::Exceptions::UnprocessableEntity.new(
-          detail: "If 'veteran.homelessness.pointOfContact' is defined, then one of "\
+          detail: "If 'veteran.homelessness.pointOfContact' is defined, then one of " \
                   "'veteran.homelessness.currentlyHomeless' or 'veteran.homelessness.homelessnessRisk' is required"
         )
       end
 
       if missing_point_of_contact?
         raise ::Common::Exceptions::UnprocessableEntity.new(
-          detail: "If one of 'veteran.homelessness.currentlyHomeless' or 'veteran.homelessness.homelessnessRisk' is "\
+          detail: "If one of 'veteran.homelessness.currentlyHomeless' or 'veteran.homelessness.homelessnessRisk' is " \
                   "defined, then 'veteran.homelessness.pointOfContact' is required"
         )
       end
@@ -267,7 +267,7 @@ def validate_service_after_13th_birthday!
       end
       if started_before_age_thirteen
         raise ::Common::Exceptions::UnprocessableEntity.new(
-          detail: "If any 'serviceInformation.servicePeriods.activeDutyBeginDate' is "\
+          detail: "If any 'serviceInformation.servicePeriods.activeDutyBeginDate' is " \
                   "before the Veteran's 13th birthdate: #{age_thirteen}, the claim can not be processed."
         )
       end

modules/claims_api/app/controllers/concerns/claims_api/poa_verification.rb

@@ -43,7 +43,7 @@ def validate_user_is_accredited!
       def validate_poa_code_for_current_user!(poa_code)
         return if valid_poa_code_for_current_user?(poa_code)
 
-        error_msg = 'Veterans making requests do not need to include identifying headers '\
+        error_msg = 'Veterans making requests do not need to include identifying headers ' \
                     "such as 'X-VA-First-Name'. Please resubmit without extraneous headers"
         raise ::Common::Exceptions::UnprocessableEntity.new(detail: error_msg) if target_veteran_is_current_user?
 

modules/claims_api/app/sidekiq/claims_api/poa_vbms_updater.rb

@@ -28,7 +28,7 @@ def perform(power_of_attorney_id) # rubocop:disable Metrics/MethodLength
         poa_form.vbms_error_message = nil if poa_form.vbms_error_message.present?
         ClaimsApi::Logger.log('poa_vbms_updater', poa_id: power_of_attorney_id, detail: 'VBMS Success')
       else
-        poa_form.vbms_error_message = 'update_poa_access failed with code '\
+        poa_form.vbms_error_message = 'update_poa_access failed with code ' \
                                       "#{response[:return_code]}: #{response[:return_message]}"
         poa_form.status = ClaimsApi::PowerOfAttorney::ERRORED
         ClaimsApi::Logger.log('poa_vbms_updater',