stamp signature added for Form 21-0779 (#25582)

* stamp signature added for Form 21-0779

* removing unnecessary mapping

* update PDF deletion through controller

* rspec updates

* update rspec

* feedback updates

---------

Co-authored-by: Calvin Costa <[email protected]>

Author: costacalvin

app/models/saved_claim/form210779.rb

@@ -31,6 +31,12 @@ def send_confirmation_email
     # )
   end
 
+  # Override to_pdf to add nursing home official signature stamp
+  def to_pdf(file_name = nil, fill_options = {})
+    pdf_path = PdfFill::Filler.fill_form(self, file_name, fill_options)
+    PdfFill::Forms::Va210779.stamp_signature(pdf_path, parsed_form)
+  end
+
   def veteran_name
     first = parsed_form.dig('veteranInformation', 'fullName', 'first')
     last = parsed_form.dig('veteranInformation', 'fullName', 'last')

lib/pdf_fill/forms/field_mappings/va210779.rb

@@ -292,7 +292,7 @@ class Va210779
                 type: 'Text'
               }
             },
-            # signature: 'TODO',
+            # NOTE: 'signature' field is not mapped here - it's stamped onto the PDF via stamp_signature method
             signatureDate: {
               month: {
                 key: 'F[0].Page_1[0].Date_Signed_Month[0]',

lib/pdf_fill/forms/va210779.rb

@@ -15,6 +15,13 @@ class Va210779 < FormBase
         'intermediate' => 2
       }.freeze
 
+      # Coordinates for the 21-0779 signature field
+      # Question 20: SIGNATURE OF NURSING HOME OFFICIAL (bottom left of page 1)
+      SIGNATURE_X = 60
+      SIGNATURE_Y = 70
+      SIGNATURE_PAGE = 0 # zero-indexed; 0 == page 1
+      SIGNATURE_SIZE = 10
+
       def merge_fields(_options = {})
         reformat_vet_info
         reformat_claimant_info
@@ -23,6 +30,32 @@ def merge_fields(_options = {})
         @form_data
       end
 
+      # Stamp a typed signature string onto the PDF using DatestampPdf
+      #
+      # @param pdf_path [String] Path to the PDF to stamp
+      # @param form_data [Hash] The form data containing the signature
+      # @return [String] Path to the stamped PDF (or the original path if signature is blank/on failure)
+      def self.stamp_signature(pdf_path, form_data)
+        signature_text = form_data.dig('generalInformation', 'signature')
+
+        return pdf_path if signature_text.nil? || signature_text.to_s.strip.empty?
+
+        PDFUtilities::DatestampPdf.new(pdf_path).run(
+          text: signature_text,
+          x: SIGNATURE_X,
+          y: SIGNATURE_Y,
+          page_number: SIGNATURE_PAGE,
+          size: SIGNATURE_SIZE,
+          text_only: true,
+          timestamp: '',
+          template: pdf_path,
+          multistamp: true
+        )
+      rescue => e
+        Rails.logger.error('Form210779: Error stamping signature', error: e.message, backtrace: e.backtrace)
+        pdf_path # Return original PDF if stamping fails
+      end
+
       def reformat_vet_info
         vet_info = @form_data['veteranInformation']
         return unless vet_info

spec/controllers/v0/form210779_controller_spec.rb

@@ -115,7 +115,8 @@ def confirmation_number
 
   describe 'get #download_pdf' do
     let(:claim) { create(:va210779) }
-    let(:temp_file_path) { "tmp/pdfs/21-0779_#{claim.id}.pdf" }
+    let(:filled_pdf_path) { "tmp/pdfs/21-0779_#{claim.id}.pdf" }
+    let(:stamped_pdf_path) { 'tmp/8607c198992feedf899d78f98e5af856.pdf' }
 
     before do
       allow(Flipper).to receive(:enabled?).with(:form_0779_enabled, nil).and_return(true)
@@ -137,7 +138,11 @@ def confirmation_number
     end
 
     it 'deletes temporary PDF file after sending' do
-      expect(File).to receive(:delete).with(temp_file_path)
+      allow_any_instance_of(SavedClaim::Form210779).to receive(:to_pdf).and_return(stamped_pdf_path)
+      allow(File).to receive(:exist?).and_call_original
+      allow(File).to receive(:exist?).with(stamped_pdf_path).and_return(true)
+      allow(File).to receive(:read).with(stamped_pdf_path).and_return('PDF content')
+      expect(File).to receive(:delete).with(stamped_pdf_path).at_least(:once)
       get(:download_pdf, params: { guid: claim.guid })
     end
 
@@ -153,8 +158,11 @@ def confirmation_number
     end
 
     it 'deletes temporary file even when file read fails' do
-      allow(File).to receive(:read).with(temp_file_path).and_raise(StandardError, 'Read error')
-      expect(File).to receive(:delete).with(temp_file_path)
+      allow_any_instance_of(SavedClaim::Form210779).to receive(:to_pdf).and_return(stamped_pdf_path)
+      allow(File).to receive(:exist?).and_call_original
+      allow(File).to receive(:exist?).with(stamped_pdf_path).and_return(true)
+      allow(File).to receive(:read).with(stamped_pdf_path).and_raise(StandardError, 'Read error')
+      expect(File).to receive(:delete).with(stamped_pdf_path).at_least(:once)
 
       get(:download_pdf, params: { guid: claim.guid })
       expect(response).to have_http_status(:internal_server_error)

spec/lib/pdf_fill/forms/va210779_spec.rb

@@ -11,4 +11,93 @@
     test_data_types: %w[simple],
     run_at: '2025-10-24T18:48:27Z'
   }
+
+  describe '.stamp_signature' do
+    let(:pdf_path) { 'tmp/test_form.pdf' }
+    let(:signature_text) { 'John Doe' }
+    let(:form_data) do
+      {
+        'generalInformation' => {
+          'signature' => signature_text,
+          'nursingOfficialName' => 'Jane Smith'
+        }
+      }
+    end
+
+    before do
+      allow(PDFUtilities::DatestampPdf).to receive(:new).and_return(
+        double(run: 'tmp/stamped.pdf')
+      )
+    end
+
+    context 'with signature in generalInformation.signature' do
+      it 'stamps the signature on the PDF' do
+        expect(PDFUtilities::DatestampPdf).to receive(:new).with(pdf_path).and_return(
+          double(run: 'tmp/stamped.pdf')
+        )
+
+        result = described_class.stamp_signature(pdf_path, form_data)
+        expect(result).to eq('tmp/stamped.pdf')
+      end
+
+      it 'calls DatestampPdf with correct parameters' do
+        datestamp_double = instance_double(PDFUtilities::DatestampPdf)
+        allow(PDFUtilities::DatestampPdf).to receive(:new).with(pdf_path).and_return(datestamp_double)
+
+        expect(datestamp_double).to receive(:run).with(
+          text: signature_text,
+          x: described_class::SIGNATURE_X,
+          y: described_class::SIGNATURE_Y,
+          page_number: described_class::SIGNATURE_PAGE,
+          size: described_class::SIGNATURE_SIZE,
+          text_only: true,
+          timestamp: '',
+          template: pdf_path,
+          multistamp: true
+        ).and_return('tmp/stamped.pdf')
+
+        described_class.stamp_signature(pdf_path, form_data)
+      end
+    end
+
+    context 'with no signature data' do
+      let(:form_data) { { 'generalInformation' => {} } }
+
+      it 'returns the original PDF path without stamping' do
+        expect(PDFUtilities::DatestampPdf).not_to receive(:new)
+        result = described_class.stamp_signature(pdf_path, form_data)
+        expect(result).to eq(pdf_path)
+      end
+    end
+
+    context 'with blank signature' do
+      let(:form_data) do
+        { 'generalInformation' => { 'signature' => '   ' } }
+      end
+
+      it 'returns the original PDF path without stamping' do
+        expect(PDFUtilities::DatestampPdf).not_to receive(:new)
+        result = described_class.stamp_signature(pdf_path, form_data)
+        expect(result).to eq(pdf_path)
+      end
+    end
+
+    context 'when stamping raises an error' do
+      let(:error_message) { 'PDF stamping failed' }
+
+      before do
+        allow(PDFUtilities::DatestampPdf).to receive(:new).and_raise(StandardError, error_message)
+      end
+
+      it 'logs the error and returns the original PDF path' do
+        expect(Rails.logger).to receive(:error).with(
+          'Form210779: Error stamping signature',
+          hash_including(error: error_message)
+        )
+
+        result = described_class.stamp_signature(pdf_path, form_data)
+        expect(result).to eq(pdf_path)
+      end
+    end
+  end
 end

spec/models/saved_claim/form210779_spec.rb

@@ -55,4 +55,47 @@
       claim.process_attachments!
     end
   end
+
+  describe '#to_pdf' do
+    let(:saved_claim) { create(:va210779) }
+    let(:pdf_path) { 'tmp/pdfs/21-0779_test.pdf' }
+    let(:stamped_pdf_path) { 'tmp/pdfs/21-0779_test_stamped.pdf' }
+
+    before do
+      allow(PdfFill::Filler).to receive(:fill_form).and_return(pdf_path)
+      allow(PdfFill::Forms::Va210779).to receive(:stamp_signature).and_return(stamped_pdf_path)
+    end
+
+    it 'generates the PDF using PdfFill::Filler' do
+      expect(PdfFill::Filler).to receive(:fill_form).with(saved_claim, nil, {}).and_return(pdf_path)
+      saved_claim.to_pdf
+    end
+
+    it 'calls stamp_signature with the filled PDF and parsed form data' do
+      expect(PdfFill::Forms::Va210779).to receive(:stamp_signature).with(
+        pdf_path,
+        saved_claim.parsed_form
+      ).and_return(stamped_pdf_path)
+
+      saved_claim.to_pdf
+    end
+
+    it 'returns the stamped PDF path' do
+      result = saved_claim.to_pdf
+      expect(result).to eq(stamped_pdf_path)
+    end
+
+    it 'passes through file_name and fill_options to PdfFill::Filler' do
+      file_name = 'custom_name.pdf'
+      fill_options = { flatten: true }
+
+      expect(PdfFill::Filler).to receive(:fill_form).with(
+        saved_claim,
+        file_name,
+        fill_options
+      ).and_return(pdf_path)
+
+      saved_claim.to_pdf(file_name, fill_options)
+    end
+  end
 end

spec/requests/v0/form210779_spec.rb

@@ -52,7 +52,7 @@
     end
 
     it 'returns 500 when to_pdf returns error' do
-      allow_any_instance_of(SavedClaim).to receive(:to_pdf).and_raise(StandardError, 'PDF generation error')
+      allow_any_instance_of(SavedClaim::Form210779).to receive(:to_pdf).and_raise(StandardError, 'PDF generation error')
 
       metrics = capture_statsd_calls do
         get("/v0/form210779/download_pdf/#{saved_claim.guid}", headers: {