Remove unused Decision Reviews base controllers (#20942)

* AppealsSubmission factory without DecisionReviewV1::Service

* Remove unused base controller

Author: kayline

.github/CODEOWNERS

@@ -24,7 +24,6 @@ README.md @department-of-veterans-affairs/backend-review-group
 .devcontainer @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/cto-engineers
 import-va-certs.sh @department-of-veterans-affairs/backend-review-group
 app/controllers/appeals_base_controller.rb @department-of-veterans-affairs/backend-review-group
-app/controllers/appeals_base_controller_v1.rb @department-of-veterans-affairs/backend-review-group
 app/controllers/application_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/octo-identity
 app/controllers/bb_controller.rb @department-of-veterans-affairs/vfs-vaos @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/claims_base_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group

app/controllers/appeals_base_controller_v1.rb

@@ -11,7 +11,14 @@
     board_review_option { 'evidence_submission' }
     upload_metadata do
       user = User.find(user_uuid)
-      DecisionReviewV1::Service.file_upload_metadata(user)
+      {
+        'veteranFirstName' => user.first_name,
+        'veteranLastName' => user.last_name,
+        'zipCode' => user.postal_code.to_s,
+        'fileNumber' => user.ssn.to_s.strip,
+        'source' => 'va.gov',
+        'businessLine' => 'BVA'
+      }.to_json
     end
   end
 

spec/factories/appeal_submissions.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
-require 'decision_review_v1/service'
 
 RSpec.describe SavedClaim::HigherLevelReview, type: :model do
   subject { described_class.new }

spec/models/saved_claim/higher_level_review_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
-require 'decision_review_v1/service'
 
 RSpec.describe SavedClaim::NoticeOfDisagreement, type: :model do
   subject { described_class.new }

spec/models/saved_claim/notice_of_disagreement_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
-require 'decision_review_v1/service'
 
 RSpec.describe SavedClaim::SupplementalClaim, type: :model do
   subject { described_class.new }

spec/models/saved_claim/supplemental_claim_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
-require 'decision_review_v1/service'
 
 RSpec.describe SecondaryAppealForm, type: :model do
   subject { build(:secondary_appeal_form4142) }