fix MHV user account error body (#20170)

Author: rileyanderson

app/services/mhv/user_account/errors.rb

@@ -28,7 +28,7 @@ def initialize(message, body = nil)
         end
 
         def as_json
-          [{ title: message, detail: body[:message], code: body[:errorCode] }]
+          [{ title: message, detail: body['message'], code: body['errorCode'] }]
         end
       end
     end

spec/controllers/v0/user/mhv_user_accounts_controller_spec.rb

@@ -107,7 +107,7 @@
       end
 
       context 'when there is an MHV client error' do
-        let(:mhv_error_body) { { errorCode: mhv_error_code, message: mhv_error_message } }
+        let(:mhv_error_body) { { 'errorCode' => mhv_error_code, 'message' => mhv_error_message } }
         let(:mhv_error_code) { 'some-code' }
         let(:mhv_error_message) { 'some-error-message' }
 

spec/services/mhv/user_account/creator_spec.rb

@@ -138,13 +138,19 @@
         icn:
       }
     end
+    let(:mhv_error_body) { { 'message' => 'some-message', 'errorCode' => 'some-code' } }
 
     before do
-      allow(mhv_client).to receive(:create_account).and_raise(Common::Client::Errors::ClientError, 'error')
+      allow(mhv_client).to receive(:create_account).and_raise(
+        Common::Client::Errors::ClientError.new('error', 400, mhv_error_body)
+      )
     end
 
-    it 'logs and raises an error' do
-      expect { subject.perform }.to raise_error(MHV::UserAccount::Errors::MHVClientError)
+    it 'logs and raises an error with expected body' do
+      expect { subject.perform }.to raise_error(MHV::UserAccount::Errors::MHVClientError) do |error|
+        expect(error.body).to eq(mhv_error_body)
+      end
+
       expect(Rails.logger).to have_received(:error).with(expected_log_message, expected_log_payload)
     end
   end