Merge branch 'master' of github.com:department-of-veterans-affairs/vets-api into mm/2026-migrate-hca-to-queue-email-job

Author: MarchandMD

.github/CODEOWNERS

@@ -743,6 +743,7 @@ config/form_profile_mappings/21-0538.yml @department-of-veterans-affairs/benefit
 config/form_profile_mappings/21-22.yml @department-of-veterans-affairs/accredited-representative-crew @department-of-veterans-affairs/backend-review-group
 config/form_profile_mappings/21-22A.yml @department-of-veterans-affairs/accredited-representative-crew @department-of-veterans-affairs/backend-review-group
 config/form_profile_mappings/21-2680.yml @department-of-veterans-affairs/benefits-optimization-aquia @department-of-veterans-affairs/backend-review-group
+config/form_profile_mappings/21-4140.yml @department-of-veterans-affairs/benefits-intake-pingwind @department-of-veterans-affairs/backend-review-group
 config/form_profile_mappings/21-526EZ.yml @department-of-veterans-affairs/disability-benefits @department-of-veterans-affairs/backend-review-group
 config/form_profile_mappings/21-686C.yml @department-of-veterans-affairs/disability-benefits @department-of-veterans-affairs/backend-review-group
 config/form_profile_mappings/21-4138.yml @department-of-veterans-affairs/platform-va-product-forms @department-of-veterans-affairs/backend-review-group
@@ -1127,6 +1128,7 @@ lib/search @department-of-veterans-affairs/backend-review-group
 lib/search/pii_redactor.rb @department-of-veterans-affairs/backend-review-group
 lib/search_click_tracking @department-of-veterans-affairs/backend-review-group
 lib/search_gsa @department-of-veterans-affairs/backend-review-group
+lib/semantic_logger/safe_json_formatter.rb @department-of-veterans-affairs/backend-review-group
 lib/sentry @department-of-veterans-affairs/backend-review-group
 lib/sftp_writer @department-of-veterans-affairs/backend-review-group
 lib/shrine @department-of-veterans-affairs/backend-review-group
@@ -1735,6 +1737,7 @@ spec/lib/search @department-of-veterans-affairs/backend-review-group
 spec/lib/search/pii_redactor_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/lib/search_click_tracking @department-of-veterans-affairs/backend-review-group
 spec/lib/search_gsa @department-of-veterans-affairs/backend-review-group
+spec/lib/semantic_logger/safe_json_formatter_spec.rb @department-of-veterans-affairs/backend-review-group
 spec/lib/sentry @department-of-veterans-affairs/backend-review-group
 spec/lib/sftp_writer @department-of-veterans-affairs/backend-review-group
 spec/lib/sftp_writer/factory_spec.rb @department-of-veterans-affairs/backend-review-group
@@ -1848,6 +1851,7 @@ spec/models/form_profiles/va10282_spec.rb @department-of-veterans-affairs/govcio
 spec/models/form_profiles/va10297_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/backend-review-group
 spec/models/form_profiles/va1330m_spec.rb @department-of-veterans-affairs/bah-mbs-selfserv @department-of-veterans-affairs/backend-review-group
 spec/models/form_profiles/va214138_spec.rb @department-of-veterans-affairs/platform-va-product-forms @department-of-veterans-affairs/backend-review-group
+spec/models/form_profiles/va214140_spec.rb @department-of-veterans-affairs/benefits-intake-pingwind @department-of-veterans-affairs/backend-review-group
 spec/models/form_submission_attempt_spec.rb @department-of-veterans-affairs/platform-va-product-forms @department-of-veterans-affairs/disability-benefits @department-of-veterans-affairs/backend-review-group
 spec/models/form_submission_spec.rb @department-of-veterans-affairs/platform-va-product-forms @department-of-veterans-affairs/disability-benefits @department-of-veterans-affairs/backend-review-group
 spec/models/form1010cg @department-of-veterans-affairs/health-apps-backend @department-of-veterans-affairs/backend-review-group

app/controllers/concerns/authentication_and_sso_concerns.rb

@@ -117,7 +117,8 @@ def set_cerner_eligibility_cookie
     }
 
     Rails.logger.info('[SessionsController] Cerner Eligibility', eligible:, previous_value:, cookie_action: :set,
-                                                                 icn: @current_user.icn)
+                                                                 icn: @current_user.icn,
+                                                                 cerner_limited: current_user.cerner_limited?)
   end
 
   def set_session_expiration_header

app/controllers/v0/dependents_applications_controller.rb

@@ -46,7 +46,6 @@ def create # rubocop:disable Metrics/MethodLength
           if claim_info[:proc_state] == 'MANUAL_VAGOV' && claim_info[:participant_id].present?
             user_data = DependentsBenefits::UserData.new(current_user, claim.parsed_form)
             claim.add_veteran_info(JSON.parse(user_data.get_user_json))
-            claim.add_signature_date
 
             submission = submit_via_forms_api(claim, claim_info[:claim_label], claim_info[:participant_id])
 
@@ -88,8 +87,7 @@ def create # rubocop:disable Metrics/MethodLength
     def submit_via_forms_api(claim, claim_label, participant_id)
       digital_forms_api_submission_service ||= DigitalFormsApi::Service::Submissions.new
 
-      payload = claim.parsed_form.deep_dup
-      payload = claim.deep_camelize_keys(payload.merge(payload.delete('dependents_application')))
+      payload = claim.fdf_submission_payload
       metadata = {
         sourceRequestId: claim.guid,
         formId: claim.claim_form_type,

app/controllers/v0/my_va/submission_statuses_controller.rb

@@ -30,7 +30,7 @@ def restricted_list_of_forms
 
       def restricted_benefits_intake_forms
         %w[20-10206 20-10207 21-0845 21-0972 21-10210 21-4142 21-4140 21-4142a 21-4502 21-8940V1 21P-0847 21P-527EZ
-           21P-530EZ 21P-0969 21P-535 21-2680 21-0779 21-4192 21P-530a] + uploadable_forms
+           21P-530EZ 21P-0969 21P-535 21-2680 21-0779 21-4192 21P-530a 21-4138] + uploadable_forms
       end
 
       def decision_reviews_forms_if_enabled

app/models/form_profile.rb

@@ -100,6 +100,7 @@ class FormProfile
             22-5495 22-0993 22-0994 FEEDBACK-TOOL 22-10203 22-1990EZ
             22-10297 22-0803 22-10272 22-10278 22-0976 22-0989 22-0810 22-0839],
     evss: ['21-526EZ'],
+    form214140: ['21-4140'],
     form_mock_ae_design_patterns: ['FORM-MOCK-AE-DESIGN-PATTERNS'],
     form_mock_prefill: ['FORM-MOCK-PREFILL'],
     form_upload: %w[

app/models/form_profiles/va_214140.rb

@@ -6,8 +6,46 @@ class FormProfiles::VA214140 < FormProfile
   def metadata
     {
       version: 0,
-      prefill: true,
+      prefill: prefill_enabled?,
       returnUrl: '/name-and-date-of-birth'
     }
   end
+
+  def prefill_enabled?
+    Flipper.enabled?(:form214140_prefill_enabled)
+  end
+
+  ##
+  # Prefills the form data with identity and contact information
+  #
+  # This method initializes identity and contact information, converts the country code
+  # to ISO2 format if present, and maps data according to form-specific mappings
+  #
+  # @return [Hash]
+  def prefill
+    return { form_data: {}, metadata: } unless prefill_enabled?
+
+    @identity_information = initialize_identity_information
+    @military_information = initialize_military_information
+    @contact_information = initialize_contact_information
+    contact_information.email ||= user.email
+    contact_information.us_phone ||= user&.home_phone&.gsub(/\D/, '')
+
+    mappings = self.class.mappings_for_form(form_id)
+
+    form_data = generate_prefill(mappings) if FormProfile.prefill_enabled_forms.include?(form_id)
+
+    { form_data:, metadata: }
+  end
+
+  ##
+  # Retrieves the VA file number or SSN from BGS
+  #
+  # @return [String]
+  def va_file_number
+    response = BGS::People::Request.new.find_person_by_participant_id(user:)
+    response.file_number.presence || user.ssn.presence
+  rescue => e
+    Rails.logger.warn('Form 21-4140::FormProfile Problem Extracting file_number', { error: e })
+  end
 end

app/services/sign_in/user_loader.rb

@@ -57,10 +57,18 @@ def validate_account_and_session
     end
 
     def set_cerner_eligibility_cookie
-      cookies.permanent[CERNER_ELIGIBLE_COOKIE_NAME] = {
-        value: current_user.cerner_full?,
+      cookie_name = CERNER_ELIGIBLE_COOKIE_NAME
+      previous_value = ActiveModel::Type::Boolean.new.cast(cookies.signed[cookie_name] || cookies[cookie_name])
+      eligible = current_user.cerner_full?
+
+      cookies.permanent[cookie_name] = {
+        value: eligible,
         domain: IdentitySettings.sign_in.info_cookie_domain
       }
+
+      Rails.logger.info('[SignIn][UserLoader] Cerner Eligibility', eligible:, previous_value:, cookie_action: :set,
+                                                                   icn: user_account.icn,
+                                                                   cerner_limited: current_user.cerner_limited?)
     end
 
     def user_attributes

app/sidekiq/event_bus_gateway/letter_ready_email_job.rb

@@ -30,6 +30,7 @@ class LetterReadyEmailJob
                            { job_id:, timestamp:, error_class:, error_message: })
       tags = Constants::DD_TAGS + ["function: #{error_message}"]
       StatsD.increment("#{STATSD_METRIC_PREFIX}.exhausted", tags:)
+      StatsD.increment('silent_failure', tags:)
       Sidekiq::AttrPackage.delete(cache_key) if cache_key
     end
 

app/sidekiq/event_bus_gateway/letter_ready_notification_job.rb

@@ -28,6 +28,7 @@ class LetterReadyNotificationJob
                            { job_id:, timestamp:, error_class:, error_message: })
       tags = Constants::DD_TAGS + ["function: #{error_message}"]
       StatsD.increment("#{STATSD_METRIC_PREFIX}.exhausted", tags:)
+      StatsD.increment('silent_failure', tags:)
     end
 
     def perform(participant_id, email_template_id = nil, push_template_id = nil, sms_template_id = nil) # rubocop:disable Cop/AttrPackageDeleteOnSuccess

app/sidekiq/event_bus_gateway/letter_ready_push_job.rb

@@ -26,6 +26,7 @@ class LetterReadyPushJob
                            { job_id:, timestamp:, error_class:, error_message: })
       tags = Constants::DD_TAGS + ["function: #{error_message}"]
       StatsD.increment("#{STATSD_METRIC_PREFIX}.exhausted", tags:)
+      StatsD.increment('silent_failure', tags:)
       Sidekiq::AttrPackage.delete(cache_key) if cache_key
     end