127042 Digital Dispute error logging (#25444)

Author: digitaldrk

modules/debts_api/app/models/debts_api/v0/digital_dispute_submission.rb

@@ -60,9 +60,11 @@ def store_debt_identifiers(disputes)
 
       def register_failure(message)
         failed!
+        error_message = message.presence ||
+                        "An unknown error occurred while submitting from call_location: #{caller_locations&.first}"
+        Rails.logger.error("DigitalDisputeSubmission error_message: #{error_message}")
         update(
-          error_message: message.presence ||
-            "An unknown error occurred while submitting the form from call_location: #{caller_locations&.first}"
+          error_message:
         )
         begin
           send_failure_email if Settings.vsp_environment == 'production' &&

modules/debts_api/lib/debts_api/v0/digital_dispute_submission_service.rb

@@ -36,6 +36,7 @@ def call
 
         success_result(submission)
       rescue ActiveRecord::RecordInvalid => e
+        Rails.logger.error("DigitalDisputeSubmissionService ActiveRecord error: #{e.message}")
         failure_result(e)
       rescue => e
         submission&.register_failure(e.message)
@@ -96,6 +97,7 @@ def create_submission_record
 
           # Extract and store debt identifiers for duplicate checking
           disputes = @metadata[:disputes] || []
+
           submission.store_debt_identifiers(disputes)
 
           # Store non-PII data in public_metadata

modules/debts_api/spec/lib/debt_api/v0/digital_dispute_submission_service_spec.rb

@@ -159,15 +159,19 @@
 
     context 'when unexpected error occurs' do
       it 'returns generic failure result' do
-        allow_any_instance_of(described_class)
-          .to receive(:validate_files_present)
-          .and_raise(StandardError.new('Unexpected error'))
+        VCR.use_cassette('bgs/people_service/person_data') do
+          allow_any_instance_of(described_class).to receive(:send_to_dmc)
+            .and_raise(StandardError.new('Unexpected error'))
 
-        service = described_class.new(user, [pdf_file_one])
-        result = service.call
+          expect(Rails.logger).to receive(:error).with('DigitalDisputeSubmission error_message: Unexpected error')
 
-        expect(result[:success]).to be false
-        expect(result[:errors][:base]).to include('An error occurred processing your submission')
+          metadata = { disputes: [{ composite_debt_id: 12 }, { composite_debt_id: 34 }, { composite_debt_id: 56 }] }
+          service = described_class.new(user, [pdf_file_one], metadata)
+          result = service.call
+
+          expect(result[:success]).to be false
+          expect(result[:errors][:base]).to include('An error occurred processing your submission')
+        end
       end
     end
 

modules/debts_api/spec/models/debt_api/v0/digital_dispute_submission_spec.rb

@@ -28,7 +28,8 @@
   describe '#register_failure' do
     let(:message) { 'Test error message' }
 
-    it 'saves error message and sets failed state' do
+    it 'saves and logs error message and sets failed state' do
+      expect(Rails.logger).to receive(:error).with('DigitalDisputeSubmission error_message: Test error message')
       form_submission.register_failure(message)
       expect(form_submission.error_message).to eq(message)
       expect(form_submission.failed?).to be(true)