Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Commit 2ad019d

Browse files
Resolved Race Conditions in GitHub PR Labeling (#22129)
* Corrected Github Workflow configuration * github script for labeling * new workflow * pr * ready-for-review * init Check Label workflow * trigger * checkout * code checks check * fix bug * revert backend review code * add labels back * trigger after workflows complete * lint * ready-for-review label * echo workflow * update workflows * test * echo * echo * echo * fix names * rename * test * test * test * test * removed branches * ignore break for now * remove pr * test * relogic * echo * draft * clean * test * ready for review edit * removed backend pr labeler * lint * fixed github output * pr branch * gh run command * refactor ready for review * removed Code Health Report from workflow checks * Remove require-backend-approval in draft mode * reconfig * Syntax clean up * lint * test * test * syntax * test * label ready only if required * test * test * test * pr labels * test * test * test * test * test * test * test * test * handle draft state * test * removed pull_request_review action * code ql to workflow * auth token * github token
1 parent 55864bd commit 2ad019d

9 files changed

Lines changed: 125 additions & 337 deletions

.github/workflows/audit_service_tags.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ jobs:
9393
-c "CI=true DISABLE_BOOTSNAP=true bundle exec rake service_tags:audit_controllers_ci"
9494
9595
- name: Add Failure label
96-
if: failure() && !contains(github.event.pull_request.labels.*.name, 'audit-service-failure')
96+
if: ${{ failure() }}
9797
uses: actions-ecosystem/action-add-labels@v1
9898
with:
9999
fail_on_error: true
@@ -102,7 +102,7 @@ jobs:
102102
audit-service-failure
103103
104104
- name: Remove Failure label
105-
if: success() && contains(github.event.pull_request.labels.*.name, 'audit-service-failure')
105+
if: ${{ success() }}
106106
uses: actions-ecosystem/action-remove-labels@v1
107107
with:
108108
number: ${{ github.event.pull_request.number }}

.github/workflows/backend-pr-approver.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/workflows/backend-pr-labeler.yml

Lines changed: 0 additions & 207 deletions
This file was deleted.

.github/workflows/build-and-publish.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,17 @@ jobs:
6464
aws ecr get-login-password --region us-gov-west-1 | helm registry login --username AWS --password-stdin 008577686731.dkr.ecr.us-gov-west-1.amazonaws.com
6565
helm push vets-api-${{ steps.version.outputs.version }}.tgz oci://008577686731.dkr.ecr.us-gov-west-1.amazonaws.com/dsva/helm
6666
67-
6867
- name: Add Failure label
6968
uses: actions-ecosystem/action-add-labels@v1
70-
if: ${{ github.event_name == 'pull_request' && failure() && !contains(github.event.pull_request.labels.*.name, 'pe-failure') }}
69+
if: ${{ github.event_name == 'pull_request' && failure() }}
7170
with:
7271
number: ${{ github.event.pull_request.number }}
7372
labels: |
7473
pe-failure
7574
7675
- name: Remove Failure label
7776
uses: actions-ecosystem/action-remove-labels@v1
78-
if: ${{ github.event_name == 'pull_request' && success() && contains(github.event.pull_request.labels.*.name, 'pe-failure') }}
77+
if: ${{ github.event_name == 'pull_request' && success() }}
7978
with:
8079
number: ${{ github.event.pull_request.number }}
8180
labels: |

0 commit comments

Comments
 (0)