In 0781, overflow Other reports as separate checkboxes (#22110)

Author: nanotone

lib/pdf_fill/filler.rb

@@ -167,7 +167,9 @@ def process_form(form_id, form_data, form_class, file_name_extension, fill_optio
       if fill_options.fetch(:extras_redesign, false) && submit_date.present?
         file_path = stamp_form(file_path, submit_date)
       end
-      combine_extras(file_path, hash_converter.extras_generator)
+      output = combine_extras(file_path, hash_converter.extras_generator)
+      Rails.logger.info('PdfFill done', fill_options.merge(form_id:, file_name_extension:, extras: output != file_path))
+      output
     end
 
     def make_hash_converter(form_id, form_class, submit_date, fill_options)

lib/pdf_fill/forms/va210781v2.rb

@@ -342,13 +342,14 @@ class Va210781v2 < FormBase
             question_num: 11,
             question_suffix: 'B',
             question_label: 'Other',
-            question_type: 'checklist_group',
             question_text: 'Other Report'
           },
           'otherOverflow' => {
             key: '',
             question_num: 11,
             question_suffix: 'B',
+            question_label: 'Other',
+            question_type: 'checklist_group',
             question_text: 'Other Report'
           }
         },
@@ -716,7 +717,7 @@ def process_reports(extras_redesign: false)
         no_report = false
         police_reports = []
         unlisted_reports = []
-        reports_details = @form_data['reportsDetails'] ||= {}
+        @form_data['reportsDetails'] ||= {}
 
         @form_data['events'].each do |event|
           reports = merge_reports(event)
@@ -738,7 +739,7 @@ def process_reports(extras_redesign: false)
         @form_data['noReportFiled'] = no_report && !report_filed ? 1 : nil
 
         process_police_reports(police_reports, extras_redesign)
-        reports_details['other'] = unlisted_reports.join('; ') unless unlisted_reports.empty?
+        process_unlisted_reports(unlisted_reports, extras_redesign)
       end
 
       def process_police_reports(police_reports, extras_redesign)
@@ -754,6 +755,13 @@ def process_police_reports(police_reports, extras_redesign)
         end
       end
 
+      def process_unlisted_reports(unlisted_reports, extras_redesign)
+        return if unlisted_reports.empty?
+
+        @form_data['reportsDetails']['other'] = unlisted_reports.join('; ')
+        @form_data['reportsDetails']['otherOverflow'] = unlisted_reports if extras_redesign
+      end
+
       def process_treatment_dates
         @form_data['treatmentProvidersDetails']&.each do |item|
           item['noDates'] = item['treatmentMonth'].to_s.strip.empty? && item['treatmentYear'].to_s.strip.empty?

spec/fixtures/pdf_fill/21-0781V2/overflow.json

@@ -29,7 +29,8 @@
       "city": "Dalworthington Gardens",
       "state": "TX",
       "township": "",
-      "country": "USA"
+      "country": "USA",
+      "unlistedReport": "incident report"
     },
     {
       "details": "Mugged",