Travel Pay / Sentence case claim statuses (#21081)

* humanize instead of titleize for sentence case of status; update tests

* update swagger docs

Author: liztownd

app/swagger/swagger/schemas/travel_pay.rb

@@ -17,26 +17,26 @@ class TravelPay
       property :id, type: :string, example: '33333333-5555-4444-bbbb-222222444444'
       property :claimNumber, type: :string, example: 'TC1234123412341234'
       property :claimStatus, type: :string, enum: [
-        'Pre Approved For Payment',
+        'Pre approved for payment',
         'Saved',
-        'In Process',
+        'In process',
         'Pending',
-        'On Hold',
-        'In Manual Review',
-        'Submitted For Payment',
-        'Claim Paid',
+        'On hold',
+        'In manual review',
+        'Submitted for payment',
+        'Claim paid',
         'Incomplete',
         'Appeal',
         'Denied',
-        'Closed With No Payment',
-        'Claim Submitted',
-        'Approved For Payment',
-        'Approved For Payment Incomplete',
-        'Payment Canceled',
-        'Partial Payment',
-        'Fiscal Rescinded',
+        'Closed with no payment',
+        'Claim submitted',
+        'Approved for payment',
+        'Approved for payment incomplete',
+        'Payment canceled',
+        'Partial payment',
+        'Fiscal rescinded',
         'Unspecified'
-      ], example: 'Claim Paid'
+      ], example: 'Claim paid'
       property :appointmentDateTime, type: :string, example: '2024-06-13T13:57:07.291Z'
       property :facilityName, type: :string, example: 'Cheyenne VA Medical Center'
       property :createdOn, type: :string, example: '2024-06-13T13:57:07.291Z'

modules/travel_pay/app/services/travel_pay/claim_association_service.rb

@@ -41,7 +41,7 @@ def associate_appointments_to_claims(params = {})
         raw_claims = faraday_response.body['data'].deep_dup
 
         data = raw_claims&.map do |sc|
-          sc['claimStatus'] = sc['claimStatus'].underscore.titleize
+          sc['claimStatus'] = sc['claimStatus'].underscore.humanize
           sc
         end
 
@@ -67,7 +67,7 @@ def associate_single_appointment_to_claim(params = {})
 
       claim_data = faraday_response.body['data']&.dig(0)
 
-      claim_data['claimStatus'] = claim_data['claimStatus'].underscore.titleize if claim_data
+      claim_data['claimStatus'] = claim_data['claimStatus'].underscore.humanize if claim_data
 
       appt['travelPayClaim'] = {}
       appt['travelPayClaim']['metadata'] = build_metadata(faraday_response.body)

modules/travel_pay/app/services/travel_pay/claims_service.rb

@@ -15,7 +15,7 @@ def get_claims(params = {})
 
       {
         data: claims.map do |sc|
-          sc['claimStatus'] = sc['claimStatus'].underscore.titleize
+          sc['claimStatus'] = sc['claimStatus'].underscore.humanize
           sc
         end
       }
@@ -37,7 +37,7 @@ def get_claims_by_date_range(params = {})
             'message' => faraday_response.body['message']
           },
           data: raw_claims&.map do |sc|
-            sc['claimStatus'] = sc['claimStatus'].underscore.titleize
+            sc['claimStatus'] = sc['claimStatus'].underscore.humanize
             sc
           end
         }
@@ -64,7 +64,7 @@ def get_claim_by_id(claim_id)
       claim = claims.find { |c| c['id'] == claim_id }
 
       if claim
-        claim['claimStatus'] = claim['claimStatus'].underscore.titleize
+        claim['claimStatus'] = claim['claimStatus'].underscore.humanize
         claim
       end
     end

modules/travel_pay/spec/services/claims_association_service_spec.rb

@@ -43,7 +43,7 @@
             'id' => '73611905-71bf-46ed-b1ec-e790593b8565',
             'claimNumber' => 'TC0004',
             'claimName' => '9d81c1a1-cd05-47c6-be97-d14dec579893',
-            'claimStatus' => 'Claim Submitted',
+            'claimStatus' => 'ClaimSubmitted',
             'appointmentDateTime' => nil,
             'facilityName' => 'Tomah VA Medical Center',
             'createdOn' => '2023-12-29T22:00:57.915Z',

modules/travel_pay/spec/services/claims_service_spec.rb

@@ -40,7 +40,7 @@
             'id' => '73611905-71bf-46ed-b1ec-e790593b8565',
             'claimNumber' => 'TC0004',
             'claimName' => '9d81c1a1-cd05-47c6-be97-d14dec579893',
-            'claimStatus' => 'Claim Submitted',
+            'claimStatus' => 'ClaimSubmitted',
             'appointmentDateTime' => nil,
             'facilityName' => 'Tomah VA Medical Center',
             'createdOn' => '2023-12-29T22:00:57.915Z',
@@ -67,7 +67,7 @@
     end
 
     it 'returns sorted and parsed claims' do
-      expected_statuses = ['In Progress', 'In Progress', 'Incomplete', 'Claim Submitted']
+      expected_statuses = ['In progress', 'In progress', 'Incomplete', 'Claim submitted']
 
       claims = @service.get_claims
       actual_statuses = claims[:data].pluck('claimStatus')