Add safety check to new logging (#22425)

* Add safety check to new logging

* Remove user logging from process_attachments method

---------

Co-authored-by: Rachal Cassity <rachal.cassity@oddball.io>

Author: khenson-oddball

app/models/saved_claim/veteran_readiness_employment_claim.rb

@@ -81,7 +81,7 @@ def initialize(args)
 
   def add_claimant_info(user)
     if form.blank?
-      Rails.logger.info('VRE claim form is blank, skipping adding veteran info', { user_uuid: user.uuid })
+      Rails.logger.info('VRE claim form is blank, skipping adding veteran info', { user_uuid: user&.uuid })
       return
     end
 
@@ -132,12 +132,12 @@ def send_to_vre(user)
       upload_to_vbms(user:)
     else
       Rails.logger.warn('Participant id is blank when submitting VRE claim, sending to Lighthouse',
-                        { user_uuid: user.uuid })
+                        { user_uuid: user&.uuid })
       send_to_lighthouse!(user)
     end
 
     email_addr = REGIONAL_OFFICE_EMAILS[@office_location] || 'VRE.VBACO@va.gov'
-    Rails.logger.info('VRE claim sending email:', { email: email_addr, user_uuid: user.uuid })
+    Rails.logger.info('VRE claim sending email:', { email: email_addr, user_uuid: user&.uuid })
     VeteranReadinessEmploymentMailer.build(user.participant_id, email_addr,
                                            @sent_to_lighthouse).deliver_later
 
@@ -170,7 +170,7 @@ def upload_to_vbms(user:, doc_type: '1167')
 
     send_vbms_confirmation_email(user)
   rescue => e
-    Rails.logger.error('Error uploading VRE claim to VBMS.', { user_uuid: user.uuid, messsage: e.message })
+    Rails.logger.error('Error uploading VRE claim to VBMS.', { user_uuid: user&.uuid, messsage: e.message })
     send_to_lighthouse!(user)
   end
 
@@ -191,9 +191,9 @@ def send_to_lighthouse!(user)
 
     unless form_copy['veteranSocialSecurityNumber']
       if user&.loa3?
-        Rails.logger.warn('VRE: No SSN found for LOA3 user', { user_uuid: user.uuid })
+        Rails.logger.warn('VRE: No SSN found for LOA3 user', { user_uuid: user&.uuid })
       else
-        Rails.logger.info('VRE: No SSN found for LOA1 user', { user_uuid: user.uuid })
+        Rails.logger.info('VRE: No SSN found for LOA1 user', { user_uuid: user&.uuid })
       end
     end
 
@@ -214,7 +214,7 @@ def send_to_lighthouse!(user)
   def send_to_res(user)
     Rails.logger.info('VRE claim sending to RES service',
                       {
-                        user_uuid: user.uuid,
+                        user_uuid: user&.uuid,
                         was_sent: @sent_to_lighthouse,
                         user_present: user.present?
                       })
@@ -262,7 +262,7 @@ def regional_office
 
   def send_vbms_confirmation_email(user)
     if user.va_profile_email.blank?
-      Rails.logger.warn('VBMS confirmation email not sent: user missing profile email.', { user_uuid: user.uuid })
+      Rails.logger.warn('VBMS confirmation email not sent: user missing profile email.', { user_uuid: user&.uuid })
       return
     end
 
@@ -279,7 +279,7 @@ def send_vbms_confirmation_email(user)
   def send_lighthouse_confirmation_email(user)
     if user.va_profile_email.blank?
       Rails.logger.warn('Lighthouse confirmation email not sent: user missing profile email.',
-                        { user_uuid: user.uuid })
+                        { user_uuid: user&.uuid })
       return
     end
 
@@ -298,7 +298,7 @@ def process_attachments!
     files = PersistentAttachment.where(guid: refs.map(&:confirmationCode))
     files.find_each { |f| f.update(saved_claim_id: id) }
 
-    Rails.logger.info('VRE claim submitting to Benefits Intake API', { user_uuid: user.uuid })
+    Rails.logger.info('VRE claim submitting to Benefits Intake API')
     Lighthouse::SubmitBenefitsIntakeClaim.new.perform(id)
   end
 
@@ -364,7 +364,7 @@ def veteran_va_file_number(user)
     response = BGS::People::Request.new.find_person_by_participant_id(user:)
     response.file_number
   rescue
-    Rails.logger.warn('VRE claim unable to add VA File Number.', { user_uuid: user.uuid })
+    Rails.logger.warn('VRE claim unable to add VA File Number.', { user_uuid: user&.uuid })
     nil
   end
 

lib/res/ch31_form.rb

@@ -22,7 +22,7 @@ def initialize(user:, claim:)
     #
     def submit
       if @claim.nil?
-        Rails.logger.error('Ch31NilClaimError. user uuid:', @user.uuid)
+        Rails.logger.error('Ch31NilClaimError. user uuid:', @user&.uuid)
         raise Ch31NilClaimError
       end
 

modules/vre/app/models/vre/vre_veteran_readiness_employment_claim.rb

@@ -13,7 +13,7 @@ def initialize(args)
 
     def add_claimant_info(user)
       if form.blank?
-        Rails.logger.info('VRE claim form is blank, skipping adding veteran info', { user_uuid: user.uuid })
+        Rails.logger.info('VRE claim form is blank, skipping adding veteran info', { user_uuid: user&.uuid })
         return
       end
 
@@ -52,12 +52,12 @@ def send_to_vre(user)
         upload_to_vbms(user:)
       else
         Rails.logger.warn('Participant id is blank when submitting VRE claim, sending to Lighthouse',
-                          { user_uuid: user.uuid })
+                          { user_uuid: user&.uuid })
         send_to_lighthouse!(user)
       end
 
       email_addr = Constants::REGIONAL_OFFICE_EMAILS[@office_location] || 'VRE.VBACO@va.gov'
-      Rails.logger.info('VRE claim sending email:', { email: email_addr, user_uuid: user.uuid })
+      Rails.logger.info('VRE claim sending email:', { email: email_addr, user_uuid: user&.uuid })
       VRE::VeteranReadinessEmploymentMailer.build(user.participant_id, email_addr,
                                                   @sent_to_lighthouse).deliver_later
 
@@ -90,7 +90,7 @@ def upload_to_vbms(user:, doc_type: '1167')
 
       send_vbms_confirmation_email(user)
     rescue => e
-      Rails.logger.error('Error uploading VRE claim to VBMS.', { user_uuid: user.uuid, messsage: e.message })
+      Rails.logger.error('Error uploading VRE claim to VBMS.', { user_uuid: user&.uuid, messsage: e.message })
       send_to_lighthouse!(user)
     end
 
@@ -127,7 +127,7 @@ def regional_office
 
     def send_vbms_confirmation_email(user)
       if user.va_profile_email.blank?
-        Rails.logger.warn('VBMS confirmation email not sent: user missing profile email.', { user_uuid: user.uuid })
+        Rails.logger.warn('VBMS confirmation email not sent: user missing profile email.', { user_uuid: user&.uuid })
         return
       end
 
@@ -144,7 +144,7 @@ def send_vbms_confirmation_email(user)
     def send_lighthouse_confirmation_email(user)
       if user.va_profile_email.blank?
         Rails.logger.warn('Lighthouse confirmation email not sent: user missing profile email.',
-                          { user_uuid: user.uuid })
+                          { user_uuid: user&.uuid })
         return
       end
 
@@ -163,7 +163,7 @@ def process_attachments!
       files = ::PersistentAttachment.where(guid: refs.map(&:confirmationCode))
       files.find_each { |f| f.update(saved_claim_id: id) }
 
-      Rails.logger.info('VRE claim submitting to Benefits Intake API', { user_uuid: user.uuid })
+      Rails.logger.info('VRE claim submitting to Benefits Intake API')
       ::Lighthouse::SubmitBenefitsIntakeClaim.new.perform(id)
     end
 
@@ -199,7 +199,7 @@ def send_failure_email(email)
     def send_to_res(user)
       Rails.logger.info('VRE claim sending to RES service',
                         {
-                          user_uuid: user.uuid,
+                          user_uuid: user&.uuid,
                           was_sent: @sent_to_lighthouse,
                           user_present: user.present?
                         })
@@ -252,7 +252,7 @@ def veteran_va_file_number(user)
       response = ::BGS::People::Request.new.find_person_by_participant_id(user:)
       response.file_number
     rescue
-      Rails.logger.warn('VRE claim unable to add VA File Number.', { user_uuid: user.uuid })
+      Rails.logger.warn('VRE claim unable to add VA File Number.', { user_uuid: user&.uuid })
       nil
     end
 

modules/vre/app/services/vre/ch31_form.rb

@@ -23,7 +23,7 @@ def initialize(user:, claim:)
     #
     def submit
       if @claim.nil?
-        Rails.logger.error('Ch31NilClaimError. user uuid:', @user.uuid)
+        Rails.logger.error('Ch31NilClaimError. user uuid:', @user&.uuid)
         raise Ch31NilClaimError
       end