135311: Implement code suggestions

Author: kristen-brown

app/policies/power_of_attorney_policy.rb

@@ -14,9 +14,9 @@ def access?
 
   def log_access_denied
     Rails.logger.info('POA ACCESS DENIED',
-                      loa: user.loa&.dig(:current),
+                      loa_current: user.loa&.dig(:current),
                       loa3: user.loa3?,
-                      icn: user.icn.present?,
-                      participant_id: user.participant_id.present?)
+                      icn_present: user.icn.present?,
+                      participant_id_present: user.participant_id.present?)
   end
 end

spec/policies/power_of_attorney_policy_spec.rb

@@ -10,7 +10,7 @@
       let(:user) { build(:user, :loa3) }
 
       it 'grants access and does not log' do
-        expect(Rails.logger).not_to receive(:info)
+        expect(Rails.logger).not_to receive(:info).with('POA ACCESS DENIED', anything)
         expect(subject).to permit(user, :power_of_attorney)
       end
     end
@@ -22,10 +22,10 @@
         expect(Rails.logger).to receive(:info).with(
           'POA ACCESS DENIED',
           hash_including(
-            loa: 3,
+            loa_current: 3,
             loa3: true,
-            icn: false,
-            participant_id: true
+            icn_present: false,
+            participant_id_present: true
           )
         )
         expect(subject).not_to permit(user, :power_of_attorney)
@@ -39,10 +39,10 @@
         expect(Rails.logger).to receive(:info).with(
           'POA ACCESS DENIED',
           hash_including(
-            loa: 3,
+            loa_current: 3,
             loa3: true,
-            icn: true,
-            participant_id: false
+            icn_present: true,
+            participant_id_present: false
           )
         )
         expect(subject).not_to permit(user, :power_of_attorney)
@@ -56,10 +56,10 @@
         expect(Rails.logger).to receive(:info).with(
           'POA ACCESS DENIED',
           hash_including(
-            loa: 1,
+            loa_current: 1,
             loa3: false,
-            icn: true,
-            participant_id: false
+            icn_present: true,
+            participant_id_present: false
           )
         )
         expect(subject).not_to permit(user, :power_of_attorney)