Send 20-10207 emails to point of contact, when necessary (#21575)

* Send 20-10207 emails to point of contact, when necessary

* test coverage

* progress

* test

* Add test

---------

Co-authored-by: stevenjcumming <134282106+stevenjcumming@users.noreply.github.com>

Author: Thrillberg

modules/simple_forms_api/app/models/simple_forms_api/base_form.rb

@@ -20,5 +20,9 @@ def notification_first_name
     def notification_email_address
       data.dig('veteran', 'email')
     end
+
+    def should_send_to_point_of_contact?
+      false
+    end
   end
 end

modules/simple_forms_api/app/models/simple_forms_api/vba_20_10207.rb

@@ -73,7 +73,19 @@ def notification_first_name
       end
     end
 
+    def notification_last_name
+      if data['preparer_type'] == 'veteran'
+        data.dig('veteran_full_name', 'last')
+      elsif data['preparer_type'] == 'non-veteran'
+        data.dig('non_veteran_full_name', 'last')
+      else
+        data.dig('third_party_full_name', 'last')
+      end
+    end
+
     def notification_email_address
+      return data['point_of_contact_email'] if should_send_to_point_of_contact?
+
       if data['preparer_type'] == 'veteran'
         data['veteran_email_address']
       elsif data['preparer_type'] == 'non-veteran'
@@ -83,6 +95,10 @@ def notification_email_address
       end
     end
 
+    def notification_point_of_contact_name
+      data['point_of_contact_name']
+    end
+
     def zip_code_is_us_based
       @data.dig('veteran_mailing_address', 'country') == 'USA' ||
         @data.dig('non_veteran_mailing_address', 'country') == 'USA'
@@ -133,6 +149,10 @@ def get_attachments
       PersistentAttachment.where(guid: attachment_guids).map(&:to_pdf)
     end
 
+    def should_send_to_point_of_contact?
+      preparer_is_not_third_party? && living_situation_is_none?
+    end
+
     private
 
     def attachment_guids
@@ -196,5 +216,13 @@ def non_veteran_phone
         data['non_veteran_phone']&.gsub('-', '')&.[](6..9)
       ]
     end
+
+    def preparer_is_not_third_party?
+      %w[third-party-veteran third-party-non-veteran].exclude?(data['preparer_type'])
+    end
+
+    def living_situation_is_none?
+      data.dig('living_situation', 'NONE')
+    end
   end
 end

modules/simple_forms_api/app/services/simple_forms_api/notification/email.rb

@@ -30,9 +30,6 @@ def initialize(config, notification_type: :confirmation, user: nil, user_account
 
       def send(at: nil)
         return unless flipper?
-
-        template_id_suffix = TEMPLATE_IDS[form_number][notification_type.to_s]
-        template_id = Settings.vanotify.services.va_gov.template_id[template_id_suffix]
         return unless template_id
 
         scheduled_at = at
@@ -86,6 +83,14 @@ def flipper?
         Flipper.enabled?(:"form#{number.gsub('vba_', '')}_confirmation_email")
       end
 
+      def template_id
+        template_id_suffix = TEMPLATE_IDS[form_number][notification_type.to_s]
+        if form.should_send_to_point_of_contact?
+          template_id_suffix = TEMPLATE_IDS['vba_20_10207']['point_of_contact_error']
+        end
+        @_template_id ||= Settings.vanotify.services.va_gov.template_id[template_id_suffix]
+      end
+
       def enqueue_email(at, template_id)
         email_from_form_data = form.notification_email_address
 

modules/simple_forms_api/app/services/simple_forms_api/notification/personalization.rb

@@ -23,6 +23,13 @@ def to_hash
             personalization['lighthouse_updated_at'] = lighthouse_updated_at if lighthouse_updated_at
             personalization['confirmation_number'] = confirmation_number if confirmation_number
             personalization.merge!(form21_0966_personalization) if form.instance_of? SimpleFormsApi::VBA210966
+
+            if form.should_send_to_point_of_contact?
+              personalization.merge!(
+                'poc_first_name_last_name' => form.notification_point_of_contact_name,
+                'last_name' => form.notification_last_name
+              )
+            end
           end
         end
       end

modules/simple_forms_api/spec/models/base_form_spec.rb

@@ -23,4 +23,10 @@
       expect(described_class.new(data).notification_email_address).to eq 'a@b.com'
     end
   end
+
+  describe '#should_send_to_point_of_contact?' do
+    it 'returns false' do
+      expect(described_class.new({}).should_send_to_point_of_contact?).to be false
+    end
+  end
 end

modules/simple_forms_api/spec/models/vba_20_10207_spec.rb

@@ -3,6 +3,25 @@
 require 'rails_helper'
 require_relative '../support/shared_examples_for_base_form'
 
+RSpec.shared_examples 'point_of_contact_email' do
+  context 'should use point of contact email' do
+    let(:email) { 'pointy@contact.com' }
+
+    before do
+      data.merge!(
+        {
+          'living_situation' => { 'NONE' => true },
+          'point_of_contact_email' => email
+        }
+      )
+    end
+
+    it 'returns the point of contact email' do
+      expect(described_class.new(data).notification_email_address).to eq email
+    end
+  end
+end
+
 RSpec.describe SimpleFormsApi::VBA2010207 do
   it_behaves_like 'zip_code_is_us_based', %w[veteran_mailing_address non_veteran_mailing_address]
 
@@ -141,6 +160,56 @@
     end
   end
 
+  describe '#notification_last_name' do
+    context 'preparer is veteran' do
+      let(:data) do
+        {
+          'preparer_type' => 'veteran',
+          'veteran_full_name' => {
+            'first' => 'Veteran',
+            'last' => 'Eteranvay'
+          }
+        }
+      end
+
+      it 'returns the veteran last name' do
+        expect(described_class.new(data).notification_last_name).to eq 'Eteranvay'
+      end
+    end
+
+    context 'preparer is non-veteran' do
+      let(:data) do
+        {
+          'preparer_type' => 'non-veteran',
+          'non_veteran_full_name' => {
+            'first' => 'Non-Veteran',
+            'last' => 'Eteranvay'
+          }
+        }
+      end
+
+      it 'returns the non-veteran last name' do
+        expect(described_class.new(data).notification_last_name).to eq 'Eteranvay'
+      end
+    end
+
+    context 'preparer is third party' do
+      let(:data) do
+        {
+          'preparer_type' => 'third-party',
+          'third_party_full_name' => {
+            'first' => 'Third Party',
+            'last' => 'Eteranvay'
+          }
+        }
+      end
+
+      it 'returns the third party last name' do
+        expect(described_class.new(data).notification_last_name).to eq 'Eteranvay'
+      end
+    end
+  end
+
   describe '#notification_email_address' do
     context 'preparer is veteran' do
       let(:data) do
@@ -153,6 +222,8 @@
       it 'returns the veteran email address' do
         expect(described_class.new(data).notification_email_address).to eq 'a@b.com'
       end
+
+      it_behaves_like 'point_of_contact_email'
     end
 
     context 'preparer is non-veteran' do
@@ -166,6 +237,8 @@
       it 'returns the non-veteran email address' do
         expect(described_class.new(data).notification_email_address).to eq 'a@b.com'
       end
+
+      it_behaves_like 'point_of_contact_email'
     end
 
     context 'preparer is third party' do
@@ -181,4 +254,63 @@
       end
     end
   end
+
+  describe '#notification_point_of_contact_name' do
+    let(:name) { 'Pointy Contact' }
+    let(:data) do
+      { 'point_of_contact_name' => name }
+    end
+
+    it 'returns the point of contact name' do
+      expect(described_class.new(data).notification_point_of_contact_name).to eq name
+    end
+  end
+
+  describe '#should_send_to_point_of_contact?' do
+    let(:data) { {} }
+
+    context 'preparer is not third party' do
+      %w[veteran non-veteran].each do |preparer_type|
+        before { data['preparer_type'] = preparer_type }
+
+        context 'living situation is NONE' do
+          before { data['living_situation'] = { 'NONE' => true } }
+
+          it 'returns true' do
+            expect(described_class.new(data).should_send_to_point_of_contact?).to be true
+          end
+        end
+
+        context 'living situation is not NONE' do
+          before { data['living_situation'] = { 'NONE' => false } }
+
+          it 'returns false' do
+            expect(described_class.new(data).should_send_to_point_of_contact?).to be false
+          end
+        end
+      end
+    end
+
+    context 'preparer is third party' do
+      %w[third-party-non-veteran third-party-veteran].each do |preparer_type|
+        before { data['preparer_type'] = preparer_type }
+
+        context 'living situation is NONE' do
+          before { data['living_situation'] = { 'NONE' => true } }
+
+          it 'returns false' do
+            expect(described_class.new(data).should_send_to_point_of_contact?).to be false
+          end
+        end
+
+        context 'living situation is not NONE' do
+          before { data['living_situation'] = { 'NONE' => false } }
+
+          it 'returns false' do
+            expect(described_class.new(data).should_send_to_point_of_contact?).to be false
+          end
+        end
+      end
+    end
+  end
 end

modules/simple_forms_api/spec/services/notification/email_spec.rb

@@ -132,11 +132,16 @@
           before do
             stub_const(
               'SimpleFormsApi::Notification::Email::TEMPLATE_IDS',
-              { 'vba_21_10210' => {
-                'confirmation' => template_id_suffix,
-                'error' => template_id_suffix,
-                'received' => template_id_suffix
-              } }
+              {
+                'vba_21_10210' => {
+                  'confirmation' => template_id_suffix,
+                  'error' => template_id_suffix,
+                  'received' => template_id_suffix
+                },
+                'vba_20_10207' => {
+                  'point_of_contact_error' => template_id_suffix
+                }
+              }
             )
             allow(Settings).to receive(:vanotify).and_return(vanotify_settings)
             allow(vanotify_settings).to receive(:services).and_return(vanotify_services)
@@ -152,6 +157,39 @@
 
             expect(VANotify::EmailJob).to have_received(:perform_async).with(anything, template_id, anything)
           end
+
+          describe 'form 20-10207 point of contact', if: notification_type == :error do
+            before { config[:form_number] = 'vba_20_10207' }
+
+            context 'data includes point of contact email' do
+              let(:point_of_contact_email) { 'a@b.com' }
+              let(:data) do
+                fixture_path = Rails.root.join(
+                  'modules', 'simple_forms_api', 'spec', 'fixtures', 'form_json', 'vba_20_10207.json'
+                )
+                data = JSON.parse(fixture_path.read)
+                data.merge!(
+                  {
+                    'point_of_contact_email' => point_of_contact_email,
+                    'living_situation' => { 'NONE' => true }
+                  }
+                )
+              end
+
+              it 'sends the email to the point of contact email' do
+                allow(VANotify::EmailJob).to receive(:perform_async)
+                subject = described_class.new(config, notification_type:)
+
+                subject.send
+
+                expect(VANotify::EmailJob).to have_received(:perform_async).with(
+                  point_of_contact_email,
+                  template_id,
+                  anything
+                )
+              end
+            end
+          end
         end
 
         context 'success' do

modules/simple_forms_api/spec/services/notification/personalization_spec.rb

@@ -31,6 +31,32 @@
       end
     end
 
+    context 'should send to point of contact' do
+      let(:form) do
+        SimpleFormsApi::VBA2010207.new(
+          {
+            'veteran_full_name' => { 'first' => 'John', 'last' => 'Doe' },
+            'preparer_type' => 'veteran',
+            'living_situation' => { 'NONE' => true },
+            'point_of_contact_name' => 'Pointy McContact'
+          }
+        )
+      end
+
+      it 'returns a hash with point of contact fields' do
+        personalization = described_class.new(form:, config:)
+
+        expect(personalization.to_hash).to eq(
+          {
+            'first_name' => 'John',
+            'last_name' => 'Doe',
+            'date_submitted' => date_submitted,
+            'poc_first_name_last_name' => 'Pointy McContact'
+          }
+        )
+      end
+    end
+
     context 'other forms' do
       let(:form) { SimpleFormsApi::VBA2010206.new({ 'full_name' => { 'first' => 'john' } }) }