Change key to match fe4138 (#27501)

* change method to use email function

* add tests

* update the fixture

Author: dominicpadula1

modules/simple_forms_api/app/models/simple_forms_api/vba_21_4138.rb

@@ -92,7 +92,7 @@ def notification_first_name
     end
 
     def notification_email_address
-      data['email_address']
+      veteran_email
     end
 
     def zip_code_is_us_based

modules/simple_forms_api/spec/fixtures/form_json/vba_21_4138.json

@@ -6,7 +6,11 @@
     "last": "Veteran"
   },
   "date_of_birth": "1980-01-01",
-  "email_address": "john.veteran@captainsparkles.net",
+  "veteran": {
+  "email": {
+    "email_address": "john.veteran@captainsparkles.net"
+    }
+  },
   "id_number": {
     "ssn": "321540987",
     "va_file_number": "12345678"

modules/simple_forms_api/spec/models/vba_21_4138_spec.rb

@@ -388,10 +388,29 @@
   end
 
   describe '#notification_email_address' do
-    let(:data) { { 'email_address' => 'john@example.com' } }
+    context 'when the veteran is filing' do
+      it 'returns email from the nested veteran object' do
+        data = { 'claimant_type' => 'self', 'veteran' => { 'email' => { 'email_address' => 'veteran@example.com' } } }
+        expect(described_class.new(data).notification_email_address).to eq('veteran@example.com')
+      end
+
+      it 'returns veteran_email_address when nested veteran email is absent' do
+        data = { 'claimant_type' => 'self', 'veteran_email_address' => 'veteran@example.com' }
+        expect(described_class.new(data).notification_email_address).to eq('veteran@example.com')
+      end
+    end
 
-    it 'returns the email address' do
-      expect(described_class.new(data).notification_email_address).to eq('john@example.com')
+    context 'when a non-veteran claimant is filing' do
+      it 'returns veteran_email_address' do
+        data = { 'claimant_type' => 'forVeteran', 'veteran_email_address' => 'veteran@example.com' }
+        expect(described_class.new(data).notification_email_address).to eq('veteran@example.com')
+      end
+    end
+
+    context 'when no email is present' do
+      it 'returns nil' do
+        expect(described_class.new({}).notification_email_address).to be_nil
+      end
     end
   end