feat: re-add appoint search acceptance mode and reps_can_accept_any_r… (#27186)

* feat: re-add appoint search acceptance mode and reps_can_accept_any_request

* fix: set explicit serializer type/id and resolve N+1 in OrganizationWithRepContext

---------

Co-authored-by: Patrick Brown <patrick.brown@oddball.io>
Co-authored-by: Josh Fike <josh.fike@oddball.io>

Author: 3 people

modules/representation_management/app/controllers/representation_management/v0/original_entities_controller.rb

@@ -9,11 +9,19 @@ class OriginalEntitiesController < ApplicationController
 
       def index
         data = RepresentationManagement::OriginalEntityQuery.new(params[:query]).results
+        orgs = data.select { |r| r.is_a?(Veteran::Service::Organization) }
+        any_request_poas = if Flipper.enabled?(:accredited_representative_portal_individual_accept) && orgs.any?
+                             RepresentationManagement::OrganizationWithAcceptanceCheck.any_request_poas_for(orgs)
+                           else
+                             Set.new
+                           end
+
         json_response = data.map do |record|
           if record.is_a?(Veteran::Service::Representative)
             RepresentationManagement::OriginalEntities::RepresentativeSerializer.new(record).serializable_hash
           elsif record.is_a?(Veteran::Service::Organization)
-            RepresentationManagement::OriginalEntities::OrganizationSerializer.new(record).serializable_hash
+            org = RepresentationManagement::OrganizationWithAcceptanceCheck.new(record, any_request_poas:)
+            RepresentationManagement::OriginalEntities::OrganizationSerializer.new(org).serializable_hash
           end
         end
         render json: json_response

modules/representation_management/app/models/representation_management/organization_with_acceptance_check.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module RepresentationManagement
+  class OrganizationWithAcceptanceCheck < SimpleDelegator
+    def initialize(organization, any_request_poas:)
+      super(organization)
+      @any_request_poas = any_request_poas
+    end
+
+    def reps_can_accept_any_request
+      @any_request_poas.include?(__getobj__.poa)
+    end
+
+    def self.any_request_poas_for(organizations)
+      poas = organizations.map(&:poa)
+      Veteran::Service::OrganizationRepresentative.active
+                                                  .where(organization_poa: poas, acceptance_mode: 'any_request')
+                                                  .distinct
+                                                  .pluck(:organization_poa)
+                                                  .to_set
+    end
+  end
+end

modules/representation_management/app/models/representation_management/organization_with_rep_context.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module RepresentationManagement
+  class OrganizationWithRepContext < SimpleDelegator
+    def initialize(organization, accepting_poas:)
+      super(organization)
+      @accepting_poas = accepting_poas
+    end
+
+    def can_accept_digital_poa_requests
+      return false unless __getobj__.can_accept_digital_poa_requests
+
+      @accepting_poas.include?(__getobj__.poa)
+    end
+
+    def self.accepting_poas_for(representative)
+      Veteran::Service::OrganizationRepresentative.active
+                                                  .where(representative_id: representative.representative_id)
+                                                  .where.not(acceptance_mode: 'no_acceptance')
+                                                  .pluck(:organization_poa)
+                                                  .to_set
+    end
+  end
+end

modules/representation_management/app/serializers/representation_management/original_entities/organization_serializer.rb

@@ -5,9 +5,13 @@ module OriginalEntities
     class OrganizationSerializer
       include JSONAPI::Serializer
 
+      set_type :organization
+      set_id :poa
+
       attributes :name, :address_line1, :address_line2, :address_line3, :address_type,
                  :city, :country_name, :country_code_iso3, :province, :international_postal_code, :state_code,
-                 :zip_code, :zip_suffix, :phone, :lat, :long, :can_accept_digital_poa_requests
+                 :zip_code, :zip_suffix, :phone, :lat, :long, :can_accept_digital_poa_requests,
+                 :reps_can_accept_any_request
       attribute :poa_code, &:poa
     end
   end

modules/representation_management/app/serializers/representation_management/original_entities/representative_organization_serializer.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module RepresentationManagement
+  module OriginalEntities
+    class RepresentativeOrganizationSerializer
+      include JSONAPI::Serializer
+
+      set_type :organization
+      set_id :poa
+
+      attributes :name, :address_line1, :address_line2, :address_line3, :address_type,
+                 :city, :country_name, :country_code_iso3, :province, :international_postal_code, :state_code,
+                 :zip_code, :zip_suffix, :phone, :lat, :long, :can_accept_digital_poa_requests
+      attribute :poa_code, &:poa
+    end
+  end
+end

modules/representation_management/app/serializers/representation_management/original_entities/representative_serializer.rb

@@ -18,7 +18,15 @@ class RepresentativeSerializer
       end
 
       attribute :accredited_organizations do |object|
-        RepresentationManagement::OriginalEntities::OrganizationSerializer.new(object.organizations)
+        orgs = if Flipper.enabled?(:accredited_representative_portal_individual_accept)
+                 accepting_poas = RepresentationManagement::OrganizationWithRepContext.accepting_poas_for(object)
+                 object.organizations.map do |org|
+                   RepresentationManagement::OrganizationWithRepContext.new(org, accepting_poas:)
+                 end
+               else
+                 object.organizations
+               end
+        RepresentationManagement::OriginalEntities::RepresentativeOrganizationSerializer.new(orgs)
       end
     end
   end

modules/representation_management/spec/models/representation_management/organization_with_acceptance_check_spec.rb

@@ -0,0 +1,117 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe RepresentationManagement::OrganizationWithAcceptanceCheck do
+  subject { described_class.new(organization, any_request_poas:) }
+
+  let(:organization) { create(:organization, poa: 'ABC', can_accept_digital_poa_requests: true) }
+  let(:any_request_poas) { described_class.any_request_poas_for([organization]) }
+
+  describe '#can_accept_digital_poa_requests' do
+    it 'delegates to the underlying organization' do
+      expect(subject.can_accept_digital_poa_requests).to eq(organization.can_accept_digital_poa_requests)
+    end
+  end
+
+  describe '#reps_can_accept_any_request' do
+    let(:representative) { create(:representative, representative_id: '12345') }
+
+    context 'when an active organization_representative has acceptance_mode any_request' do
+      before do
+        create(:veteran_organization_representative,
+               representative:,
+               organization:,
+               acceptance_mode: 'any_request')
+      end
+
+      it 'returns true' do
+        expect(subject.reps_can_accept_any_request).to be true
+      end
+    end
+
+    context 'when an active organization_representative has acceptance_mode self_only' do
+      before do
+        create(:veteran_organization_representative,
+               representative:,
+               organization:,
+               acceptance_mode: 'self_only')
+      end
+
+      it 'returns false' do
+        expect(subject.reps_can_accept_any_request).to be false
+      end
+    end
+
+    context 'when no organization_representative records exist' do
+      it 'returns false' do
+        expect(subject.reps_can_accept_any_request).to be false
+      end
+    end
+
+    context 'when the only any_request organization_representative is deactivated' do
+      before do
+        create(:veteran_organization_representative,
+               representative:,
+               organization:,
+               acceptance_mode: 'any_request',
+               deactivated_at: Time.current)
+      end
+
+      it 'returns false' do
+        expect(subject.reps_can_accept_any_request).to be false
+      end
+    end
+  end
+
+  describe '.any_request_poas_for' do
+    let(:representative) { create(:representative, representative_id: '12345') }
+
+    it 'returns a set of POAs with active any_request reps' do
+      create(:veteran_organization_representative,
+             representative:,
+             organization:,
+             acceptance_mode: 'any_request')
+
+      result = described_class.any_request_poas_for([organization])
+      expect(result).to be_a(Set)
+      expect(result).to include('ABC')
+    end
+
+    it 'excludes self_only reps' do
+      create(:veteran_organization_representative,
+             representative:,
+             organization:,
+             acceptance_mode: 'self_only')
+
+      result = described_class.any_request_poas_for([organization])
+      expect(result).not_to include('ABC')
+    end
+
+    it 'excludes no_acceptance reps' do
+      create(:veteran_organization_representative,
+             representative:,
+             organization:,
+             acceptance_mode: 'no_acceptance')
+
+      result = described_class.any_request_poas_for([organization])
+      expect(result).not_to include('ABC')
+    end
+
+    it 'excludes deactivated reps' do
+      create(:veteran_organization_representative,
+             representative:,
+             organization:,
+             acceptance_mode: 'any_request',
+             deactivated_at: Time.current)
+
+      result = described_class.any_request_poas_for([organization])
+      expect(result).not_to include('ABC')
+    end
+  end
+
+  it 'delegates other methods to the organization' do
+    expect(subject.poa).to eq('ABC')
+    expect(subject.name).to eq(organization.name)
+  end
+end

modules/representation_management/spec/models/representation_management/organization_with_rep_context_spec.rb

@@ -0,0 +1,135 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe RepresentationManagement::OrganizationWithRepContext do
+  subject { described_class.new(organization, accepting_poas:) }
+
+  let(:organization) { create(:organization, poa: 'ABC', can_accept_digital_poa_requests: true) }
+  let(:representative) { create(:representative, representative_id: '12345') }
+  let(:accepting_poas) { described_class.accepting_poas_for(representative) }
+
+  describe '#can_accept_digital_poa_requests' do
+    context 'when the organization cannot accept digital POA requests' do
+      let(:organization) { create(:organization, poa: 'ABC', can_accept_digital_poa_requests: false) }
+
+      it 'returns false' do
+        expect(subject.can_accept_digital_poa_requests).to be false
+      end
+    end
+
+    context 'when the organization can accept digital POA requests' do
+      context 'when no organization_representative record exists' do
+        it 'returns false' do
+          expect(subject.can_accept_digital_poa_requests).to be false
+        end
+      end
+
+      context 'when the organization_representative has acceptance_mode any_request' do
+        before do
+          create(:veteran_organization_representative,
+                 representative:,
+                 organization:,
+                 acceptance_mode: 'any_request')
+        end
+
+        it 'returns true' do
+          expect(subject.can_accept_digital_poa_requests).to be true
+        end
+      end
+
+      context 'when the organization_representative has acceptance_mode self_only' do
+        before do
+          create(:veteran_organization_representative,
+                 representative:,
+                 organization:,
+                 acceptance_mode: 'self_only')
+        end
+
+        it 'returns true' do
+          expect(subject.can_accept_digital_poa_requests).to be true
+        end
+      end
+
+      context 'when the organization_representative has acceptance_mode no_acceptance' do
+        before do
+          create(:veteran_organization_representative,
+                 representative:,
+                 organization:,
+                 acceptance_mode: 'no_acceptance')
+        end
+
+        it 'returns false' do
+          expect(subject.can_accept_digital_poa_requests).to be false
+        end
+      end
+
+      context 'when a different rep has an active any_request record for the same org' do
+        before do
+          other_rep = create(:representative, representative_id: '99999')
+          create(:veteran_organization_representative,
+                 representative: other_rep,
+                 organization:,
+                 acceptance_mode: 'any_request')
+        end
+
+        it 'returns false' do
+          expect(subject.can_accept_digital_poa_requests).to be false
+        end
+      end
+
+      context 'when the organization_representative is deactivated' do
+        before do
+          create(:veteran_organization_representative,
+                 representative:,
+                 organization:,
+                 acceptance_mode: 'any_request',
+                 deactivated_at: Time.current)
+        end
+
+        it 'returns false' do
+          expect(subject.can_accept_digital_poa_requests).to be false
+        end
+      end
+    end
+  end
+
+  describe '.accepting_poas_for' do
+    it 'returns a set of POAs with active non-no_acceptance reps' do
+      create(:veteran_organization_representative,
+             representative:,
+             organization:,
+             acceptance_mode: 'any_request')
+
+      result = described_class.accepting_poas_for(representative)
+      expect(result).to be_a(Set)
+      expect(result).to include('ABC')
+    end
+
+    it 'excludes no_acceptance reps' do
+      create(:veteran_organization_representative,
+             representative:,
+             organization:,
+             acceptance_mode: 'no_acceptance')
+
+      result = described_class.accepting_poas_for(representative)
+      expect(result).not_to include('ABC')
+    end
+
+    it 'excludes deactivated reps' do
+      create(:veteran_organization_representative,
+             representative:,
+             organization:,
+             acceptance_mode: 'any_request',
+             deactivated_at: Time.current)
+
+      result = described_class.accepting_poas_for(representative)
+      expect(result).not_to include('ABC')
+    end
+  end
+
+  it 'delegates other methods to the organization' do
+    expect(subject.poa).to eq('ABC')
+    expect(subject.name).to eq(organization.name)
+  end
+end