Added explicit timeout to VES call (#22166)

* Added explicit timeout to VES call

* Fixed reference to Common::Client::Base::Connection

Author: stevelong00

modules/ivc_champva/lib/ves_api/client.rb

@@ -30,6 +30,7 @@ def submit_1010d(transaction_uuid, acting_user, ves_request_data)
         resp = connection.post("#{config.base_path}/champva-applications") do |req|
           req.headers = headers(transaction_uuid, acting_user)
           req.body = ves_request_data.to_json
+          req.options = { timeout: 60 } # in seconds, anything lower than 5 will certainly cause problems
         end
 
         monitor.track_ves_response(transaction_uuid, resp.status, resp.body)

modules/ivc_champva/spec/lib/ves_api_client_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'common/client/base'
 require 'rails_helper'
 require 'ves_api/client'
 
@@ -89,6 +90,31 @@
     end
   end
 
+  describe 'check options' do
+    it 'sets the request timeout to at least 5 seconds' do
+      # RuboCop prefers a constant class reference, but a string reference is necessary
+      # because Common::Client::Base::Connection is private.
+      # rubocop:disable RSpec/VerifiedDoubleReference
+      connection = instance_double('Common::Client::Base::Connection') # Mock the private connection class
+      # rubocop:enable RSpec/VerifiedDoubleReference
+      response = instance_double(Faraday::Response, status: 200, body: '')
+      allow(client).to receive(:connection).and_return(connection)
+
+      expect(connection).to receive(:post) do |&block|
+        request = double(options: Faraday::RequestOptions.new)
+        allow(request).to receive(:headers=)
+        allow(request).to receive(:body=)
+        allow(request).to receive(:options=) do |options|
+          expect(options[:timeout]).to be > 5
+        end
+        block.call(request)
+        response
+      end
+
+      client.submit_1010d(transaction_uuid, acting_user, ves_request_data)
+    end
+  end
+
   describe 'headers' do
     it 'returns the right headers' do
       result = client.headers('the_right_uuid', 'the_right_acting_user')