mms endpoint updates (#26948)

* mms endpoint updates

* update due to new directives for MMS

* lint fixes

* public veteran_name method fix

* lint fixes

* copilot suggestion

* remove date formatting to be consistent

---------

Co-authored-by: Calvin Costa <calvin.costa@va.com>

Author: costacalvin

app/models/concerns/ibm_data_dictionary.rb

@@ -126,11 +126,22 @@ def format_phone_for_ibm(phone_number)
   end
 
   # Build checkbox value
-  # Returns true for checked, false for unchecked (IBM MMS convention)
+  # Returns 1 for checked, 0 for unchecked (IBM MMS VBA Data Dictionary convention)
   # @param value [Boolean, nil]
-  # @return [Boolean]
+  # @return [Integer]
   def build_checkbox_value(value)
-    value == true
+    value == true ? 1 : 0
+  end
+
+  # Format currency value for IBM MMS
+  # Formats with commas and 2 decimal places (no dollar sign)
+  # @param amount [String, Integer, Float, nil] Numeric amount
+  # @return [String, nil] Formatted currency (e.g., "1,138.00") or nil
+  def format_currency_for_ibm(amount)
+    return nil if amount.nil? || amount.to_s.strip.empty?
+
+    numeric_value = amount.to_s.gsub(/[^0-9.]/, '').to_f
+    format('%<amount>.2f', amount: numeric_value).gsub(/(\d)(?=(\d{3})+\.)/, '\1,')
   end
 
   # Build form metadata fields

app/models/saved_claim/form210779.rb

@@ -39,12 +39,6 @@ def to_pdf(file_name = nil, fill_options = {})
     PdfFill::Forms::Va210779.stamp_signature(pdf_path, parsed_form)
   end
 
-  def veteran_name
-    first = parsed_form.dig('veteranInformation', 'fullName', 'first')
-    last = parsed_form.dig('veteranInformation', 'fullName', 'last')
-    "#{first} #{last}".strip.presence || 'Veteran'
-  end
-
   def metadata_for_benefits_intake
     { veteranFirstName: parsed_form.dig('veteranInformation', 'fullName', 'first'),
       veteranLastName: parsed_form.dig('veteranInformation', 'fullName', 'last'),
@@ -61,6 +55,12 @@ def to_ibm
     build_ibm_payload(parsed_form)
   end
 
+  def veteran_name
+    first = parsed_form.dig('veteranInformation', 'fullName', 'first')
+    last = parsed_form.dig('veteranInformation', 'fullName', 'last')
+    "#{first} #{last}".strip.presence || 'Veteran'
+  end
+
   private
 
   def zip_code_for_metadata
@@ -84,9 +84,11 @@ def build_ibm_payload(form)
   def build_veteran_fields(form)
     vet_info = form['veteranInformation'] || {}
     vet_id = vet_info['veteranId'] || {}
+    full_name = vet_info['fullName'] || {}
 
     build_veteran_basic_fields(vet_info)
       .merge({
+               'VETERAN_NAME' => build_full_name(full_name),
                'VETERAN_SSN' => vet_id['ssn'],
                'VA_FILE_NUMBER' => vet_id['vaFileNumber']
              })
@@ -98,14 +100,18 @@ def build_veteran_fields(form)
   def build_claimant_fields_section(form)
     claimant_info = form['claimantInformation'] || {}
     claimant_id = claimant_info['veteranId'] || {}
+    full_name = claimant_info['fullName'] || {}
 
     fields = build_claimant_fields(claimant_info)
 
+    # Add full name field
+    fields['CLAIMANT_NAME'] = build_full_name(full_name)
+
     # Override SSN with correct path (from veteranId object)
     fields['CLAIMANT_SSN'] = claimant_id['ssn']
 
-    # Box 7: VA File Number (note the typo from the spec: CL_FILE_NUMER)
-    fields['CL_FILE_NUMER'] = claimant_id['vaFileNumber']
+    # Box 7: VA File Number
+    fields['CL_FILE_NUMBER'] = claimant_id['vaFileNumber']
 
     fields
   end
@@ -136,35 +142,46 @@ def build_nursing_home_fields(form)
   def build_general_information_fields(form)
     general_info = form['generalInformation'] || {}
 
+    build_medicaid_fields(general_info)
+      .merge(build_cost_and_care_fields(general_info))
+      .merge(build_nursing_official_fields(general_info))
+  end
+
+  # Build Medicaid-related fields (Boxes 12-14)
+  def build_medicaid_fields(general_info)
     {
-      # Box 11: Date admitted to nursing home (MM/DD/YYYY format)
       'DATE_ADMISSION_TO_FACILITY_C' => format_date_for_ibm(general_info['admissionDate']),
-      # Box 12: Is the nursing home a Medicaid approved facility? (always include both Y/N)
       'MEDICAID_APPROVED_Y' => build_checkbox_value(general_info['medicaidFacility'] == true),
       'MEDICAID_APPROVED_N' => build_checkbox_value(general_info['medicaidFacility'] == false),
-      # Box 13: Has the patient applied for Medicaid? (always include both Y/N)
       'MEDICAID_APPLIED_Y' => build_checkbox_value(general_info['medicaidApplication'] == true),
       'MEDICAID_APPLIED_N' => build_checkbox_value(general_info['medicaidApplication'] == false),
-      # Box 14A: Is the patient covered by Medicaid? (always include both Y/N)
       'MEDICAID_COVERAGE_Y' => build_checkbox_value(general_info['patientMedicaidCovered'] == true),
       'MEDICAID_COVERAGE_N' => build_checkbox_value(general_info['patientMedicaidCovered'] == false),
-      # Box 14B: Date Medicaid plan began (MM/DD/YYYY format)
-      'MEDICAID_START' => format_date_for_ibm(general_info['medicaidStartDate']),
-      # Box 15: Monthly amount patient is responsible for out of pocket
-      'OUT_OF_POCKET' => general_info['monthlyCosts'],
-      # Box 16: Type of care (skilled or intermediate - always include both)
+      'MEDICAID_START' => format_date_for_ibm(general_info['medicaidStartDate'])
+    }
+  end
+
+  # Build cost and care type fields (Boxes 15-16)
+  def build_cost_and_care_fields(general_info)
+    monthly_costs = general_info['monthlyCosts']
+
+    {
+      'OUT_OF_POCKET' => format_currency_for_ibm(monthly_costs),
+      'OUT_OF_POCKET_THSNDS' => extract_currency_thousands(monthly_costs),
+      'OUT_OF_POCKET_HNDRDS' => extract_currency_hundreds(monthly_costs),
+      'OUT_OF_POCKET_CENTS' => extract_currency_cents(monthly_costs),
       'SKILLED_CARE' => build_checkbox_value(general_info['certificationLevelOfCare'] == 'skilled'),
-      'INTERMEDIATE_CARE' => build_checkbox_value(general_info['certificationLevelOfCare'] == 'intermediate'),
-      # Box 17: Nursing home official's name
+      'INTERMEDIATE_CARE' => build_checkbox_value(general_info['certificationLevelOfCare'] == 'intermediate')
+    }
+  end
+
+  # Build nursing home official fields (Boxes 17-21)
+  def build_nursing_official_fields(general_info)
+    {
       'NAME_COMPLETING_WORKSHEET_C' => general_info['nursingOfficialName'],
-      # Box 18: Nursing home official's title
       'ROLE_PERFORM_AT_FACILITY_C' => general_info['nursingOfficialTitle'],
-      # Box 19: Nursing home official's office telephone number
       'FACILITY_TELEPHONE_NUMBER_C' => format_phone_for_ibm(general_info['nursingOfficialPhoneNumber']),
-      'INT_PHONE_NUMBER' => format_phone_for_ibm(general_info['nursingOfficialInternationalPhoneNumber']),
-      # Box 20: Signature of nursing home official
       'SIGNATURE_OF_PROVIDER_C' => general_info['signature'],
-      # Box 21: Date signed (MM/DD/YYYY format)
       'SIGNATURE_DATE_PROVIDER_C' => format_date_for_ibm(general_info['signatureDate'])
     }
   end
@@ -175,8 +192,43 @@ def build_form_metadata_fields
     {
       'FLASH_TEXT' => nil,
       'CB_VA_STAMP' => nil,
-      'FORM_TYPE' => '21-0779',
-      'FORM_TYPE_1' => '21-0779'
+      'FORM_TYPE_1' => 'VA FORM 0779, NOV 2023'
     }
   end
+
+  # Extract thousands portion from currency amount
+  # Fixed 3-digit format, returns "000" if no thousands
+  # @param amount [String, Integer, Float, nil] Numeric amount
+  # @return [String] Thousands portion (e.g., "130" from 130000.50, "000" from 9.50)
+  def extract_currency_thousands(amount)
+    return '000' if amount.nil? || amount.to_s.strip.empty?
+
+    numeric_value = amount.to_s.gsub(/[^0-9.]/, '').to_f
+    thousands = (numeric_value / 1000).floor
+    thousands.positive? ? thousands.to_s : '000'
+  end
+
+  # Extract hundreds portion from currency amount
+  # Fixed 3-digit format with leading zeros
+  # @param amount [String, Integer, Float, nil] Numeric amount
+  # @return [String] Hundreds portion with leading zeros (e.g., "000" from 3000.50, "009" from 9.50)
+  def extract_currency_hundreds(amount)
+    return '000' if amount.nil? || amount.to_s.strip.empty?
+
+    numeric_value = amount.to_s.gsub(/[^0-9.]/, '').to_f
+    hundreds = (numeric_value % 1000).floor
+    format('%03d', hundreds)
+  end
+
+  # Extract cents portion from currency amount
+  # Fixed 2-digit format with leading zeros
+  # @param amount [String, Integer, Float, nil] Numeric amount
+  # @return [String] Cents portion (e.g., "50" from 3000.50, "00" from 9.00)
+  def extract_currency_cents(amount)
+    return '00' if amount.nil? || amount.to_s.strip.empty?
+
+    numeric_value = amount.to_s.gsub(/[^0-9.]/, '').to_f
+    cents = ((numeric_value % 1) * 100).round
+    format('%02d', cents)
+  end
 end

app/models/saved_claim/form214192.rb

@@ -85,10 +85,6 @@ def to_ibm
 
   private
 
-  def zip_code_for_metadata
-    parsed_form.dig('employmentInformation', 'employerAddress', 'postalCode') || DEFAULT_ZIP_CODE
-  end
-
   def employer_name
     parsed_form.dig('employmentInformation', 'employerName') || 'Employer'
   end
@@ -99,28 +95,20 @@ def veteran_name
     "#{first} #{last}".strip.presence || 'Veteran'
   end
 
+  def zip_code_for_metadata
+    parsed_form.dig('employmentInformation', 'employerAddress', 'postalCode') || DEFAULT_ZIP_CODE
+  end
+
   # Build the IBM data dictionary payload from the parsed claim form
+  # Per AUG 2024 Data Dictionary: Form 21-4192 has only 3 fields
+  # This form is completed by employers, not veterans, so no veteran fields in IBM payload
   # @param form [Hash]
   # @return [Hash]
   def build_ibm_payload(form)
-    build_veteran_fields(form)
-      .merge(build_employer_fields(form))
+    build_employer_fields(form)
       .merge(build_form_metadata_fields)
   end
 
-  # Build veteran identification fields (Section 1)
-  # @param form [Hash]
-  # @return [Hash]
-  def build_veteran_fields(form)
-    vet_info = form['veteranInformation'] || {}
-
-    basic_fields = build_veteran_basic_fields(vet_info)
-    basic_fields['VETERAN_INITIAL'] = basic_fields.delete('VETERAN_MIDDLE_INITIAL')
-    basic_fields['VA_FILE_NUMBER'] ||= ''
-
-    basic_fields
-  end
-
   # Build employer information fields (Box 1)
   # @param form [Hash]
   # @return [Hash]
@@ -130,15 +118,15 @@ def build_employer_fields(form)
 
     {
       'EMPLOYER_NAME_ADDRESS' => build_employer_name_and_address(employment['employerName'], employer_address)
-    }.compact
+    }
   end
 
   # Build form metadata
   # @return [Hash]
   def build_form_metadata_fields
     {
-      'FORM_TYPE' => '21-4192',
-      'FORM_TYPE_1' => '21-4192'
+      'FORM_TYPE' => 'VA FORM 21-4192, AUG 2024',
+      'FORM_TYPE_1' => 'VA FORM 21-4192, AUG 2024'
     }
   end