Fix cerner eligibility test failure caused by Settings mutation leak (#27411)

Author: rileyanderson

modules/mobile/spec/requests/mobile/v0/user/authorized_services_spec.rb

@@ -61,9 +61,11 @@
     end
 
     it 'includes properly set meta flags for user not at pretransitioned oh facility' do
-      Settings.mhv.oh_facility_checks.pretransitioned_oh_facilities = '612, 357'
-      Settings.mhv.oh_facility_checks.facilities_ready_for_info_alert = '456, 789'
-      Settings.mhv.oh_facility_checks.oh_migrations_list = ''
+      allow(Settings.mhv.oh_facility_checks).to receive_messages(
+        pretransitioned_oh_facilities: '612, 357',
+        facilities_ready_for_info_alert: '456, 789',
+        oh_migrations_list: ''
+      )
       get '/mobile/v0/user/authorized-services', headers: sis_headers,
                                                  params: { 'appointmentIEN' => '123', 'locationId' => '123' }
       assert_schema_conform(200)
@@ -74,9 +76,11 @@
     end
 
     it 'includes properly set meta flags for user at pretransitioned oh facility but not ready for info alert' do
-      Settings.mhv.oh_facility_checks.pretransitioned_oh_facilities = '612, 357, 555'
-      Settings.mhv.oh_facility_checks.facilities_ready_for_info_alert = '456, 789'
-      Settings.mhv.oh_facility_checks.oh_migrations_list = ''
+      allow(Settings.mhv.oh_facility_checks).to receive_messages(
+        pretransitioned_oh_facilities: '612, 357, 555',
+        facilities_ready_for_info_alert: '456, 789',
+        oh_migrations_list: ''
+      )
       get '/mobile/v0/user/authorized-services', headers: sis_headers,
                                                  params: { 'appointmentIEN' => '123', 'locationId' => '123' }
       assert_schema_conform(200)
@@ -90,9 +94,11 @@
     end
 
     it 'includes properly set meta flags for user at pretransitioned oh facility and ready for info alert' do
-      Settings.mhv.oh_facility_checks.pretransitioned_oh_facilities = '612, 357, 555'
-      Settings.mhv.oh_facility_checks.facilities_ready_for_info_alert = '555'
-      Settings.mhv.oh_facility_checks.oh_migrations_list = ''
+      allow(Settings.mhv.oh_facility_checks).to receive_messages(
+        pretransitioned_oh_facilities: '612, 357, 555',
+        facilities_ready_for_info_alert: '555',
+        oh_migrations_list: ''
+      )
       get '/mobile/v0/user/authorized-services', headers: sis_headers,
                                                  params: { 'appointmentIEN' => '123', 'locationId' => '123' }
       assert_schema_conform(200)
@@ -106,9 +112,12 @@
     end
 
     it 'includes properly set meta flags for actively migrating facility' do
-      Settings.mhv.oh_facility_checks.pretransitioned_oh_facilities = '612, 357'
-      Settings.mhv.oh_facility_checks.facilities_ready_for_info_alert = '612'
-      Settings.mhv.oh_facility_checks.oh_migrations_list = '2026-10-01:[555,Facility A],[612,Facility B]'
+      migrations_list = '2026-10-01:[555,Facility A],[612,Facility B]'
+      allow(Settings.mhv.oh_facility_checks).to receive_messages(
+        pretransitioned_oh_facilities: '612, 357',
+        facilities_ready_for_info_alert: '612',
+        oh_migrations_list: migrations_list
+      )
       get '/mobile/v0/user/authorized-services', headers: sis_headers,
                                                  params: { 'appointmentIEN' => '123', 'locationId' => '123' }
       assert_schema_conform(200)
@@ -372,9 +381,12 @@
     end
 
     it 'includes properly sets migratingFacilitiesList when user does not have a migrating facility' do
-      Settings.mhv.oh_facility_checks.pretransitioned_oh_facilities = '612, 357'
-      Settings.mhv.oh_facility_checks.facilities_ready_for_info_alert = '612'
-      Settings.mhv.oh_facility_checks.oh_migrations_list = '2026-10-01:[999,Facility A],[888,Facility B]'
+      migrations_list = '2026-10-01:[999,Facility A],[888,Facility B]'
+      allow(Settings.mhv.oh_facility_checks).to receive_messages(
+        pretransitioned_oh_facilities: '612, 357',
+        facilities_ready_for_info_alert: '612',
+        oh_migrations_list: migrations_list
+      )
       get '/mobile/v0/user/authorized-services', headers: sis_headers,
                                                  params: { 'appointmentIEN' => '123', 'locationId' => '123' }
       assert_schema_conform(200)
@@ -384,9 +396,12 @@
     end
 
     it 'includes properly sets migratingFacilitiesList when user does have a migrating facility' do
-      Settings.mhv.oh_facility_checks.pretransitioned_oh_facilities = '612, 357'
-      Settings.mhv.oh_facility_checks.facilities_ready_for_info_alert = '612'
-      Settings.mhv.oh_facility_checks.oh_migrations_list = '2026-10-01:[555,Facility A],[555,Facility B]'
+      migrations_list = '2026-10-01:[555,Facility A],[555,Facility B]'
+      allow(Settings.mhv.oh_facility_checks).to receive_messages(
+        pretransitioned_oh_facilities: '612, 357',
+        facilities_ready_for_info_alert: '612',
+        oh_migrations_list: migrations_list
+      )
       get '/mobile/v0/user/authorized-services', headers: sis_headers,
                                                  params: { 'appointmentIEN' => '123', 'locationId' => '123' }
       assert_schema_conform(200)

spec/controllers/v1/sessions_controller_spec.rb

@@ -949,6 +949,10 @@ def expect_logger_msg(level, msg)
       end
 
       context 'when cerner eligibility is checked' do
+        let(:user) { build(:user, :loa3, cerner_id:, cerner_facility_ids:) }
+        let(:correlation_mpi_record) { build(:mpi_profile, ssn: correlation_mpi_ssn, cerner_id:, cerner_facility_ids:) }
+        let(:cerner_id) { 'some-cerner-id' }
+        let(:cerner_facility_ids) { %w[123 555] }
         let(:cerner_eligible_cookie) { 'CERNER_ELIGIBLE' }
         let(:expected_log_message) { '[SessionsController] Cerner Eligibility' }
         let(:previous_value) { nil }
@@ -957,12 +961,11 @@ def expect_logger_msg(level, msg)
         before do
           SAMLRequestTracker.create(uuid: login_uuid, payload: { type: 'idme', application: 'some-applicaton' })
           allow(Rails.logger).to receive(:info)
-          allow(IdentitySettings.sign_in).to receive(:info_cookie_domain).and_return('some-domain')
         end
 
         context 'when the cerner eligible cookie is not present' do
           before do
-            allow_any_instance_of(User).to receive(:cerner_full?).and_return(eligible)
+            allow(IdentitySettings.sign_in).to receive(:info_cookie_domain).and_return('some-domain')
           end
 
           context 'when the user is cerner eligible' do
@@ -978,6 +981,7 @@ def expect_logger_msg(level, msg)
           end
 
           context 'when the user is not cerner eligible' do
+            let(:cerner_id) { nil }
             let(:eligible) { false }
 
             it 'sets the cookie and logs the cerner eligibility' do
@@ -994,7 +998,6 @@ def expect_logger_msg(level, msg)
           let(:previous_value) { true }
 
           before do
-            allow_any_instance_of(User).to receive(:cerner_full?).and_return(eligible)
             cookies[cerner_eligible_cookie] = true
           end