[DBEX] assign otherBehaviors string value to own property

Author: freeheeling

lib/evss/disability_compensation_form/form0781.rb

@@ -58,6 +58,7 @@ def create_form_v2
                                      'reports' => @form_content['reports'],
                                      'reportsDetails' => @form_content['reportsDetails'],
                                      'behaviors' => @form_content['behaviors'],
+                                     'otherBehaviors' => @form_content['otherBehaviors'],
                                      'behaviorsDetails' => @form_content['behaviorsDetails'],
                                      'evidence' => @form_content['evidence'],
                                      'traumaTreatment' => @form_content['traumaTreatment'],

lib/pdf_fill/forms/va210781v2.rb

@@ -686,7 +686,7 @@ def set_option_indicator
       end
 
       def format_other_behavior_details
-        other_behavior = @form_data['behaviors']&.[]('otherBehavior')
+        other_behavior = @form_data['otherBehaviors']
         return if other_behavior.blank?
 
         details = @form_data['behaviorsDetails']['otherBehavior']

spec/fixtures/pdf_fill/21-0781V2/kitchen_sink.json

@@ -63,9 +63,9 @@
     "screenings": true,
     "socialEconomic": false,
     "relationships": true,
-    "misconduct": false,
-    "otherBehavior": "Lorem"
+    "misconduct": false
   },
+  "otherBehaviors": "Lorem",
   "behaviorsDetails": {
     "reassignment": "requested duty assignment",
     "performance": "poor evaluations",

spec/fixtures/pdf_fill/21-0781V2/merge_fields.json

@@ -78,9 +78,9 @@
     "screenings": true,
     "socialEconomic": false,
     "relationships": true,
-    "misconduct": false,
-    "otherBehavior": "Lorem"
+    "misconduct": false
   },
+  "otherBehaviors": "Lorem",
   "behaviorsDetails": {
     "reassignment": "requested duty assignment",
     "performance": "poor evaluations",

spec/fixtures/pdf_fill/21-0781V2/overflow.json

@@ -88,9 +88,9 @@
     "screenings": true,
     "socialEconomic": false,
     "relationships": true,
-    "misconduct": false,
-    "otherBehavior": "Lorem"
+    "misconduct": false
   },
+  "otherBehaviors": "Lorem",
   "behaviorsDetails": {
     "reassignment": "requested duty assignment",
     "performance": "poor evaluations",

spec/lib/pdf_fill/forms/va210781v2_spec.rb

@@ -76,7 +76,7 @@ def class_form_data
       let(:details) { 'Always feeling tired' }
       let :data do
         {
-          'behaviors' => { 'otherBehavior' => other_behavior },
+          'otherBehaviors' => other_behavior,
           'behaviorsDetails' => { 'otherBehavior' => details }
         }
       end

spec/support/disability_compensation_form/all_claims_with_0781v2_fe_submission.json

@@ -192,9 +192,9 @@
           "substances": true,
           "appetite": true,
           "screenings": true,
-          "relationships": true,
-          "otherBehavior": "Withdrawal"
+          "relationships": true
         },
+        "otherBehaviors": "Withdrawal",
         "behaviorsDetails": {
           "reassignment": "Lorem ipsum dolor sit amet.",
           "performance": "Lorem ipsum dolor sit amet.",

spec/support/disability_compensation_form/form_0781v2.json

@@ -67,9 +67,9 @@
       "substances": true,
       "appetite": true,
       "screenings": true,
-      "relationships": true,
-      "otherBehavior": "Withdrawal"
+      "relationships": true
     },
+    "otherBehaviors": "Withdrawal",
     "behaviorsDetails": {
       "reassignment": "Lorem ipsum dolor sit amet.",
       "performance": "Lorem ipsum dolor sit amet.",

spec/support/disability_compensation_form/submissions/with_0781v2.json

@@ -372,9 +372,9 @@
         "substances": true,
         "appetite": true,
         "screenings": true,
-        "relationships": true,
-        "otherBehavior": "Withdrawal"
+        "relationships": true
       },
+      "otherBehaviors": "Withdrawal",
       "behaviorsDetails": {
         "reassignment": "Lorem ipsum dolor sit amet.",
         "performance": "Lorem ipsum dolor sit amet.",