[CVE-2674] add veteranSsnLastFour to form data (#44154)

* persist DOB and SSN last four in form data

* add prefillTransformer to extract veteranSsnLastFour from nonPrefill

* remove dob changes

* gatekeep prefill changes

Author: andresriveratoro

src/applications/lgy/coe/form/config/form.js

@@ -10,6 +10,7 @@ import { PreSubmitInfoSelector } from '../containers/selectors/PreSubmitInfoSele
 import { GetFormHelp } from '../components/GetFormHelp';
 import manifest from '../manifest.json';
 import { customCOEsubmit } from './helpers';
+import { prefillTransformer } from './prefill-transformer';
 import { definitions } from './schemaImports';
 
 // chapter schema imports
@@ -64,6 +65,7 @@ const formConfig = {
   formId: '26-1880',
   version: 0,
   prefillEnabled: true,
+  prefillTransformer,
   footerContent: FormFooter,
   preSubmitInfo: { ...preSubmitInfo, CustomComponent: PreSubmitInfoSelector },
   getHelp: GetFormHelp,

src/applications/lgy/coe/form/config/prefill-transformer.js

@@ -0,0 +1,18 @@
+import { TOGGLE_KEY } from '../constants';
+
+export const prefillTransformer = (pages, formData, metadata) => {
+  if (!formData?.[`view:${TOGGLE_KEY}`]) {
+    return { pages, formData, metadata };
+  }
+
+  const { veteranSsnLastFour = '' } = formData?.nonPrefill || {};
+
+  return {
+    pages,
+    formData: {
+      ...formData,
+      veteranSsnLastFour,
+    },
+    metadata,
+  };
+};

src/applications/lgy/coe/form/pages/personalInformation.js

@@ -13,7 +13,15 @@ export default {
   hideOnReview: false,
   schema: {
     type: 'object',
-    properties: {},
+    properties: {
+      veteranSsnLastFour: {
+        type: 'string',
+        pattern: '^[0-9]{4}$',
+      },
+      dateOfBirth: {
+        $ref: '#/definitions/date',
+      },
+    },
   },
   uiSchema: {},
 };

src/applications/lgy/coe/form/tests/config/prefill-transformer.unit.spec.jsx

@@ -0,0 +1,87 @@
+import { expect } from 'chai';
+import { prefillTransformer } from '../../config/prefill-transformer';
+import { TOGGLE_KEY } from '../../constants';
+
+describe('COE prefill transformer', () => {
+  const pages = { testPage: 'Page 1' };
+  const metadata = { version: 0, prefill: true };
+  const toggleOn = { [`view:${TOGGLE_KEY}`]: true };
+
+  it('returns pages and metadata unchanged', () => {
+    const result = prefillTransformer(pages, toggleOn, metadata);
+
+    expect(result.pages).to.equal(pages);
+    expect(result.metadata).to.equal(metadata);
+  });
+
+  it('leaves formData untouched when the toggle is off', () => {
+    const formData = {
+      nonPrefill: { veteranSsnLastFour: '6789' },
+    };
+
+    const { formData: transformed } = prefillTransformer(
+      pages,
+      formData,
+      metadata,
+    );
+
+    expect(transformed).to.equal(formData);
+    expect(transformed.veteranSsnLastFour).to.be.undefined;
+  });
+
+  it('extracts veteranSsnLastFour from nonPrefill when the toggle is on', () => {
+    const formData = {
+      ...toggleOn,
+      nonPrefill: { veteranSsnLastFour: '6789' },
+    };
+
+    const { formData: transformed } = prefillTransformer(
+      pages,
+      formData,
+      metadata,
+    );
+
+    expect(transformed.veteranSsnLastFour).to.equal('6789');
+  });
+
+  it('defaults veteranSsnLastFour to an empty string when nonPrefill is missing', () => {
+    const { formData: transformed } = prefillTransformer(
+      pages,
+      toggleOn,
+      metadata,
+    );
+
+    expect(transformed.veteranSsnLastFour).to.equal('');
+  });
+
+  it('defaults veteranSsnLastFour to an empty string when not present in nonPrefill', () => {
+    const formData = { ...toggleOn, nonPrefill: {} };
+
+    const { formData: transformed } = prefillTransformer(
+      pages,
+      formData,
+      metadata,
+    );
+
+    expect(transformed.veteranSsnLastFour).to.equal('');
+  });
+
+  it('preserves other top-level formData fields when the toggle is on', () => {
+    const formData = {
+      ...toggleOn,
+      fullName: { first: 'Mae', middle: '', last: 'Rivera' },
+      dateOfBirth: '1931-06-07',
+      nonPrefill: { veteranSsnLastFour: '6789' },
+    };
+
+    const { formData: transformed } = prefillTransformer(
+      pages,
+      formData,
+      metadata,
+    );
+
+    expect(transformed.fullName).to.deep.equal(formData.fullName);
+    expect(transformed.dateOfBirth).to.equal('1931-06-07');
+    expect(transformed.veteranSsnLastFour).to.equal('6789');
+  });
+});