DMT | Fix submission errors part 2 (#43761)

* Remove maxlength on marriage ended city

* Use strict date schema

* Fix dates not formatted with a leading zero

Author: Mottie

src/applications/dependents/686c-674/README.md

@@ -272,7 +272,7 @@ schema: {
   type: 'object',
   required: ['endDate'],
   properties: {
-    endDate: currentOrPastDateSchema,
+    endDate: DATE_SCHEMA, // using a strict date Regex (no "X"s)
   },
 },
 ```

src/applications/dependents/686c-674/components/picklist/spouseMarriageEnded.jsx

@@ -139,7 +139,6 @@ const spouseMarriageEnded = {
           value={itemData.endCity || ''}
           onVaInput={onChange}
           required
-          maxlength={30}
         />
         {itemData.endOutsideUs ? (
           <>

src/applications/dependents/686c-674/components/picklist/utils.js

@@ -363,7 +363,7 @@ export const getPastDateError = (
   }
 
   const parsedDate = parse(date, 'yyyy-MM-dd', new Date());
-  if (!isValid(parsedDate)) {
+  if (!isValid(parsedDate) || date.includes('X')) {
     return 'Enter a valid date';
   }
   if (!isPast(parsedDate)) {

src/applications/dependents/686c-674/config/chapters/674/studentAttendancePages.js

@@ -3,13 +3,13 @@ import {
   yesNoUI,
   yesNoSchema,
   currentOrPastDateUI,
-  currentOrPastDateSchema,
 } from 'platform/forms-system/src/js/web-component-patterns';
 import VaMemorableDateField from 'platform/forms-system/src/js/web-component-fields/VaMemorableDateField';
 import { validateCurrentOrFutureDate } from 'platform/forms-system/src/js/validation';
 
 import { AccreditedSchool, TermDateHint } from './helpers';
 import { generateHelpText } from '../../helpers';
+import { DATE_SCHEMA } from '../../constants';
 
 export const studentAttendancePage = {
   uiSchema: {
@@ -77,7 +77,7 @@ export const studentStoppedAttendingDatePage = {
       schoolInformation: {
         type: 'object',
         properties: {
-          dateFullTimeEnded: currentOrPastDateSchema,
+          dateFullTimeEnded: DATE_SCHEMA,
         },
       },
     },
@@ -172,12 +172,9 @@ export const studentTermDatesPage = {
             ],
             type: 'object',
             properties: {
-              officialSchoolStartDate: currentOrPastDateSchema,
-              expectedStudentStartDate: currentOrPastDateSchema,
-              expectedGraduationDate: {
-                type: 'string',
-                pattern: '^\\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])$',
-              },
+              officialSchoolStartDate: DATE_SCHEMA,
+              expectedStudentStartDate: DATE_SCHEMA,
+              expectedGraduationDate: DATE_SCHEMA,
             },
           },
         },
@@ -264,8 +261,8 @@ export const previousTermDatesPage = {
           lastTermSchoolInformation: {
             type: 'object',
             properties: {
-              termBegin: currentOrPastDateSchema,
-              dateTermEnded: currentOrPastDateSchema,
+              termBegin: DATE_SCHEMA,
+              dateTermEnded: DATE_SCHEMA,
             },
           },
         },

src/applications/dependents/686c-674/config/chapters/674/studentEducationPages.js

@@ -7,14 +7,14 @@ import {
   radioUI,
   radioSchema,
   currentOrPastDateUI,
-  currentOrPastDateSchema,
 } from 'platform/forms-system/src/js/web-component-patterns';
 
 import {
   benefitSchemaLabels,
   benefitUiLabels,
   ProgramExamples,
 } from './helpers';
+import { DATE_SCHEMA } from '../../constants';
 
 /** @returns {PageSchema} */
 export const studentEducationBenefitsPage = {
@@ -147,7 +147,7 @@ export const studentEducationBenefitsStartDatePage = {
   schema: {
     type: 'object',
     properties: {
-      benefitPaymentDate: currentOrPastDateSchema,
+      benefitPaymentDate: DATE_SCHEMA,
     },
   },
 };

src/applications/dependents/686c-674/config/chapters/674/studentIdentityPages.js

@@ -4,7 +4,6 @@ import {
   arrayBuilderItemSubsequentPageTitleUI,
   fullNameNoSuffixSchema,
   currentOrPastDateUI,
-  currentOrPastDateSchema,
   checkboxUI,
   checkboxSchema,
   radioUI,
@@ -17,6 +16,7 @@ import { relationshipToStudentLabels } from './helpers';
 import { addStudentsOptions } from './addStudentsSetup';
 import { NO_SSN_REASON_UI_MAPPINGS } from '../../dataMappings';
 import { fullNameNoSuffixWithAsciiUI } from '../../helpers';
+import { DATE_SCHEMA } from '../../constants';
 
 /** @returns {PageSchema} */
 export const studentInformationPage = {
@@ -83,7 +83,7 @@ export const studentInformationPage = {
     properties: {
       'view:studentNameTitle': { type: 'object', properties: {} },
       fullName: fullNameNoSuffixSchema,
-      birthDate: currentOrPastDateSchema,
+      birthDate: DATE_SCHEMA,
       'view:studentIdTitle': { type: 'object', properties: {} },
       noSsn: checkboxSchema,
       noSsnReason: radioSchema(['NONRESIDENT_ALIEN', 'NONE_ASSIGNED']),

src/applications/dependents/686c-674/config/chapters/674/studentPersonalPages.js

@@ -7,9 +7,9 @@ import {
   yesNoUI,
   yesNoSchema,
   currentOrPastDateUI,
-  currentOrPastDateSchema,
 } from 'platform/forms-system/src/js/web-component-patterns';
 import { asciiValidation } from '../../helpers';
+import { DATE_SCHEMA } from '../../constants';
 
 /** @returns {PageSchema} */
 export const studentIncomePage = {
@@ -149,7 +149,7 @@ export const studentMarriageDatePage = {
   schema: {
     type: 'object',
     properties: {
-      marriageDate: currentOrPastDateSchema,
+      marriageDate: DATE_SCHEMA,
     },
   },
 };

src/applications/dependents/686c-674/config/chapters/report-add-a-spouse/does-live-with-spouse/doesLiveWithSpouse.js

@@ -2,9 +2,9 @@ import {
   yesNoSchema,
   yesNoUI,
   currentOrPastDateUI,
-  currentOrPastDateSchema,
   titleUI,
 } from 'platform/forms-system/src/js/web-component-patterns';
+import { DATE_SCHEMA } from '../../../constants';
 
 export const schema = {
   type: 'object',
@@ -18,7 +18,7 @@ export const schema = {
     currentMarriageInformation: {
       type: 'object',
       properties: {
-        date: currentOrPastDateSchema,
+        date: DATE_SCHEMA,
       },
     },
   },

src/applications/dependents/686c-674/config/chapters/report-add-a-spouse/spouseMarriageHistoryArrayPages.js

@@ -8,7 +8,6 @@ import {
   radioUI,
   radioSchema,
   currentOrPastDateUI,
-  currentOrPastDateSchema,
 } from 'platform/forms-system/src/js/web-component-patterns';
 import VaTextInputField from 'platform/forms-system/src/js/web-component-fields/VaTextInputField';
 import VaSelectField from 'platform/forms-system/src/js/web-component-fields/VaSelectField';
@@ -21,6 +20,7 @@ import {
   fullNameNoSuffixWithAsciiUI,
 } from '../../helpers';
 import { getFullName } from '../../../../shared/utils';
+import { DATE_SCHEMA } from '../../constants';
 
 /** @type {ArrayBuilderOptions} */
 export const spouseMarriageHistoryOptions = {
@@ -156,7 +156,7 @@ export const formerMarriageStartDatePage = {
     type: 'object',
     required: ['startDate'],
     properties: {
-      startDate: currentOrPastDateSchema,
+      startDate: DATE_SCHEMA,
     },
   },
 };
@@ -193,7 +193,7 @@ export const formerMarriageEndDatePage = {
     type: 'object',
     required: ['endDate'],
     properties: {
-      endDate: currentOrPastDateSchema,
+      endDate: DATE_SCHEMA,
     },
   },
 };

src/applications/dependents/686c-674/config/chapters/report-add-a-spouse/veteranMarriageHistoryArrayPages.js

@@ -7,7 +7,6 @@ import {
   radioUI,
   radioSchema,
   currentOrPastDateUI,
-  currentOrPastDateSchema,
 } from 'platform/forms-system/src/js/web-component-patterns';
 import VaTextInputField from 'platform/forms-system/src/js/web-component-fields/VaTextInputField';
 import VaSelectField from 'platform/forms-system/src/js/web-component-fields/VaSelectField';
@@ -22,6 +21,7 @@ import {
   fullNameNoSuffixWithAsciiUI,
 } from '../../helpers';
 import { getFullName } from '../../../../shared/utils';
+import { DATE_SCHEMA } from '../../constants';
 
 /* NOTE:
  * In "Add mode" of the array builder, formData represents the entire formData object.
@@ -172,7 +172,7 @@ export const vetFormerMarriageStartDatePage = {
     type: 'object',
     required: ['startDate'],
     properties: {
-      startDate: currentOrPastDateSchema,
+      startDate: DATE_SCHEMA,
     },
   },
 };
@@ -209,7 +209,7 @@ export const vetFormerMarriageEndDatePage = {
     type: 'object',
     required: ['endDate'],
     properties: {
-      endDate: currentOrPastDateSchema,
+      endDate: DATE_SCHEMA,
     },
   },
 };