fixed nilable type after adding sorbet type strict for url updateer

Author: randhircs

python/lib/dependabot/python/authed_url_builder.rb

@@ -1,9 +1,14 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
+require "sorbet-runtime"
+
 module Dependabot
   module Python
     class AuthedUrlBuilder
+      extend T::Sig
+
+      sig { params(credential: Credential).returns(T.nilable(String)) }
       def self.authed_url(credential:)
         token = credential.fetch("token", nil)
         url = credential.fetch("index-url", nil)

python/lib/dependabot/python/file_updater.rb

@@ -132,15 +132,15 @@ def updated_requirement_based_files
         ).updated_dependency_files
       end
 
-      sig { returns(T::Array[String]) }
+      sig { returns(T.nilable(T::Array[String])) }
       def pip_compile_index_urls
         if credentials.any?(&:replaces_base?)
-          credentials.select(&:replaces_base?).map { |cred| AuthedUrlBuilder.authed_url(credential: cred) }
+          credentials.select(&:replaces_base?).map { |cred| AuthedUrlBuilder.authed_url(credential: cred) }.compact
         else
           urls = credentials.map { |cred| AuthedUrlBuilder.authed_url(credential: cred) }
           # If there are no credentials that replace the base, we need to
           # ensure that the base URL is included in the list of extra-index-urls.
-          [nil, *urls]
+          [nil, *urls].compact
         end
       end
 

python/lib/dependabot/python/file_updater/pipfile_preparer.rb

@@ -88,7 +88,7 @@ def sub_auth_url(source, credentials)
 
             return nil if source_cred.nil?
 
-            source["url"] = AuthedUrlBuilder.authed_url(credential: source_cred)
+            source["url"] = T.must(AuthedUrlBuilder.authed_url(credential: source_cred))
           end
 
           source

python/lib/dependabot/python/metadata_finder.rb

@@ -196,7 +196,7 @@ def possible_listing_urls
           .map { |c| AuthedUrlBuilder.authed_url(credential: c) }
 
         (credential_urls + [MAIN_PYPI_URL]).map do |base_url|
-          base_url.gsub(%r{/$}, "") + "/#{normalised_dependency_name}/json"
+          T.must(base_url&.gsub(%r{/$}, "")) + "/#{normalised_dependency_name}/json"
         end
       end
 

python/lib/dependabot/python/package/package_registry_finder.rb

@@ -140,7 +140,7 @@ def pyproject_index_urls
         end
 
         def config_variable_index_urls
-          urls = { main: nil, extra: [] }
+          urls = { main: T.let(nil, T.nilable(String)), extra: [] }
 
           index_url_creds = credentials
                             .select { |cred| cred["type"] == "python_index" }
@@ -190,7 +190,7 @@ def authed_base_url(base_url)
           cred = credential_for(base_url)
           return base_url unless cred
 
-          AuthedUrlBuilder.authed_url(credential: cred).gsub(%r{/*$}, "") + "/"
+          T.must(AuthedUrlBuilder.authed_url(credential: cred)&.gsub(%r{/*$}, "")) + "/"
         end
 
         def credential_for(url)