Skip to content

Commit 96f8f65

Browse files
authored
update version types for package latest version finder (#12059)
1 parent 2bba480 commit 96f8f65

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

common/lib/dependabot/package/package_latest_version_finder.rb

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,24 +81,24 @@ def initialize(
8181
end
8282

8383
sig do
84-
params(language_version: T.nilable(T.any(String, Version)))
85-
.returns(T.nilable(Gem::Version))
84+
params(language_version: T.nilable(T.any(String, Dependabot::Version)))
85+
.returns(T.nilable(Dependabot::Version))
8686
end
8787
def latest_version(language_version: nil)
8888
@latest_version ||= fetch_latest_version(language_version: language_version)
8989
end
9090

9191
sig do
92-
params(language_version: T.nilable(T.any(String, Version)))
93-
.returns(T.nilable(Gem::Version))
92+
params(language_version: T.nilable(T.any(String, Dependabot::Version)))
93+
.returns(T.nilable(Dependabot::Version))
9494
end
9595
def latest_version_with_no_unlock(language_version: nil)
9696
@latest_version_with_no_unlock ||= fetch_latest_version_with_no_unlock(language_version: language_version)
9797
end
9898

9999
sig do
100-
params(language_version: T.nilable(T.any(String, Version)))
101-
.returns(T.nilable(Gem::Version))
100+
params(language_version: T.nilable(T.any(String, Dependabot::Version)))
101+
.returns(T.nilable(Dependabot::Version))
102102
end
103103
def lowest_security_fix_version(language_version: nil)
104104
@lowest_security_fix_version ||= fetch_lowest_security_fix_version(language_version: language_version)
@@ -117,7 +117,7 @@ def available_versions
117117
protected
118118

119119
sig do
120-
params(language_version: T.nilable(T.any(String, Version)))
120+
params(language_version: T.nilable(T.any(String, Dependabot::Version)))
121121
.returns(T.nilable(Dependabot::Version))
122122
end
123123
def fetch_latest_version(language_version: nil)
@@ -133,13 +133,16 @@ def fetch_latest_version(language_version: nil)
133133
versions.max
134134
end
135135

136-
sig { params(versions: T::Array[Dependabot::Version]).returns(T::Array[Dependabot::Version]) }
136+
sig do
137+
params(versions: T::Array[Dependabot::Version])
138+
.returns(T::Array[Dependabot::Version])
139+
end
137140
def apply_post_fetch_latest_versions_filter(versions)
138141
versions
139142
end
140143

141144
sig do
142-
params(language_version: T.nilable(T.any(String, Version)))
145+
params(language_version: T.nilable(T.any(String, Dependabot::Version)))
143146
.returns(T.nilable(Dependabot::Version))
144147
end
145148
def fetch_latest_version_with_no_unlock(language_version:)
@@ -157,7 +160,7 @@ def fetch_latest_version_with_no_unlock(language_version:)
157160
end
158161

159162
sig do
160-
params(language_version: T.nilable(T.any(String, Version)))
163+
params(language_version: T.nilable(T.any(String, Dependabot::Version)))
161164
.returns(T.nilable(Dependabot::Version))
162165
end
163166
def fetch_lowest_security_fix_version(language_version:)
@@ -222,7 +225,7 @@ def filter_by_cooldown(releases)
222225
sig do
223226
params(
224227
releases: T::Array[Dependabot::Package::PackageRelease],
225-
language_version: T.nilable(T.any(String, Version))
228+
language_version: T.nilable(T.any(String, Dependabot::Version))
226229
)
227230
.returns(T::Array[Dependabot::Version])
228231
end

0 commit comments

Comments
 (0)