Add regression test for local_archive parallel deploy race

Refs #4232

Author: rockschtar

tests/spec/LocalArchiveTest.php

@@ -0,0 +1,55 @@
+<?php
+/* (c) Anton Medvedev <anton@medv.io>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Deployer;
+
+use spec\SpecTest;
+use Symfony\Component\Console\Output\Output;
+
+class LocalArchiveTest extends SpecTest
+{
+    public const RECIPE = __DIR__ . '/recipe/local_archive.php';
+
+    public static function setUpBeforeClass(): void
+    {
+        parent::setUpBeforeClass();
+        putenv('DEPLOYER_LOCAL_WORKER=false');
+    }
+
+    public static function tearDownAfterClass(): void
+    {
+        putenv('DEPLOYER_LOCAL_WORKER=true');
+        parent::tearDownAfterClass();
+    }
+
+    public function testParallelLocalArchiveDeploy()
+    {
+        $this->init(self::RECIPE);
+        $this->tester->run([
+            'deploy',
+            'selector' => 'all',
+            '-f' => self::RECIPE,
+        ], [
+            'verbosity' => Output::VERBOSITY_VERBOSE,
+        ]);
+
+        $display = $this->tester->getDisplay();
+        self::assertEquals(0, $this->tester->getStatusCode(), $display);
+
+        // Every host must end up with the archived code, not just the worker
+        // that won the race for the shared archive file.
+        foreach ($this->deployer->hosts as $host) {
+            $deployPath = $host->get('deploy_path');
+            self::assertFileExists($deployPath . '/current/README.md', $display);
+        }
+
+        // The fix builds the archive in a unique temp file and cleans it up,
+        // so nothing is left behind in the local git root.
+        $gitRoot = trim((string) shell_exec('git rev-parse --show-toplevel'));
+        self::assertFileDoesNotExist($gitRoot . '/archive.tar');
+    }
+}

tests/spec/recipe/local_archive.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Deployer;
+
+require 'recipe/common.php';
+
+set('update_code_strategy', 'local_archive');
+
+// Worker processes don't inherit the master's in-memory config, so the
+// deploy path has to live in the recipe itself. Mirrors __TEMP_DIR__ from
+// the test bootstrap without relying on test-only constants.
+set('deploy_path', sys_get_temp_dir() . '/deployer/{{hostname}}');
+
+// Archive only the small fixture subtree of the local working copy instead
+// of the whole Deployer tree, so each parallel host uploads a tiny,
+// well-defined payload.
+set('sub_directory', 'tests/fixtures/repository');
+set('keep_releases', 1);
+
+// Several hosts so deploy:update_code runs in multiple parallel workers at
+// once — the scenario in which the shared local archive file used to race
+// (see issue #4232 / PR #4235).
+localhost('alpha');
+localhost('beta');
+localhost('gamma');