Skip to content

Commit 52962f9

Browse files
author
Anthony Du Pont
committed
✨ Release v1.3.9
1 parent 0e3ebc8 commit 52962f9

File tree

23 files changed

+28
-23
lines changed

23 files changed

+28
-23
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,7 @@ This example supports:
329329
- :sparkles: Improve transitions
330330
- :sparkles: Improve documentation
331331
- :art: Rename renderers `init` method to `setup` method
332+
- :bug: Quick fix for URLs with parameters
332333
- :bug: Fix events
333334
- :bug: Fix helpers
334335
- :bug: Skip link with `javascript:` in `href`

dist/es5/highway.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4247,9 +4247,11 @@ function (_Emitter) {
42474247

42484248
var anchor = _helpers.default.getAnchor(href);
42494249

4250+
var params = _helpers.default.getParams(href);
4251+
42504252
var pathname = _helpers.default.getPathname(href);
42514253

4252-
if (!this.navigating && pathname !== this.state.pathname) {
4254+
if (!this.navigating && pathname !== this.state.pathname && !params) {
42534255
// Update link
42544256
this.link = event.currentTarget; // Now push the state!
42554257

@@ -4258,7 +4260,7 @@ function (_Emitter) {
42584260
// If the pathnames are the same there might be an anchor appended to
42594261
// it so we need to check it and reload the page to use the default
42604262
// browser behaviour.
4261-
if (anchor) {
4263+
if (anchor || params) {
42624264
window.location.href = href;
42634265
}
42644266
}

dist/es5/highway.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es5/highway.min.js.gz

10 Bytes
Binary file not shown.

dist/highway.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,9 +583,10 @@ class core_Core extends tiny_emitter_default.a {
583583
// in order to compare it with the current state and handle the `click`
584584
// event appropriately.
585585
const anchor = helpers_Helpers.getAnchor(href);
586+
const params = helpers_Helpers.getParams(href);
586587
const pathname = helpers_Helpers.getPathname(href);
587588

588-
if (!this.navigating && pathname !== this.state.pathname) {
589+
if (!this.navigating && pathname !== this.state.pathname && !params) {
589590
// Update link
590591
this.link = event.currentTarget;
591592

@@ -596,7 +597,7 @@ class core_Core extends tiny_emitter_default.a {
596597
// If the pathnames are the same there might be an anchor appended to
597598
// it so we need to check it and reload the page to use the default
598599
// browser behaviour.
599-
if (anchor) {
600+
if (anchor || params) {
600601
window.location.href = href;
601602
}
602603

dist/highway.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/highway.min.js.gz

11 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)