Merge pull request #2886 from dequelabs/release-4.2

chore(release): version 4.2.0

Author: WilcoFiers

.circleci/config.yml

@@ -23,14 +23,14 @@ set_npm_auth: &set_npm_auth
 restore_dependency_cache_unix: &restore_dependency_cache_unix
   restore_cache:
     keys:
-      - v8-cache-unix-{{ checksum "package.json" }}
-      - v8-cache-unix-
+      - v9-cache-unix-{{ checksum "package-lock.json" }}
+      - v9-cache-unix-
 
 restore_dependency_cache_win: &restore_dependency_cache_win
   restore_cache:
     keys:
-      - v8-cache-win-{{ checksum "package.json" }}
-      - v8-cache-win-
+      - v9-cache-win-{{ checksum "package-lock.json" }}
+      - v9-cache-win-
 
 jobs:
   # Fetch and cache dependencies.
@@ -43,7 +43,7 @@ jobs:
       - <<: *restore_dependency_cache_unix
       - run: npm ci
       - save_cache:
-          key: v8-cache-unix-{{ checksum "package.json" }}
+          key: v9-cache-unix-{{ checksum "package-lock.json" }}
           paths:
             - node_modules
   dependencies_win:
@@ -55,7 +55,7 @@ jobs:
       - <<: *restore_dependency_cache_win
       - run: npm ci
       - save_cache:
-          key: v8-cache-win-{{ checksum "package.json" }}
+          key: v9-cache-win-{{ checksum "package-lock.json" }}
           paths:
             - node_modules
 
@@ -75,7 +75,10 @@ jobs:
     steps:
       - checkout
       - <<: *restore_dependency_cache_unix
-      - run: npm run test
+      - run: npm run build
+      - run: npm run test -- --browsers Chrome,Firefox
+      - run: npm run test:integration:chrome
+      - run: npm run test:integration:firefox
 
   # Run the test suite in IE in windows
   test_win:
@@ -85,18 +88,14 @@ jobs:
       - checkout
       # npm i or restore cache
       - <<: *restore_dependency_cache_win
+      - run: npm run build
+      - run: npm run test -- --browsers IE
       # install selenium
       - run: |
           choco install selenium-ie-driver --version 3.141.5
           export PATH=/c/tools/selenium:$PATH
           echo $PATH
-      # build `axe`
-      - run: npm run build
-      # get fixtures ready for running tests
-      - run: npx grunt testconfig
-      - run: npx grunt fixture
-      # run IE webdriver tests
-      - run: npx grunt connect test-webdriver:ie
+      - run: npm run test:integration:ie
 
   # Run examples under `doc/examples`
   test_examples:
@@ -108,6 +107,16 @@ jobs:
       - run: npm run build
       - run: npm run test:examples
 
+  # Run ACT test cases
+  test_act:
+    <<: *defaults
+    <<: *unix_box
+    steps:
+      - checkout
+      - <<: *restore_dependency_cache_unix
+      - run: npm run build
+      - run: npm run test:act
+
   # Test locale files
   test_locales:
     <<: *defaults
@@ -118,6 +127,20 @@ jobs:
       - run: npm run build
       - run: npm run test:locales
 
+  # Run the test suite for nightly builds.
+  test_nightly:
+    <<: *defaults
+    <<: *unix_box
+    steps:
+      - checkout
+      - <<: *restore_dependency_cache_unix
+      - run: npm run build
+      # install Chrome Canary
+      - run: |
+          wget https://dl.google.com/linux/direct/google-chrome-unstable_current_amd64.deb
+          sudo apt install ./google-chrome-unstable_current_amd64.deb
+      - run: npm run test -- --browsers ChromeCanary,FirefoxNightly
+
   # Test api docs can be built
   build_api_docs:
     <<: *defaults
@@ -155,6 +178,7 @@ jobs:
       - checkout
       - <<: *set_npm_auth
       - <<: *restore_dependency_cache_unix
+      - run: npm run build
       - run: npm run next-release
       - run: .circleci/verify-release.sh
       - run: npm publish --tag=next
@@ -228,6 +252,9 @@ workflows:
       - test_examples:
           requires:
             - test_unix
+      - test_act:
+          requires:
+            - test_unix
       - test_locales:
           requires:
             - test_unix
@@ -296,3 +323,17 @@ workflows:
       - github_release:
           requires:
             - release
+  nightly:
+    triggers:
+      - schedule:
+          # run at 00:00 UTC every day
+          cron: "0 0 * * *"
+          filters:
+            branches:
+              only:
+                - develop
+    jobs:
+      - dependencies_unix
+      - test_nightly:
+          requires:
+            - dependencies_unix

.eslintignore

@@ -1,4 +1,5 @@
 **/node_modules/*
+**/tmp/*
 
 build/tasks/aria-supported.js
 

.eslintrc

@@ -0,0 +1,112 @@
+module.exports = {
+  extends: ['prettier'],
+  parserOptions: {
+    ecmaVersion: 9
+  },
+  env: {
+    node: true,
+    es6: true
+  },
+  globals: {
+    axe: true
+  },
+  rules: {
+    'no-bitwise': 2,
+    camelcase: 2,
+    curly: 2,
+    eqeqeq: 2,
+    'guard-for-in': 2,
+    'wrap-iife': [2, 'any'],
+    'no-use-before-define': [
+      2,
+      {
+        functions: false
+      }
+    ],
+    'new-cap': 2,
+    'no-caller': 2,
+    'no-empty': 2,
+    'no-new': 2,
+    'no-plusplus': 0,
+    'no-undef': 2,
+    'no-unused-vars': 2,
+    strict: 0,
+    'max-params': [2, 6],
+    'max-depth': [2, 5],
+    'max-len': 0,
+    semi: 0,
+    'no-cond-assign': 0,
+    'no-debugger': 2,
+    'no-eq-null': 0,
+    'no-eval': 2,
+    'no-unused-expressions': 0,
+    'block-scoped-var': 0,
+    'no-iterator': 0,
+    'linebreak-style': 0,
+    'no-loop-func': 0,
+    'no-multi-str': 0,
+    'no-proto': 0,
+    'no-script-url': 0,
+    'dot-notation': 2,
+    'no-new-func': 0,
+    'no-new-wrappers': 0,
+    'no-restricted-syntax': [
+      'error',
+      {
+        selector: 'MemberExpression[property.name=tagName]',
+        message: "Don't use node.tagName, use node.nodeName instead."
+      },
+      {
+        // node.attributes can be clobbered so is unsafe to use
+        // @see https://github.com/dequelabs/axe-core/pull/1432
+        selector:
+          'MemberExpression[object.name=node][property.name=attributes]',
+        message:
+          "Don't use node.attributes, use node.hasAttributes() or axe.utils.getNodeAttributes(node) instead."
+      }
+    ]
+  },
+  overrides: [
+    {
+      files: ['lib/**/*.js'],
+      parserOptions: {
+        sourceType: 'module'
+      },
+      env: {
+        browser: true,
+        es6: true
+      },
+      globals: {
+        window: true,
+        document: true
+      },
+      rules: {
+        'func-names': [2, 'as-needed'],
+        'prefer-const': 2
+      }
+    },
+    {
+      files: ['test/**/*.js'],
+      parserOptions: {
+        ecmaVersion: 5
+      },
+      env: {
+        browser: true,
+        es6: false,
+        mocha: true
+      },
+      globals: {
+        assert: true,
+        helpers: true,
+        checks: true,
+        sinon: true
+      },
+      plugins: ['mocha-no-only'],
+      rules: {
+        'new-cap': 0,
+        'no-use-before-define': 0,
+        'mocha-no-only/mocha-no-only': ['error']
+      }
+    }
+  ]
+};

.eslintrc.js

@@ -4,8 +4,12 @@ Thanks for reporting an issue to axe-core. Please provide all necessary info to
 If you’re reporting a bug, include a description of the issue and a page or code snippet where it can be reproduced. Please make sure you have tested this with the latest version of axe-core. When proposing a new rule, please use our rule template: https://github.com/dequelabs/axe-core/blob/develop/doc/rule-proposal.md
 
 Describe what the desired behavior would be, and how it applies to axe-core's  "Accessibility Supported" policy: https://github.com/dequelabs/axe-core/blob/develop/doc/accessibility-supported.md
+
+Issues can be reported for the axe Extension, the axe Linter (VS Code, IntelliJ) as well as the axe-core npm library.
 -->
 
+Product: <<axe-core | axe Extension | axe Linter>>
+
 Expectation: << Describe what you expect the product to do >>
 
 Actual: << Describe what the product actually does >>

.github/ISSUE_TEMPLATE.md

@@ -1,10 +1,3 @@
 << Describe the changes >>
 
 Closes issue:
-
-## Reviewer checks
-
-**Required fields, to be filled out by PR reviewer(s)**
-
-- [ ] Follows the commit message policy, appropriate for next version
-- [ ] Code is reviewed for security

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,16 @@
+# Require that merge commits have security review performed on them.
+review_merges: true
+
+approve_button_tooltip: No security or PR title concerns
+decline_button_tooltip: Found security or PR title concerns
+
+pending_description: Pull request not yet approved for security and a correct PR title
+pending_summary: >
+  Awaiting security and PR title review. To approve this pull request, please click the "Approve" button above.
+  You may **not** review your own Pull Request.
+  
+approved_description: Pull request has been reviewed and approved for security and a correct PR title
+approved_summary: Pull request has been approved for security and having an incorrect PR title by @${approver}.
+
+declined_description: Pull request contains security concerns or has an incorrect PR title
+declined_summary: Commit was reviewed and declined for security and/or an incorrect PR title by @${approver}.

.github/review.yml

@@ -1,6 +1,7 @@
 {
 	"printWidth": 80,
-	"useTabs": true,
+	"useTabs": false,
+  "tabWidth": 2,
 	"semi": true,
 	"singleQuote": true,
 	"trailingComma": "none",