Merge pull request #2140 from dequelabs/release-3.5.3

chore: release 3.5.3

Author: WilcoFiers

CHANGELOG.md

@@ -2,6 +2,22 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [3.5.3](https://github.com/dequelabs/axe-core/compare/v3.5.2...v3.5.3) (2020-03-31)
+
+### Bug Fixes
+
+- **meta-viewport:** parse negative and string values for `maximum-scale` ([#2137](https://github.com/dequelabs/axe-core/issues/2137)) ([8c92472](https://github.com/dequelabs/axe-core/commit/8c92472397676d44b333cf50ad1a9413b9783c2c))
+- **respondable:** ignore reflected messages from iframes ([#2134](https://github.com/dequelabs/axe-core/issues/2134)) ([3ab9f21](https://github.com/dequelabs/axe-core/commit/3ab9f21414d8f4195ac95ffca8f0ce52258539b0))
+- **header-present:** update verbiage to use heading instead of header ([#2132](https://github.com/dequelabs/axe-core/issues/2132)) ([8890063](https://github.com/dequelabs/axe-core/commit/889006397329a35a170f4a3d24c55c3c4fd758fc))
+- **color-contrast:** mark more punctuations for review ([#2126](https://github.com/dequelabs/axe-core/issues/2126)) ([dc98afc](https://github.com/dequelabs/axe-core/commit/dc98afc841c86e4b7b771bbb1171152a151c3e5b))
+- **unicode:** detect supplementary private use area A ([#2102](https://github.com/dequelabs/axe-core/issues/2102)) ([f1739c2](https://github.com/dequelabs/axe-core/commit/f1739c21efdf5cf6fddf425d1c72b056757f3ba1))
+- **definition-list:** Mention <div> is allowed to group content in <dl> ([#2098](https://github.com/dequelabs/axe-core/issues/2098)) ([76b1a9f](https://github.com/dequelabs/axe-core/commit/76b1a9f7f244e43f63351c46d91fc8b27040ba98))
+- **td-headers-attr:** mark as needs review if headers attr is empty ([#2096](https://github.com/dequelabs/axe-core/issues/2096)) ([699b566](https://github.com/dequelabs/axe-core/commit/699b566111cfed2a4ebeade35346a49bcb3546c7))
+- **td-has-headers:** don't fail for empty headers attribute ([#2095](https://github.com/dequelabs/axe-core/issues/2095)) ([7952a37](https://github.com/dequelabs/axe-core/commit/7952a377b960c2403c8d4758a9f35ebe525549fe))
+- **th-has-data-cells:** fail when data cell points to a different header ([#2094](https://github.com/dequelabs/axe-core/issues/2094)) ([d3bd416](https://github.com/dequelabs/axe-core/commit/d3bd416a3df7324231f17ff9e1e20dc6342c7aa5))
+- **has-lang:** update message to indicate that xml:lang is not valid on HTML pages ([#2093](https://github.com/dequelabs/axe-core/issues/2093)) ([c3a7de2](https://github.com/dequelabs/axe-core/commit/c3a7de206baf77c0b25c8c095119393b1dc85f0f))
+- **page-no-duplicate-contentinfo:** do not fail when first element is inside landmark ([#2092](https://github.com/dequelabs/axe-core/issues/2092)) ([eca7e05](https://github.com/dequelabs/axe-core/commit/eca7e05cc6ff750855bcb219833967a9d7087679))
+
 ### [3.5.2](https://github.com/dequelabs/axe-core/compare/v3.5.1...v3.5.2) (2020-03-06)
 
 ### Bug Fixes

README.md

@@ -50,15 +50,16 @@ Now include the javascript file in each of your iframes in your fixtures or test
 Now insert calls at each point in your tests where a new piece of UI becomes visible or exposed:
 
 ```js
-axe.run()
-  .then(results => {
-    if (results.violations.length) {
-      throw new Error('Accessibility issues found')
-    }
-  })
-  .catch(err => {
-    console.error('Something bad happened:', err.message)
-  })
+axe
+	.run()
+	.then(results => {
+		if (results.violations.length) {
+			throw new Error('Accessibility issues found');
+		}
+	})
+	.catch(err => {
+		console.error('Something bad happened:', err.message);
+	});
 ```
 
 ## Supported Browsers

bower.json

@@ -1,6 +1,6 @@
 {
 	"name": "axe-core",
-	"version": "3.5.2",
+	"version": "3.5.3",
 	"contributors": [
 		{
 			"name": "David Sturley",

doc/API.md

@@ -268,7 +268,7 @@ axe.run(context, options, (err, results) => {
 By default, `axe.run` will test the entire document. The context object is an optional parameter that can be used to specify which element should and which should not be tested. It can be passed one of the following:
 
 1. An element reference that represents the portion of the document that must be analyzed
-    - Example: To limit analysis to the `<div id="content">` element: `document.getElementById("content")`
+   - Example: To limit analysis to the `<div id="content">` element: `document.getElementById("content")`
 1. A NodeList such as returned by `document.querySelectorAll`.
 1. A [CSS selector](./developer-guide.md#supported-css-selectors) that selects the portion(s) of the document that must be analyzed.
 1. An include-exclude object (see below)

doc/rule-descriptions.md

@@ -44,7 +44,7 @@
 | [image-alt](https://dequeuniversity.com/rules/axe/3.5/image-alt?application=RuleDescription)                                     | Ensures <img> elements have alternate text or a role of none or presentation                            | Critical          | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a                   | failure                    |
 | [input-button-name](https://dequeuniversity.com/rules/axe/3.5/input-button-name?application=RuleDescription)                     | Ensures input buttons have discernible text                                                                   | Critical          | cat.name-role-value, wcag2a, wcag412, section508, section508.22.a                     | failure                    |
 | [input-image-alt](https://dequeuniversity.com/rules/axe/3.5/input-image-alt?application=RuleDescription)                         | Ensures <input type="image"> elements have alternate text                                     | Critical          | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a                   | failure                    |
-| [label](https://dequeuniversity.com/rules/axe/3.5/label?application=RuleDescription)                                             | Ensures every form element has a label                                                                        | Minor, Critical   | cat.forms, wcag2a, wcag332, wcag131, section508, section508.22.n                      | failure                    |
+| [label](https://dequeuniversity.com/rules/axe/3.5/label?application=RuleDescription)                                             | Ensures every form element has a label                                                                        | Minor, Critical   | cat.forms, wcag2a, wcag412, wcag131, section508, section508.22.n                      | failure                    |
 | [link-name](https://dequeuniversity.com/rules/axe/3.5/link-name?application=RuleDescription)                                     | Ensures links have discernible text                                                                           | Serious           | cat.name-role-value, wcag2a, wcag412, wcag244, section508, section508.22.a            | failure                    |
 | [list](https://dequeuniversity.com/rules/axe/3.5/list?application=RuleDescription)                                               | Ensures that lists are structured correctly                                                                   | Serious           | cat.structure, wcag2a, wcag131                                                        | failure                    |
 | [listitem](https://dequeuniversity.com/rules/axe/3.5/listitem?application=RuleDescription)                                       | Ensures <li> elements are used semantically                                                             | Serious           | cat.structure, wcag2a, wcag131                                                        | failure                    |
@@ -55,7 +55,7 @@
 | [scrollable-region-focusable](https://dequeuniversity.com/rules/axe/3.5/scrollable-region-focusable?application=RuleDescription) | Elements that have scrollable content should be accessible by keyboard                                        | Moderate          | wcag2a, wcag211                                                                       | failure                    |
 | [server-side-image-map](https://dequeuniversity.com/rules/axe/3.5/server-side-image-map?application=RuleDescription)             | Ensures that server-side image maps are not used                                                              | Minor             | cat.text-alternatives, wcag2a, wcag211, section508, section508.22.f                   | needs review          |
 | [svg-img-alt](https://dequeuniversity.com/rules/axe/3.5/svg-img-alt?application=RuleDescription)                                 | Ensures svg elements with an img, graphics-document or graphics-symbol role have an accessible text           | Serious           | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a                   | failure                    |
-| [td-headers-attr](https://dequeuniversity.com/rules/axe/3.5/td-headers-attr?application=RuleDescription)                         | Ensure that each cell in a table using the headers refers to another cell in that table                       | Serious           | cat.tables, wcag2a, wcag131, section508, section508.22.g                              | failure                    |
+| [td-headers-attr](https://dequeuniversity.com/rules/axe/3.5/td-headers-attr?application=RuleDescription)                         | Ensure that each cell in a table using the headers refers to another cell in that table                       | Serious           | cat.tables, wcag2a, wcag131, section508, section508.22.g                              | failure, needs review |
 | [th-has-data-cells](https://dequeuniversity.com/rules/axe/3.5/th-has-data-cells?application=RuleDescription)                     | Ensure that each table header in a data table refers to data cells                                            | Serious           | cat.tables, wcag2a, wcag131, section508, section508.22.g                              | failure, needs review |
 | [valid-lang](https://dequeuniversity.com/rules/axe/3.5/valid-lang?application=RuleDescription)                                   | Ensures lang attributes have valid values                                                                     | Serious           | cat.language, wcag2aa, wcag312                                                        | failure                    |
 | [video-caption](https://dequeuniversity.com/rules/axe/3.5/video-caption?application=RuleDescription)                             | Ensures <video> elements have captions                                                                  | Critical          | cat.text-alternatives, wcag2a, wcag122, section508, section508.22.a                   | needs review          |

lib/checks/keyboard/page-no-duplicate.js

@@ -15,7 +15,7 @@ axe._cache.set(key, true);
 let elms = axe.utils.querySelectorAllFilter(
 	axe._tree[0],
 	options.selector,
-	elm => elm !== virtualNode && axe.commons.dom.isVisible(elm.actualNode)
+	elm => axe.commons.dom.isVisible(elm.actualNode)
 );
 
 // Filter elements that, within certain contexts, don't map their role.
@@ -29,6 +29,8 @@ if (typeof options.nativeScopeFilter === 'string') {
 	});
 }
 
-this.relatedNodes(elms.map(elm => elm.actualNode));
+this.relatedNodes(
+	elms.filter(elm => elm !== virtualNode).map(elm => elm.actualNode)
+);
 
-return elms.length === 0;
+return elms.length <= 1;

lib/checks/language/has-lang.js

@@ -3,8 +3,18 @@ const { isXHTML } = axe.utils;
 const langValue = (node.getAttribute(`lang`) || '').trim();
 const xmlLangValue = (node.getAttribute(`xml:lang`) || '').trim();
 
-if (!langValue && !isXHTML(document)) {
+if (!langValue && xmlLangValue && !isXHTML(document)) {
+	this.data({
+		messageKey: 'noXHTML'
+	});
 	return false;
 }
 
-return !!(langValue || xmlLangValue);
+if (!(langValue || xmlLangValue)) {
+	this.data({
+		messageKey: 'noLang'
+	});
+	return false;
+}
+
+return true;

lib/checks/language/has-lang.json

@@ -5,7 +5,10 @@
 		"impact": "serious",
 		"messages": {
 			"pass": "The <html> element has a lang attribute",
-			"fail": "The <html> element does not have a lang attribute"
+			"fail": {
+				"noXHTML": "The xml:lang attribute is not valid on HTML pages, use the lang attribute.",
+				"noLang": "The <html> element does not have a lang attribute"
+			}
 		}
 	}
 }

lib/checks/mobile/meta-viewport-scale.js

@@ -1,22 +1,33 @@
-options = options || {};
-var params,
-	content = node.getAttribute('content') || '',
-	parsedParams = content.split(/[;,]/),
-	result = {},
-	minimum = options.scaleMinimum || 2,
-	lowerBound = options.lowerBound || false;
-
-for (var i = 0, l = parsedParams.length; i < l; i++) {
-	params = parsedParams[i].split('=');
-	var key = params.shift().toLowerCase();
-	if (key && params.length) {
-		result[key.trim()] = params
-			.shift()
-			.trim()
-			.toLowerCase();
-	}
+const { scaleMinimum = 2, lowerBound = false } = options || {};
+
+const content = node.getAttribute('content') || '';
+if (!content) {
+	return true;
 }
 
+const result = content.split(/[;,]/).reduce((out, item) => {
+	const contentValue = item.trim();
+	if (!contentValue) {
+		return out;
+	}
+
+	const [key, value] = contentValue.split('=');
+	const curatedKey = key.toLowerCase().trim();
+	let curatedValue = value.toLowerCase().trim();
+
+	// convert `yes` to `1`
+	if (curatedKey === 'maximum-scale' && curatedValue === 'yes') {
+		curatedValue = 1;
+	}
+	// when negative ignore key
+	if (curatedKey === 'maximum-scale' && parseFloat(curatedValue) < 0) {
+		return out;
+	}
+
+	out[curatedKey] = curatedValue;
+	return out;
+}, {});
+
 if (
 	lowerBound &&
 	result['maximum-scale'] &&
@@ -30,7 +41,10 @@ if (!lowerBound && result['user-scalable'] === 'no') {
 	return false;
 }
 
-if (result['maximum-scale'] && parseFloat(result['maximum-scale']) < minimum) {
+if (
+	result['maximum-scale'] &&
+	parseFloat(result['maximum-scale']) < scaleMinimum
+) {
 	this.data('maximum-scale');
 	return false;
 }

lib/checks/navigation/header-present.json

@@ -4,8 +4,8 @@
 	"metadata": {
 		"impact": "serious",
 		"messages": {
-			"pass": "Page has a header",
-			"fail": "Page does not have a header"
+			"pass": "Page has a heading",
+			"fail": "Page does not have a heading"
 		}
 	}
 }