-
Notifications
You must be signed in to change notification settings - Fork 847
Open
Labels
performancePerformance related issuesPerformance related issues
Description
From @WilcoFiers in regards to #2635:
I think there are a lot more places in axe-core that now we have a cache of ID references we could speed up. Probably best to open a tech debt issue for that one instead of pile it onto this PR. Here's a list though:
- checks
- aria-required-parent-evaluate
- explicit-evaluate
- hidden-explicit-label-evaluate
- multiple-labels
- duplicate-id-evaluate
- matches
- duplicate-id-active-matches
- duplicate-id-misc-matches
- scrollable-region-focusable-matches
- commons
- text.labelVirtual
- dom.findElmsInContext
- dom.isVisible (usemap lookup)
To make that easier, we can probably simplify by having something like a idrefsReverse function, that takes a node (with an ID) and an attribute and looks up any element references the ID with that attribute. I'll leave it up to you if you want to do that in this PR or another.
const virtualControls = idrefsReverse(ancestorNode, 'aria-labelledby')
.map(control => getNodeFromTree(control));WilcoFiers
Metadata
Metadata
Assignees
Labels
performancePerformance related issuesPerformance related issues