docs: ♻️ add some todos what to improve

Author: dergecko

test-certs/src/configuration/certificates.rs

@@ -25,6 +25,7 @@ pub struct CertificateAuthorityConfiguration {
 }
 
 /// A certificate used for client authentication.
+// NOTE: A shared basic cert configuration could come in handy to not have to duplicate all cert properties for clients and servers
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(deny_unknown_fields)]
 pub struct ClientConfiguration {
@@ -33,7 +34,9 @@ pub struct ClientConfiguration {
     pub export_key: bool,
 
     /// Ip address of the client.
+    // TODO: maybe allow multiple Ip addresses?
     pub ip: IpAddr,
+    // TODO: Have a dns name that is used for the subject alt names
 }
 
 /// A certificate used for server authentication.
@@ -45,7 +48,9 @@ pub struct ServerConfiguration {
     pub export_key: bool,
 
     /// Ip address of the server.
+    // TODO: maybe allow multiple Ip addresses?
     pub ip: IpAddr,
+    // TODO: Have a dns name that is used for the subject alt names
 }
 
 /// All kinds of different certificates.

test-certs/src/generation.rs

@@ -13,7 +13,8 @@ use crate::{
     Certificate, Error,
 };
 
-/// Trait to convert [`CertificateType`] to [`Certificate`].
+/// Extension trait to convert [`CertificateType`] to [`Certificate`].
+// NOTE: Instead of a trait use actual types?
 pub trait CertificateGenerator {
     /// Build a [`Certificate`].
     fn build(&self, name: &str, issuer: Option<&Certificate>) -> Result<Certificate, Error>;