Persist setting path outside of the singleton.

Author: dero

src/app/hideous_app.cpp

@@ -68,7 +68,7 @@ int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine
     GetModuleFileName(NULL, processPath, MAX_PATH);
     PathRemoveFileSpec(processPath);
 
-    SettingsManager::getInstance().persistSettingsPath(processPath);
+    persistSettingsPath(processPath);
 
     // Icons
     HICON hIcon = LoadIcon(hInstance, MAKEINTRESOURCE(IDI_APPICON));

src/common/settings.cpp

@@ -142,11 +142,11 @@ SettingsManager::SettingsManager()
 	m_settings = loadSettings();
 }
 
-bool SettingsManager::persistSettingsPath(const std::wstring &path)
+bool persistSettingsPath(const std::wstring &path)
 {
 	HKEY hKey;
 	LONG result = RegCreateKeyExW(
-		HKEY_CURRENT_USER, // or HKEY_CURRENT_USER if preferred
+		HKEY_CURRENT_USER,
 		REG_KEY_PATH,
 		0,
 		NULL,

src/common/settings.h

@@ -34,7 +34,6 @@ class SettingsManager
     const Settings &getSettings() const { return m_settings; }
     std::vector<std::wstring> getAvailableProfiles();
     bool switchToProfile(const std::wstring &profileName);
-    bool persistSettingsPath(const std::wstring &path);
     std::wstring SettingsManager::currentProfile();
     std::wstring getAppPath();
 
@@ -55,5 +54,6 @@ std::wstring trim(const std::wstring &str);
 std::wstring virtualKeyCodeToString(WORD vk);
 WORD stringToVirtualKeyCode(const std::wstring &str);
 std::vector<INPUT> convertStringToInput(const std::wstring &keyString);
+bool persistSettingsPath(const std::wstring &path);
 
 extern std::unordered_map<std::wstring, WORD> keyMap;