Skip to content

Commit 22eef09

Browse files
committed
chore: Use set comparison
1 parent 6e12f01 commit 22eef09

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

modeltranslation/tests/tests.py

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,20 +1024,17 @@ def test_reverse_relations(self):
10241024
# Check that the reverse accessors are created on the model:
10251025
# Explicit related_name
10261026
testmodel_fields = get_field_names(models.TestModel)
1027-
testmodel_methods = dir(models.TestModel)
1028-
assert "test_fks" in testmodel_fields
1029-
assert "test_fks_de" in testmodel_fields
1030-
assert "test_fks_en" in testmodel_fields
1031-
assert "test_fks" in testmodel_methods
1032-
assert "test_fks_de" in testmodel_methods
1033-
assert "test_fks_en" in testmodel_methods
1027+
testmodel_methods = set(dir(models.TestModel))
1028+
1029+
assert {"test_fks", "test_fks_de", "test_fks_en"} <= testmodel_fields
1030+
assert {"test_fks", "test_fks_de", "test_fks_en"} <= testmodel_methods
10341031
# Implicit related_name: manager descriptor name != query field name
1035-
assert "foreignkeymodel" in testmodel_fields
1036-
assert "foreignkeymodel_de" in testmodel_fields
1037-
assert "foreignkeymodel_en" in testmodel_fields
1038-
assert "foreignkeymodel_set" in testmodel_methods
1039-
assert "foreignkeymodel_set_de" in testmodel_methods
1040-
assert "foreignkeymodel_set_en" in testmodel_methods
1032+
assert {"foreignkeymodel", "foreignkeymodel_de", "foreignkeymodel_en"} <= testmodel_fields
1033+
assert {
1034+
"foreignkeymodel_set",
1035+
"foreignkeymodel_set_de",
1036+
"foreignkeymodel_set_en",
1037+
} <= testmodel_methods
10411038

10421039
# Check the German reverse accessor:
10431040
assert fk_inst_both in instance.test_fks_de.all()

0 commit comments

Comments
 (0)