Error parsing (#107)

Author: itaihanski

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.9.2
+
+- Add exception parsing from server response
+
 # 0.9.1
 
 - Support passkeys in Flutter Web

lib/src/internal/http/descope_client.dart

@@ -1,3 +1,5 @@
+import 'dart:convert';
+
 import '/src/internal/others/error.dart';
 import '/src/sdk/config.dart';
 import '/src/sdk/sdk.dart';
@@ -361,6 +363,19 @@ class DescopeClient extends HttpClient {
         'x-descope-sdk-version': DescopeSdk.version,
       };
 
+  @override
+  DescopeException? exceptionFromResponse(String response) {
+    try {
+      final json = jsonDecode(response) as Map<String, dynamic>;
+      var code = json["errorCode"] as String;
+      var desc = json["errorDescription"] as String?;
+      var message = json["errorMessage"] as String?;
+      return DescopeException(code: code, desc: desc ?? "Descope server error", message: message);
+    } catch (e) {
+      return null;
+    }
+  }
+
   Map<String, String> authorization(String? value) {
     return value != null ? {'Authorization': 'Bearer ${config.projectId}:$value'} : {};
   }

lib/src/internal/http/http_client.dart

@@ -45,6 +45,10 @@ class HttpClient {
 
   Map<String, String> get defaultHeaders => {};
 
+  DescopeException? exceptionFromResponse(String response) {
+    return null;
+  }
+
   // Internal
 
   Future<T> call<T>(http.Request request, ResponseDecoder<T> decoder) async {
@@ -90,8 +94,10 @@ class HttpClient {
   }
 
   String parseResponse(http.Response response) {
-    throwErrorIfNeeded(response.statusCode);
-    return response.body;
+    if (response.statusCode >= 200 && response.statusCode <= 299) {
+      return response.body;
+    }
+    throw exceptionFromResponse(response.body) ?? generalServerError(response.statusCode);
   }
 }
 
@@ -113,32 +119,29 @@ extension CompactMap<T> on Map<String, T?> {
 
 const String invalidResponse = 'The server returned an unexpected response';
 
-void throwErrorIfNeeded(int statusCode) {
-  final desc = errorDescriptionFromCode(statusCode);
-  if (desc != null) {
-    throw InternalErrors.httpError.add(desc: desc);
-  }
-}
-
-String? errorDescriptionFromCode(int statusCode) {
-  if (statusCode >= 200 && statusCode <= 299) {
-    return null;
-  }
+DescopeException generalServerError(int statusCode) {
+  String desc;
   switch (statusCode) {
     case 400:
-      return 'The request was invalid';
+      desc = 'The request was invalid';
+      break;
     case 401:
-      return 'The request was unauthorized';
+      desc = 'The request was unauthorized';
+      break;
     case 403:
-      return 'The request was forbidden';
+      desc = 'The request was forbidden';
+      break;
     case 404:
-      return 'The resource was not found';
+      desc = 'The resource was not found';
+      break;
     case 500:
     case 503:
-      return "The server failed with status code $statusCode";
+      desc = "The server failed with status code $statusCode";
+      break;
     default:
-      return statusCode >= 500 ? 'The server was unreachable' : "The server returned status code $statusCode";
+      desc = statusCode >= 500 ? 'The server was unreachable' : "The server returned status code $statusCode";
   }
+  return InternalErrors.httpError.add(desc: desc);
 }
 
 // Default Network Client

lib/src/sdk/sdk.dart

@@ -22,7 +22,7 @@ class DescopeSdk {
   static const name = 'DescopeFlutter';
 
   /// The Descope SDK version
-  static const version = '0.9.1';
+  static const version = '0.9.2';
 
   /// The configuration of the [DescopeSdk] instance.
   final DescopeConfig config;

pubspec.yaml

@@ -1,6 +1,6 @@
 name: descope
 description: A Flutter package for working with the Descope API.
-version: 0.9.1
+version: 0.9.2
 homepage: https://www.descope.com
 repository: https://github.com/descope/descope-flutter
 issue_tracker: https://github.com/descope/descope-flutter/issues