Skip to content

Commit 8f9598d

Browse files
authored
default role (#520)
1 parent e1e4c12 commit 8f9598d

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

lib/management/role.test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,17 @@ describe('Management Role', () => {
4949
};
5050
mockHttpClient.post.mockResolvedValue(httpResponse);
5151

52-
const resp = await management.role.create('name', 'description', ['p1', 'p2'], 't1');
52+
const resp = await management.role.create('name', 'description', ['p1', 'p2'], 't1', true);
5353

5454
expect(mockHttpClient.post).toHaveBeenCalledWith(
5555
apiPaths.role.create,
56-
{ name: 'name', description: 'description', permissionNames: ['p1', 'p2'], tenantId: 't1' },
56+
{
57+
name: 'name',
58+
description: 'description',
59+
permissionNames: ['p1', 'p2'],
60+
tenantId: 't1',
61+
default: true,
62+
},
5763
{ token: 'key' },
5864
);
5965

@@ -82,6 +88,7 @@ describe('Management Role', () => {
8288
'description',
8389
['p1', 'p2'],
8490
't1',
91+
true,
8592
);
8693

8794
expect(mockHttpClient.post).toHaveBeenCalledWith(
@@ -92,6 +99,7 @@ describe('Management Role', () => {
9299
newName: 'newName',
93100
description: 'description',
94101
permissionNames: ['p1', 'p2'],
102+
default: true,
95103
},
96104
{ token: 'key' },
97105
);

lib/management/role.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@ const withRole = (sdk: CoreSdk, managementKey?: string) => ({
1313
description?: string,
1414
permissionNames?: string[],
1515
tenantId?: string,
16+
defaultRole?: boolean,
1617
): Promise<SdkResponse<never>> =>
1718
transformResponse(
1819
sdk.httpClient.post(
1920
apiPaths.role.create,
20-
{ name, description, permissionNames, tenantId },
21+
{ name, description, permissionNames, tenantId, default: defaultRole },
2122
{ token: managementKey },
2223
),
2324
),
@@ -27,11 +28,12 @@ const withRole = (sdk: CoreSdk, managementKey?: string) => ({
2728
description?: string,
2829
permissionNames?: string[],
2930
tenantId?: string,
31+
defaultRole?: boolean,
3032
): Promise<SdkResponse<never>> =>
3133
transformResponse(
3234
sdk.httpClient.post(
3335
apiPaths.role.update,
34-
{ name, newName, description, permissionNames, tenantId },
36+
{ name, newName, description, permissionNames, tenantId, default: defaultRole },
3537
{ token: managementKey },
3638
),
3739
),

lib/management/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ export type Role = {
260260
permissionNames: string[];
261261
createdTime: number;
262262
tenantId?: string;
263+
default?: boolean;
263264
};
264265

265266
/** Search roles based on the parameters */

0 commit comments

Comments
 (0)